Select Git revision
Search by author
- Any Author
- authors
-
72162444 72162444 gaochangning
-
Aakash Dave aakash.dave
-
Aaron Kim akim
-
Aaron Kloc akloc
-
Aaron Lan aaron.lan
-
Aaron Nabil aaronna
-
Aaron Pohle aaron.pohle
-
Abbott Chung chung.abbott
-
Abdallah Omar abdallah_omar
-
Abdessamii Chalbi abdessamii.chalbi
-
Abdul Hussain Sirajudeen abdul.hussain
-
Abdullah Alghamdi a.alghamdi
-
Abdullah Elmarghany abdullah_elmarghany
-
Abel Fang abel_fang
-
Abhijeet Badurkar abhijeet.badurkar
-
Abhijit Adsule adsule
-
Abhijit Murthy abhijit
-
Abhi Khanal akhanal
-
Abhilash Sahoo abhilashsahoo
-
Abhimanyu Raj abhimanyu.raj
- Sep 27, 2022
-
-
Jose Dapena Paz authored
Recent changes to include support for PMULL require arm_neon.h header. This was added for Clang, but not for GCC. Also, we need to add AES instruction set to the module level statement. Bug: 819294 Change-Id: I442d5a3d3e33aa78f08f9ee1d5a4035f16b25b46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3917532 Commit-Queue: José Dapena Paz <jdapena@igalia.com> Reviewed-by:
Adenilson Cavalcanti <cavalcantii@chromium.org> Cr-Commit-Position: refs/heads/main@{#1051716} NOKEYCHECK=True GitOrigin-RevId: cdf142aad5b43835fb9947293ec3bcbe886fef18
-
- May 31, 2022
-
-
Henrique Ferreiro authored
That target is only used in //third_party/zlib:*, so make that explicit. From documentation (https://gn.googlesource.com/gn/+/master/docs/reference.md#var_visibility) this change will make the given target 'private' only to the current build file. No expected change in behavior, but a nice cleanup. Change-Id: I0bc111bd7bda05b450f7d1b82aebbd5bdc746b05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3672796 Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Cr-Commit-Position: refs/heads/main@{#1009027} NOKEYCHECK=True GitOrigin-RevId: f2c70a1264eff5f762bf97d2c50e15116c2633dc
-
- May 17, 2022
-
-
Adenilson Cavalcanti authored
Plus add flag for unused variables since it is active on V8 bazel builders. Bug: 103721 Change-Id: I73eac19583e567434d9971ef112562fe18d42a60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3646604 Reviewed-by:
Chris Blume <cblume@chromium.org> Commit-Queue: Adenilson Cavalcanti <cavalcantii@chromium.org> Cr-Commit-Position: refs/heads/main@{#1004117} NOKEYCHECK=True GitOrigin-RevId: 0ff4a51a6dc62ede3e208f80ac01520b690b7f99
-
- May 02, 2022
-
-
Arthur Eubanks authored
Fix an instance in libevent. Sink -Wno-deprecated-non-prototype into zlib, it's the only remaining library where this warning fires. (upstream bug https://github.com/madler/zlib/issues/633) Bug: 1314867 Change-Id: I2547ba1b358ab90ec6dece4f0879b2ebe6f59820 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3615937 Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Arthur Eubanks <aeubanks@google.com> Cr-Commit-Position: refs/heads/main@{#998593} NOKEYCHECK=True GitOrigin-RevId: cbba1d4d16d3dfeb51421749cafa34c2666f8b26
-
- Apr 30, 2022
-
-
Noel Gordon authored
If USE_ZLIB_RABIN_KARP_ROLLING_HASH build-time option is defined, use the Rabin-Karp hash. This disables CRC SIMD hashing on ARM and Intel, which will degrade compression speed. However, the compressed output matches canonical zlib output, for the same input, and that should resolve ASOP OTA issue 1316541. To ensure the Rabin-Karp hash is used correctly in chromium zlib, the first step is to go back to using canonical fill_window(). To do this combine the ARM NEON and Intel SSE2 slide_hash() routines in a common framework called slide_hash_simd(). Remove fill_window_sse.c and undo deflate_read_buf() rename: name it back to canonical read_buf(). Change insert_string(): by default it uses CRC32C hashes on all ports (ARM, Intel) so add code comments to state that. If Rabin-Karp hashes are enabled, disable CRC32C hashes. Add a new deflate internal state variable chromium_zlib_hash, used to detect which type of hashing is enabled (Rabin-Karp, CRC32C). Set the state variable in deflateInit2_ after cpu_check_features() detection, with #ifdef guards matching the #ifdef logic of insert_string(). Change canonical fill_window() to insert hashes into {hash,prev} hash chains based on hash type (Rabin-Karp, CRC32C). Prior to this change, the ARM port was inserting Rabin-Karp hashes into hash chains even if CRC32 hashing was active when s->insert was > 0. Change longest_match() and deflate_fast(): update them to use the new deflate state variable chromium_zlib_hash. Compression performance degrades when Rabin-Karp hashing is used, but is unchanged when CRC32C hashing is enabled (chromium zlib default). Compat: if Rabin-Karp hashing is enabled, zlib-bench --check built as normal and against canonical zlib 1.2.11, produce the same compressed output for the snappy corpora for gzip,zlib,raw types and compression levels 1..9. Bug: 1316541 Change-Id: I0d5ee6240f0b7eac4653d60a29d459d994c3871f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3596671 Reviewed-by:
-
- Oct 12, 2021
-
-
Peter Kasting authored
Bug: 1203071 Change-Id: I04ee9d41de53bc5b09ad552fff8e76ca4399d9ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3216996 Commit-Queue: Peter Kasting <pkasting@chromium.org> Commit-Queue: Dirk Pranke <dpranke@google.com> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/main@{#930624} NOKEYCHECK=True GitOrigin-RevId: 3884c1f0647dccabe81e148e0184a595c2e030d9
-
- Oct 06, 2021
-
-
Ng Zhi An authored
Bug: chromium:1255096 Change-Id: Id4515f5d4a01b0f681b63fcf27f3a2dc8846cb72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3206541 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by:
-
- May 27, 2021
-
-
Jamie Madill authored
These tools call IO APIs not available in UWP. Bug: 1207895 Change-Id: I1fd627a72df29f1872d8086e4b0fe981b60999b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2920671 Auto-Submit: Jamie Madill <jmadill@chromium.org> Reviewed-by:
-
Noel Gordon authored
Minizip is a library provided by //third_party/zlib. Its zip and unzip tools can be built in a developer checkout for testing purposes with: autoninja -C out/Release minizip_bin autoninja -C out/Release miniunz_bin Add GN build rules for these files. Patch minizip and miniunz tools so they compile. Add a patch file and minizip.md for usage. On Android, disable large file support (see bug comment #12). off_t is 32 bits (instead of 64 bits) and should compile on the bots where this patch failed compile before [1] and was reverted (CL:2895825). [1] Added CQ android_asan, android_archive_rel_ng try jobs to pre-test that compile works on these waterfall builders. Bug: 1207895 Change-Id: Idbb3414a2c14fc541e31d6eff97859245296003f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2919568 Reviewed-by:
-
- May 14, 2021
-
-
Maggie Cai authored
This reverts commit 741c3736b5f1a015a6d34bd8393f3074313b4466. Reason for revert: This CL is the likely cause for the tree closure with build compile failure in https://ci.chromium.org/ui/p/chromium/builders/ci/android-archive-rel/20566/overview. Error message: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8847293948719164656/+/steps/compile/0/stdout Original change's description: > [zlib] Build minizip zip and unzip tools > > Minizip is a library provided by //third_party/zlib. Its zip and unzip > tools can be built in a developer checkout for testing purposes with: > > autoninja -C out/Release minizip_bin > autoninja -C out/Release miniunz_bin > > Add GN build rules for these files. Patch minizip and miniunz tools so > they compile (all bots). Add a patch file and minizip.md for usage. > > Bug: 1207895 > Change-Id: Ia2e1a920445414fed78e14d9195e484f209cf089 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2887385 > Commit-Queue: Noel Gordon <noel@chromium.org> > Reviewed-by:
-
Noel Gordon authored
Minizip is a library provided by //third_party/zlib. Its zip and unzip tools can be built in a developer checkout for testing purposes with: autoninja -C out/Release minizip_bin autoninja -C out/Release miniunz_bin Add GN build rules for these files. Patch minizip and miniunz tools so they compile (all bots). Add a patch file and minizip.md for usage. Bug: 1207895 Change-Id: Ia2e1a920445414fed78e14d9195e484f209cf089 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2887385 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
-
- Nov 21, 2020
-
-
Hans Wennborg authored
These tests are in zlib_unittests, and that's already built and run by the bots (after crrev.com/804566). This removes the redundancy of building and running them twice, and takes some load of the already very large unit_tests target. While here, also move the zip and compression_utils to zlib_unittests and try to clean up chrome/test/BUILD.gn from unnecessary zlib references. Bug: 352073 Change-Id: I3cfe020df9bc2699bbb160ae95b511840589e054 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2534930 Commit-Queue: Hans Wennborg <hans@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
-
- Sep 04, 2020
-
-
Hans Wennborg authored
The zlib test suite has 96% coverage of the 'optimizations' folder and is part of the development workflow (i.e. used to validate correctness of zlib patches). This change will ensure that the test suite will run as part of the buildbots. Bug: 1113596, 1124704 Change-Id: Icfcc88cfa5d1165549521d18915c743e45ceb782 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390654 Reviewed-by:
-
- Sep 01, 2020
-
-
Jamie Madill authored
This will ensure changes to the headers force rebuilds of each zlib source set target. This was picked up by a tool in ANGLE (i.e. scripts/export_targets.py). Bug: 1032721 Change-Id: Id64d02e1a11faefce2a88fb740e9bf1db32763dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383291 Commit-Queue: Adenilson Cavalcanti <cavalcantii@chromium.org> Reviewed-by:
-
- Aug 04, 2020
-
-
Hans Wennborg authored
This adds a new fuzzer which first deflates and then inflates some data one chunk at a time and verifies that it round-trips correctly. It's targeted at the recent bug where inffast_chunk was called with overlapping from and out buffers. I've verified that the fuzzer detects the incorrect inflate results when using Clang's -basic-aa-recphi option before the bug fix in e0f88a9. Furthermore, this patch adds asserts in inffast_chunk and other functions that verify there's no overlap of restrict-qualified buffers. (I've checked that the fuzzer hits the inffast_chunk assert before e0f88a9). To make those asserts work, this changes the build config to define ZLIB_DEBUG in debug and fuzzer builds. Bug: 1103818, 708726 Change-Id: Ia3d5e7906b8b1a65d56a589d8a81d17661e638c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332705 Commit-Queue: Hans Wennborg <hans@chromium.org> Reviewed-by:
-
- Jul 27, 2020
-
-
Sylvain Defresne authored
As https://crrev.com/c/2299189 adds `OS_MAC` & `OS_APPLE`, add a gn variable `is_apple` that is true when `OS_APPLE` is defined. This allow an easy mapping between gn variables and cpp macros. Convert all usages of `is_ios || is_mac` or `is_mac || is_ios` to use the new variable instead. Bug: 1105907 Change-Id: I4cef55496a0ccf0a6162e60409ff3b7996f633dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315695 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
-
- Jun 24, 2020
-
-
Nico Weber authored
Doesn't build at all, but hey, it's a start. Bug: 1098899 Change-Id: I63500b3650b315c47219614cc9ae9a3ddbcf42c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264499 Commit-Queue: Mark Mentovai <mark@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#782116} Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src Cr-Mirrored-Commit: 0347dc10a71fbb47457f639f7f908bdeaafbebc8
-
- May 26, 2020
-
-
Adenilson Cavalcanti authored
The idea is to allow building the utests outside of Chromium directory structure, thus allowing to run the tests as part of AOSP or any other downstream project. Bug: 1032721 Change-Id: I21a93b35221a9f5438c8a50908af05725c28022a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210904 Reviewed-by:
-
- May 21, 2020
-
-
Adenilson Cavalcanti authored
This change enables building zlib using -O3 for the remaining code [1] including the portable files (e.g. deflate.c, etc). [1] We were already using optimize_speed for the majority of SIMD code and this CL extends that to build the same code we ship to users. Bug: 1084371 Change-Id: I02b0da7d0849478714bb7e3388c0d218fd13ecda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2197140 Reviewed-by:
-
- Apr 29, 2020
-
-
Adenilson Cavalcanti authored
There is a test suite in Canonical zlib that ensures correctness and coverage of inflate/deflate: the inflate cover (infcover.c) suite. This patch imports the inflate cover suite with the necessary changes to make it build and run under Chromes's C++11 GTEST test system. There are minimal changes (i.e. undefined 'local', miscellaneous C casts to use C++ casts, etc) so we can build it as C++ code and hook into GTEST e.g. use EXPECT_TRUE instead of C assert from <assert.h>. Adds a patch file for these changes, that can be applied on Canonical infcover should we need to sync with a new Canonical zlib release. TODO: there's one test accessing a symbol that causes link errors so comment that code out for now. Bug: 1032721 Change-Id: I004a1357d46d909ad3a5a5bacc5f9ab9bfcb7809 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2168792 Reviewed-by:
-
- Apr 22, 2020
-
-
Collin Baker authored
This reverts commit 591bbce5ef7136253ac799078a51aac60553e578. Reason for revert: compile failure: https://ci.chromium.org/p/chromium/builders/ci/win32-archive-rel/12393 Original change's description: > [zlib] Import canonical zlib inflate cover tests > > There is a test suite in Canonical zlib that ensures correctness and > coverage of inflate/deflate: the inflate cover (infcover.c) suite. > > This patch imports the inflate cover suite with the necessary changes > to make it build and run under Chromes's C++11 GTEST test system. > > There are minimal changes (i.e. undefined 'local', miscellaneous C > casts to use C++ casts, etc) so we can build it as C++ code and hook > into GTEST e.g. use EXPECT_TRUE instead of C assert from <assert.h>. > > Adds a patch file for these changes, that can be applied on Canonical > infcover should we need to sync with a new Canonical zlib release. > > TODO: there's one test accessing a symbol that causes link errors so > comment that code out for now. > > Bug: 1032721 > Change-Id: I2e7699477025b9eb291d51a713b34a843f1c1116 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159700 > Reviewed-by:
Collin Baker <collinbaker@chromium.org> Commit-Queue: Collin Baker <collinbaker@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#761658} Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src Cr-Mirrored-Commit: f2aa05346c32294a6fd523372e1eafa4a8e17a02
-
Adenilson Cavalcanti authored
There is a test suite in Canonical zlib that ensures correctness and coverage of inflate/deflate: the inflate cover (infcover.c) suite. This patch imports the inflate cover suite with the necessary changes to make it build and run under Chromes's C++11 GTEST test system. There are minimal changes (i.e. undefined 'local', miscellaneous C casts to use C++ casts, etc) so we can build it as C++ code and hook into GTEST e.g. use EXPECT_TRUE instead of C assert from <assert.h>. Adds a patch file for these changes, that can be applied on Canonical infcover should we need to sync with a new Canonical zlib release. TODO: there's one test accessing a symbol that causes link errors so comment that code out for now. Bug: 1032721 Change-Id: I2e7699477025b9eb291d51a713b34a843f1c1116 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159700 Reviewed-by:
-
K. Moon authored
Adds //build/config/compiler:no_chromium_code back to //third_party/zlib:zlib_inflate_chunk_simd. This was removed in crrev.com/c/2156228, but triggers a fatal warning in this target when compiled with MSVC, due to the K&R-style function declarations. PDFium and V8 still support MSVC. Bug: 1072308 Change-Id: I746862b1bd5205fd841bf77f227d0658bb38f0fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2161475 Commit-Queue: Adenilson Cavalcanti <cavalcantii@chromium.org> Commit-Queue: K Moon <kmoon@chromium.org> Reviewed-by:
-
Lei Zhang authored
Non-Chromium projects that pull in zlib may not be able to build the test. Also make "git cl format" happy. Change-Id: Ibc06828bfc495396d2b14d5f70feb0473be7427b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159956 Reviewed-by:
-
Noel Gordon authored
Add DEFLATE_FILL_WINDOW_SSE2 define for the fill_window_sse feature and use it to guard the feature code (not ADLER32_SIMD_SSSE3). The fill_window_sse feature only requires SSE2: use x86_cpu_enable_sse2 for the run-time check. No-presubmit: true Bug: 1072308 Change-Id: I770fffa619c998dae1c1f8da1cac8b973e43a509 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2156330 Commit-Queue: Noel Gordon <noel@chromium.org> Auto-Submit: Noel Gordon <noel@chromium.org> Reviewed-by:
-
- Apr 21, 2020
-
-
Noel Gordon authored
Add build config for zlib_x86_simd, and define CRC32_SIMD_SSE42_PCLMUL within it. Change crc32.c to use it to guard the crc_folding code, not the unrelated ADLER32_SIMD_SSSE3 guard. Bug: 1072308 Change-Id: I7146cf8b83086e5f706ae0c3ad4c13caa2ec0b01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2156233 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
-
- Apr 20, 2020
-
-
Noel Gordon authored
The zlib no-chromium-code rule leached into some build sub-rules where they are not actually needed: undo that. Rule configs and source_sets have separate sections dealing with Intel vs Arm: keep them separate (no if's with else's), white-space helps. Minor ordering changes: generally it's sources first, defines && deps, then configs. Use that order most everywhere. Special case: "warnings" do not quite fit. Leave them till last which matches their comments as a side-effect. Bug: 1072308 Change-Id: I2cbce82f165fad4d594b93a5169d6bc57585717e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2156228 Commit-Queue: Adenilson Cavalcanti <cavalcantii@chromium.org> Auto-Submit: Noel Gordon <noel@chromium.org> Reviewed-by:
-
- Apr 08, 2020
-
-
Adenilson Cavalcanti authored
One of the optimizations (i.e. chunk_copy) will perform vector stores on 16 bytes chunks instead of the original 3 bytes scalar operations. It is interesting to validate its safety while operating with small payloads (i.e. data input smaller than a single load/store). Even though it is a corner case (i.e. the payload would be smaller than the wrapper used for the DEFLATE stream for GZIP), it is good to certify that the optimization works as expected. This will also add gtest as a dependency as the plan is to write some tests to stress the optimizations we ship. Bug: 1032721 Change-Id: Ifc6a81879e3dba6a9c4b7cfde80e7207258b934c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128836 Commit-Queue: Adenilson Cavalcanti <cavalcantii@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#757639} Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src Cr-Mirrored-Commit: 272595ed5f469ee379e28dd5c40ef0230b6680a5
-
- Feb 14, 2020
-
-
Richard Townsend authored
MSVC's support for Arm intrinsics is incomplete. To restore the build and make sure MSVC-compiled downstream projects can compile V8 for Windows on Arm, temporarily disable these optimizations until we can fix them or MSVC improves. Bug: v8:10012 Change-Id: Iaa599aa20ace167e0fcc2a2472e97e7f2ac53773 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2054884 Commit-Queue: Adenilson Cavalcanti <cavalcantii@chromium.org> Reviewed-by:
-
- Jan 28, 2020
-
-
Nico Weber authored
`gn format` recently changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. Most changes have landed by now via `git cl split`. This is what remains after two weeks. Bug: 1041419 Change-Id: Ia813d744e57e5647266a91d4f6c725bf921fb11c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024471 Commit-Queue: Nico Weber <thakis@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#735958} Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src Cr-Mirrored-Commit: 852532f442a478b767bb452c63b5aa9b2e5e19fe
-
- Jan 24, 2020
-
-
Hans Wennborg authored
This reverts commit 0aa05cca9db25a9fa8d18f77bf6b2452bc608ead. Reason for revert: This broke arm64-builder-rel and some other builders, see bug. Original change's description: > Roll clang n333938-3a6da112-1 : n340158-efb130fc-2. > > Ran `tools/clang/scripts/upload_revision.py efb130fc93059bdf02d3a83950ddabc5d119f9de`. > > This increases the clang version from 10 to 11. > > It also disables the use of vector instructions in zlib to work around > new false positives in msan (see crbug.com/1045291). > > Bug: 1030664 > Change-Id: I5417d3063f0d67a61cdf31141b05a51a56e84482 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014904 > Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#735124} Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src Cr-Mirrored-Commit: ec2aab7d123590cfb332ba56d7faee2e1ff4a779
-
Nico Weber authored
Ran `tools/clang/scripts/upload_revision.py efb130fc93059bdf02d3a83950ddabc5d119f9de`. This increases the clang version from 10 to 11. It also disables the use of vector instructions in zlib to work around new false positives in msan (see crbug.com/1045291). Bug: 1030664 Change-Id: I5417d3063f0d67a61cdf31141b05a51a56e84482 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014904 Reviewed-by:
-
- Jan 08, 2020
-
-
Adenilson Cavalcanti authored
This will allow to remove some duplicated code (i.e. thread synchronization) while at same time removing unnecessary use of inline ASM for Intel features detection. A few other advantages: - remove some extra logic (e.g. no need to test the platform to include the correct CPU detection header). - simplifies the buildsystem (i.e. we always include cpu_features.c) - get rid of the simd_stub file. Bug: 1032721 Change-Id: I9427b34ec09dddc41925844a6ec4e6aa4d8f3207 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1987190 Reviewed-by:
Mike Klein <mtklein@chromium.org> Reviewed-by:
-
- Dec 21, 2019
-
-
Hans Wennborg authored
This reverts commit 6f7e5e79cefe982ad84a88927565a88db2e592be. Reason for revert: This broke the build, e.g. https://ci.chromium.org/p/chromium/builders/ci/ios-device/144512 ../../third_party/zlib/cpu_features.c:75:13: error: unused function '_cpu_check_features' [-Werror,-Wunused-function] static void _cpu_check_features(void) ^ Original change's description: > Unify CPU features detection code > > This will allow to remove some duplicated code (i.e. thread synchronization) > while at same time removing unnecessary use of inline ASM for Intel features > detection. > > A few other advantages: > - remove some extra logic (e.g. no need to test the platform to include the > correct CPU detection header). > - simplifies the buildsystem (i.e. we always include cpu_features.c) > - get rid of the simd_stub file. > > Bug: 1032721 > Change-Id: Ic93472d3337bc2cbe092d4cf8fbe4b31b1ceca6d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976820 > Reviewed-by:
-
Adenilson Cavalcanti authored
This will allow to remove some duplicated code (i.e. thread synchronization) while at same time removing unnecessary use of inline ASM for Intel features detection. A few other advantages: - remove some extra logic (e.g. no need to test the platform to include the correct CPU detection header). - simplifies the buildsystem (i.e. we always include cpu_features.c) - get rid of the simd_stub file. Bug: 1032721 Change-Id: Ic93472d3337bc2cbe092d4cf8fbe4b31b1ceca6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976820 Reviewed-by:
-
- Dec 12, 2019
-
-
Adenilson Cavalcanti authored
This change will unify the x86 and Arm optimized implementations for insert_string (used for compression). The objective here is two-fold: a) Remove duplicated code. b) Better insulate deflate.c divergence when compared to vanilla zlib. Bug: 1032721 Change-Id: Id2f65398aeb5a6384708493f0f6ae1fcd14022c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960893 Reviewed-by:
-
- Aug 27, 2019
-
-
Sam Maier authored
cpu_features GN target moved from android_sdk to android_ndk TBR: minor rename of target Bug: 990407 Change-Id: I82e25a24716d73e17f2e19dd5e83e94b636b8b0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1756203 Auto-Submit: Sam Maier <smaier@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Sam Maier <smaier@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#690799} Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src Cr-Mirrored-Commit: 801f0550ba72ea0021e97552ec9b98267b69f673
-
- Jun 24, 2019
-
-
Tomasz Śniatowski authored
Check use_thin_lto instead of thin_lto_enable_optimizations, as the latter is only defined in a BUILD.gn so can't be checked outside of it. Plus the intent of https://crrev.com/c/1642730 appears to have been to error out on LTO in general anyway. Fixes gn gen --args="is_clang=false target_cpu=\"arm\"" failing with: ERROR at //third_party/zlib/BUILD.gn:105:17: Undefined identifier assert(!thin_lto_enable_optimizations, ^---------------------------- Bug: 819294 Change-Id: Ibbcae447b01043edc8a118f4a3a3923f2d0ae261 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1667663 Auto-Submit: Tomasz Śniatowski <tsniatowski@vewd.com> Commit-Queue: Adenilson Cavalcanti <cavalcantii@chromium.org> Reviewed-by:
-
- Jun 10, 2019
-
-
Jose Dapena Paz authored
GCC compilation in ARM architectures with CRC32 extension was broken, as the extension was guarded for clang. For GCC we are enforcing armv8-a+crc architecture at module level, so the builtin extensions are available. Then we just include arm_acle.h to declare the required builtins. ThinLTO requires all modules to use same target, so this change makes GCC fail with ThinLTO (that was not supported anyway). Added a GN assert to explicitely fail in this case. Adapted from Vladislav Mukulov <vladislav.mukulov@lge.com> original patch. Bug: 819294 Change-Id: Ifa5cf64318f88220052c44126db90bef999b7113 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642730 Reviewed-by:
-
- Apr 18, 2019
-
-
Richard Townsend authored
This CL integrates feature detection across the file so that similar sections do similar things across all operating systems. Bug: 810125 Change-Id: I066226be69453ada72fa67632d09567ce246a860 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1569929 Reviewed-by:
-
