Skip to content
Snippets Groups Projects
Commit 4a04c9f7 authored by Jose Dapena Paz's avatar Jose Dapena Paz Committed by Copybara-Service
Browse files

[zlib] Fix GCC build of CRC32 extensions

Recent changes to include support for PMULL require arm_neon.h
header. This was added for Clang, but not for GCC.

Also, we need to add AES instruction set to the module level
statement.

Bug: 819294
Change-Id: I442d5a3d3e33aa78f08f9ee1d5a4035f16b25b46
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3917532


Commit-Queue: José Dapena Paz <jdapena@igalia.com>
Reviewed-by: default avatarAdenilson Cavalcanti <cavalcantii@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1051716}
NOKEYCHECK=True
GitOrigin-RevId: cdf142aad5b43835fb9947293ec3bcbe886fef18
parent 8f22e90f
No related branches found
No related tags found
No related merge requests found
......@@ -144,7 +144,7 @@ if (use_arm_neon_optimizations) {
if (!is_win && !is_clang) {
assert(!use_thin_lto,
"ThinLTO fails mixing different module-level targets")
cflags_c = [ "-march=armv8-a+crc" ]
cflags_c = [ "-march=armv8-a+aes+crc" ]
}
sources = [
......
......@@ -202,6 +202,7 @@ uint32_t ZLIB_INTERNAL crc32_sse42_simd_( /* SSE4.2+PCLMUL */
* allowed. We can just include arm_acle.h.
*/
#include <arm_acle.h>
#include <arm_neon.h>
#define TARGET_ARMV8_WITH_CRC
#else // !defined(__GNUC__) && !defined(_aarch64__)
#error ARM CRC32 SIMD extensions only supported for Clang and GCC
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment