- Oct 06, 2023
-
-
Scott Weaver authored
MR: https://gitlab.com/redhat/centos-stream/src/kernel/centos-stream-9/-/merge_requests/3074 JIRA: https://issues.redhat.com/browse/RHEL-3931 This MR is dedicated to the integration of changes into the CS9 kernel to provide PCIe support for the Qualcomm sa8775p SoC. The following commits contribute to this task: * 30638230 dt-bindings: phy: qcom,qmp-pcie: add sc8280xp bindings * 43a6a29b dt-bindings: phy: qcom,qmp-pcie: add sm8350 bindings * 496d068e dt-bindings: phy: Add QMP PCIe PHY comptible for SM8550 * 0d678713 dt-bindings: phy: qcom,qmp: Add SDX65 QMP PHY * 3cb11fe2 interconnect: qcom: sa8775p: add enable_mask for bcm nodes * e608d16e arm64: dts: qcom: sa8775p-ride: Update L4C parameters * fd2d4e4c dt-bindings: phy: qcom,qmp: Add sa8775p QMP PCIe PHY * a05b6d51 phy: qcom-qmp-pcie: add support for sa8775p * 489f14be arm64: dts: qcom: sa8775p: Add pcie0 and pcie1 nodes * bf3ee3db arm64: dts: qcom: sa8775p-ride: enable pcie nodes * 31cd8caf arm64: dts: qcom: sa8775p: add a node for the second serdes PHY * e952348a arm64: dts: qcom: sa8775p: add a node for EMAC1 * 6ca89cc6 arm64: dts: qcom: sa8775p-ride: enable the second SerDes PHY * 5255901f arm64: dts: qcom: sa8775p-ride: move the reset-gpios property of the PHY * 1e7ef41b arm64: dts: qcom: sa8775p-ride: index the first SGMII PHY * 1a00a068 arm64: dts: qcom: sa8775p-ride: add the second SGMII PHY * f8be0c50 arm64: dts: qcom: sa8775p-ride: sort aliases alphabetically * fdc051e3 arm64: dts: qcom: sa8775p-ride: add an alias for ethernet0 * 27eb552e arm64: dts: qcom: sa8775p-ride: enable EMAC1 * a74883a0 arm64: dts: qcom: sa8775p: Hook up PDC as wakeup-parent of TLMM * cfe0d203 phy: qcom-qmp-pcie: drop ln_shrd from v5_20 config * 86f70376 phy: qcom-qmp-pcie: keep offset tables sorted * 9169e039 dt-bindings: PCI: qcom: Add sa8775p compatible * d60379d6 PCI: qcom: Add support for sa8775p SoC * 2dba7a61 arm64: dts: qcom: sa8775p: add the pcie smmu node * 955d095a power: reset: qcom-pon: add support for qcom,pmk8350-pon compatible string * d8630f05 interconnect: qcom: Add support for mask-based BCMs * a1f4170d interconnect: qcom: bcm-voter: Improve enable_mask handling * 1a70ca71 interconnect: qcom: bcm-voter: Use enable_maks for keepalive voting Signed-off-by:
Alessandro Carminati <acarmina@redhat.com> Approved-by:
John W. Linville <linville@redhat.com> Approved-by:
Andrew Halaney <ahalaney@redhat.com> Approved-by:
Adrien Thierry <athierry@redhat.com> Signed-off-by:
Scott Weaver <scweaver@redhat.com>
-
- Oct 04, 2023
-
-
Scott Weaver authored
Signed-off-by:
Scott Weaver <scweaver@redhat.com>
-
Scott Weaver authored
-
Scott Weaver authored
MR: https://gitlab.com/redhat/centos-stream/src/kernel/centos-stream-9/-/merge_requests/3103 JIRA: INTERNAL Be more picky about kernel's source code licenses: - Keep track of all currently used license in specfile template. - Add a selftest which checks all currently present license identifiers against License:. Signed-off-by:
Vitaly Kuznetsov <vkuznets@redhat.com> Approved-by:
Michael Hofmann <mhofmann@redhat.com> Approved-by:
Sabrina Dubroca <sdubroca@redhat.com> Approved-by:
Jarod Wilson <jarod@redhat.com> Signed-off-by:
Scott Weaver <scweaver@redhat.com>
-
Scott Weaver authored
MR: https://gitlab.com/redhat/centos-stream/src/kernel/centos-stream-9/-/merge_requests/3159 JIRA: https://issues.redhat.com/browse/RHEL-11351 Tested: Verified via PT/idle. See Jira comment for details Signed-off-by:
David Arcari <darcari@redhat.com> Approved-by:
Dean Nelson <dnelson@redhat.com> Approved-by:
Steve Best <sbest@redhat.com> Signed-off-by:
Scott Weaver <scweaver@redhat.com>
-
Scott Weaver authored
MR: https://gitlab.com/redhat/centos-stream/src/kernel/centos-stream-9/-/merge_requests/3088 ``` This series updates RHEL9's PCI subsystem with content from upstream v6.5 - Merge tag 'pci-v6.5-fixes-1' of git://git.kernel.org/pub/../kernel/git/pci/pci https://lkml.org/lkml/2023/8/11/826 commit 9106536c Merge: 2a3c17ed cc22522f 6 files changed, 19 insertions(+), 25 deletions(-) Merge tag 'pci-v6.5-changes' of git://git.kernel.org/pub/../kernel/git/pci/pci https://lkml.org/lkml/2023/6/29/666 commit 9070577a Merge: 28968f38 6ecac465 70 files changed, 1631 insertions(+), 848 deletions(-) JIRA: https://issues.redhat.com/browse/RHEL-2570 Depends: N/A Signed-off-by:
Myron Stowe <mstowe@redhat.com> ``` Approved-by:
John W. Linville <linville@redhat.com> Approved-by:
Prarit Bhargava <prarit@redhat.com> Approved-by:
Adrien Thierry <athierry@redhat.com> Signed-off-by:
Scott Weaver <scweaver@redhat.com>
-
Scott Weaver authored
MR: https://gitlab.com/redhat/centos-stream/src/kernel/centos-stream-9/-/merge_requests/3147 JIRA: https://issues.redhat.com/browse/RHEL-10047 Tested: Passed PT/amd-pstate testing as per Jira ticket Signed-off-by:
David Arcari <darcari@redhat.com> Approved-by:
Mark Langsdorf <mlangsdo@redhat.com> Approved-by:
Dean Nelson <dnelson@redhat.com> Approved-by:
Lenny Szubowicz <lszubowi@redhat.com> Signed-off-by:
Scott Weaver <scweaver@redhat.com>
-
Scott Weaver authored
MR: https://gitlab.com/redhat/centos-stream/src/kernel/centos-stream-9/-/merge_requests/3050 JIRA: https://issues.redhat.com/browse/RHEL-3400 Upstream Status: RHEL-only Tested to resolve reported issue and further verified by QE. Signed-off-by:
Alex Williamson <alex.williamson@redhat.com> Approved-by:
Eric Auger <eric.auger@redhat.com> Approved-by:
Cédric Le Goater <clg@redhat.com> Signed-off-by:
Scott Weaver <scweaver@redhat.com>
-
Scott Weaver authored
MR: https://gitlab.com/redhat/centos-stream/src/kernel/centos-stream-9/-/merge_requests/3106 # Merge Request Required Information ## Summary of Changes Add changes to lower drift in C0 percentage calculation when doing TSC reading. Read TSC per CPU and also just after mperf reading to improve C0 percentage calculation in Mperf monitor. Tested: See Jira issue for testing details Signed-off-by:
Joel Slebodnick <jslebodn@redhat.com> ## Approved Development Ticket JIRA: https://issues.redhat.com/browse/RHEL-10052 Approved-by:
Lenny Szubowicz <lszubowi@redhat.com> Approved-by:
David Arcari <darcari@redhat.com> Approved-by:
Prarit Bhargava <prarit@redhat.com> Signed-off-by:
Scott Weaver <scweaver@redhat.com>
-
Scott Weaver authored
MR: https://gitlab.com/redhat/centos-stream/src/kernel/centos-stream-9/-/merge_requests/3164 Bring in changes from 9.3 tag kernel-5.14.0-362.8.1.el9_3 Conflicts: Makefile.rhelver changes dropped Signed-off-by:
Jan Stancek <jstancek@redhat.com> Signed-off-by:
Scott Weaver <scweaver@redhat.com>
-
Jiri Benc authored
owners: add myself as reviewer of "MEMORY MANAGEMENT" subsystem See merge request redhat/centos-stream/src/kernel/documentation!605
-
- Oct 03, 2023
-
-
Jan Stancek authored
Bring in changes from 9.3 tag kernel-5.14.0-362.8.1.el9_3 Conflicts: Makefile.rhelver changes dropped Signed-off-by:
Jan Stancek <jstancek@redhat.com>
-
Scott Weaver authored
Signed-off-by:
Scott Weaver <scweaver@redhat.com>
-
Scott Weaver authored
-
Scott Weaver authored
MR: https://gitlab.com/redhat/centos-stream/src/kernel/centos-stream-9/-/merge_requests/3044 # Merge Request Required Information ## Summary of Changes Backport mtrr and path from upstream up to dc43fc75. This is a prerequisite for host TDX support. Omitted-fix: 90b926e6 The patch was reverted with commit 925cf045. ## Approved Development Ticket JIRA: https://issues.redhat.com/browse/RHEL-2889 Signed-off-by:
Camilla Conte <cconte@redhat.com> Approved-by:
Paolo Bonzini <bonzini@gnu.org> Approved-by:
David Arcari <darcari@redhat.com> Approved-by:
Vitaly Kuznetsov <vkuznets@redhat.com> Approved-by:
Donald Dutile <ddutile@redhat.com> Signed-off-by:
Scott Weaver <scweaver@redhat.com>
-
Scott Weaver authored
MR: https://gitlab.com/redhat/centos-stream/src/kernel/centos-stream-9/-/merge_requests/3042 JIRA: https://issues.redhat.com/browse/RHEL-2799 Update drivers/net/phy to 6.5 **_Important_: https://gitlab.com/redhat/centos-stream/src/kernel/centos-stream-9/-/merge_requests/3081 must also be applied for this MR to build properly on main-automotive** **Skipped commits (tree-wide)** ``` 2a81ada3 driver core: make struct bus_type.uevent() take a const * 8032bf12 treewide: use get_random_u32_below() instead of deprecated function e1f4ecab net: remove explicit phylink_generic_validate() references 81895a65 treewide: use prandom_u32_max() when possible, part 1 a0386bba spi: make remove callback a void function 4973056c net: convert users of bitmap_foo() to linkmode_foo() 76660757 ethernet: constify references to netdev->dev_addr in drivers ``` **Skipped because reverted by `bf294c3f Revert "Merge branch 'wwan-t7xx-fw-flashing-and-coredump-support'"`** ``` 0630f64d net: phy: broadcom: Implement suspend/resume for AC131 and BCM5241 ``` Signed-off-by:
Adrien Thierry <athierry@redhat.com> Approved-by:
Brian Masney <bmasney@redhat.com> Approved-by:
Eric Chanudet <echanude@redhat.com> Approved-by:
Antoine Tenart <atenart@redhat.com> Signed-off-by:
Scott Weaver <scweaver@redhat.com>
-
Jan Stancek authored
Signed-off-by:
Jan Stancek <jstancek@redhat.com>
-
Jan Stancek authored
Merge: Revert "dma-mapping: reject __GFP_COMP in dma_alloc_attrs" and "cnic: don't pass bogus GFP_ flags to dma_alloc_coherent" MR: https://gitlab.com/redhat/rhel/src/kernel/rhel-9/-/merge_requests/929 JIRA: https://issues.redhat.com/browse/RHEL-2542 Upstream Status: RHEL Only This reverts commit a2cfbf05. This reverts commit f7eaf7fc. bnx2i/cnic currently fails to properly mmap its dma_alloc_coherent buffers through a uio interface without being able to allocate compound pages. Revert this until we can get a better cnic fix. Signed-off-by:
Chris Leech <cleech@redhat.com> Approved-by:
Jerry Snitselaar <jsnitsel@redhat.com> Approved-by:
Ewan D. Milne <emilne@redhat.com> Approved-by:
Donald Dutile <ddutile@redhat.com> Signed-off-by:
Jan Stancek <jstancek@redhat.com>
-
David Arcari authored
JIRA: https://issues.redhat.com/browse/RHEL-11351 commit 6d9c7f51 Author: Peter Zijlstra <peterz@infradead.org> Date: Thu Jan 12 20:43:32 2023 +0100 cpuidle, intel_idle: Fix CPUIDLE_FLAG_IRQ_ENABLE *again* So objtool found this bug: vmlinux.o: warning: objtool: intel_idle_irq+0x10c: call to trace_hardirqs_off() leaves .noinstr.text section As per commit 32d4fd57 ("cpuidle,intel_idle: Fix CPUIDLE_FLAG_IRQ_ENABLE"): "must not have tracing in idle functions" Clearly people can't read and tinker along until splat dissapears. This straight up reverts commit d295ad34 ("intel_idle: Fix false positive RCU splats due to incorrect hardirqs state"). It doesn't re-introduce the problem because preceding patches fixed it properly. Fixes: d295ad34 ("intel_idle: Fix false positive RCU splats due to incorrect hardirqs state") Signed-off-by:
Peter Zijlstra (Intel) <peterz@infradead.org> Signed-off-by:
Ingo Molnar <mingo@kernel.org> Tested-by:
Tony Lindgren <tony@atomide.com> Tested-by:
Ulf Hansson <ulf.hansson@linaro.org> Acked-by:
Rafael J. Wysocki <rafael.j.wysocki@intel.com> Acked-by:
Frederic Weisbecker <frederic@kernel.org> Link: https://lore.kernel.org/r/20230112195540.434302128@infradead.org Signed-off-by:
David Arcari <darcari@redhat.com>
-
David Arcari authored
JIRA: https://issues.redhat.com/browse/RHEL-11351 commit 5534f446 Author: Rafael J. Wysocki <rafael.j.wysocki@intel.com> Date: Wed Jul 19 20:10:03 2023 +0200 Revert "intel_idle: Add support for using intel_idle in a VM guest using just hlt" This reverts commit 2f3d08f0 ("intel_idle: Add support for using intel_idle in a VM guest using just hlt"), because it causes functional issues to appear and it is not really useful without a related commit that got reverted previously. Link: https://lore.kernel.org/linux-pm/5c7de6d5-7706-c4a5-7c41-146db1269aff@intel.com Reported-by:
Xiaoyao Li <xiaoyao.li@intel.com> Requested-by:
Peter Zijlstra <peterz@infradead.org> Signed-off-by:
Rafael J. Wysocki <rafael.j.wysocki@intel.com> Signed-off-by:
David Arcari <darcari@redhat.com>
-
David Arcari authored
JIRA: https://issues.redhat.com/browse/RHEL-11351 commit a5155c02 Author: Rafael J. Wysocki <rafael.j.wysocki@intel.com> Date: Wed Jul 19 19:57:39 2023 +0200 Revert "intel_idle: Add a "Long HLT" C1 state for the VM guest mode" This reverts commit 0fac214b ("intel_idle: Add a "Long HLT" C1 state for the VM guest mode"), because there is a coding mistake in it and its validity is questioned. Link: https://lore.kernel.org/all/20230711132553.GN3062772@hirez.programming.kicks-ass.net Requested-by:
Peter Zijlstra <peterz@infradead.org> Signed-off-by:
Rafael J. Wysocki <rafael.j.wysocki@intel.com> Signed-off-by:
David Arcari <darcari@redhat.com>
-
David Arcari authored
JIRA: https://issues.redhat.com/browse/RHEL-11351 commit d46b0a05 Author: Rafael J. Wysocki <rafael.j.wysocki@intel.com> Date: Wed Jul 19 19:56:08 2023 +0200 Revert "intel_idle: Add __init annotation to matchup_vm_state_with_baremetal()" This reverts commit b2918089 ("intel_idle: Add __init annotation to matchup_vm_state_with_baremetal()"), because the commit fixed by it will be reverted. Signed-off-by:
Rafael J. Wysocki <rafael.j.wysocki@intel.com> Signed-off-by:
David Arcari <darcari@redhat.com>
-
David Arcari authored
JIRA: https://issues.redhat.com/browse/RHEL-11351 commit b2918089 Author: Rafael J. Wysocki <rafael.j.wysocki@intel.com> Date: Tue Jun 27 19:50:48 2023 +0200 intel_idle: Add __init annotation to matchup_vm_state_with_baremetal() The caller of (recently added) matchup_vm_state_with_baremetal() is an __init function and it uses some __initdata data structures, so add the __init annotation to it for consistency. This addresses the following build warnings: WARNING: modpost: vmlinux: section mismatch in reference: matchup_vm_state_with_baremetal+0x51 (section: .text) -> intel_idle_max_cstate_reached (section: .init.text) WARNING: modpost: vmlinux: section mismatch in reference: matchup_vm_state_with_baremetal+0x62 (section: .text) -> cpuidle_state_table (section: .init.data) WARNING: modpost: vmlinux: section mismatch in reference: matchup_vm_state_with_baremetal+0x79 (section: .text) -> icpu (section: .init.data) Fixes: 0fac214b ("intel_idle: Add a "Long HLT" C1 state for the VM guest mode") Reported-by:
Randy Dunlap <rdunlap@infradead.org> Signed-off-by:
Rafael J. Wysocki <rafael.j.wysocki@intel.com> Tested-by: Randy Dunlap <rdunlap@infradead.org> # build-tested Reviewed-by:
Randy Dunlap <rdunlap@infradead.org> Signed-off-by:
David Arcari <darcari@redhat.com>
-
David Arcari authored
JIRA: https://issues.redhat.com/browse/RHEL-11351 commit 0fac214b Author: Arjan van de Ven <arjan@linux.intel.com> Date: Tue Jun 20 18:03:54 2023 +0000 intel_idle: Add a "Long HLT" C1 state for the VM guest mode intel_idle will, for the bare metal case, usually have one or more deep power states that have the CPUIDLE_FLAG_TLB_FLUSHED flag set. When a state with this flag is selected by the cpuidle framework, it will also flush the TLBs as part of entering this state. The benefit of doing this is that the kernel does not need to wake the cpu out of this deep power state just to flush the TLBs... for which the latency can be very high due to the exit latency of deep power states. In a VM guest currently, this benefit of avoiding the wakeup does not exist, while the problem (long exit latency) is even more severe. Linux will need to wake up a vCPU (causing the host to either come out of a deep C state, or the VMM to have to deschedule something else to schedule the vCPU) which can take a very long time.. adding a lot of latency to tlb flush operations (including munmap and others). To solve this, add a "Long HLT" C state to the state table for the VM guest case that has the CPUIDLE_FLAG_TLB_FLUSHED flag set. The result of that is that for long idle periods (where the VMM is likely to do things that cause large latency) the cpuidle framework will flush the TLBs (and avoid the wakeups), while for short/quick idle durations, the existing behavior is retained. Now, there is still only "hlt" available in the guest, but for long idle, the host can go to a deeper state (say C6). There is a reasonable debate one can have to what to set for the exit_latency and break even point for this "Long HLT" state. The good news is that intel_idle has these values available for the underlying CPU (even when mwait is not exposed). The solution thus is to just use the latency and break even of the deepest state from the bare metal CPU. This is under the assumption that this is a pretty reasonable estimate of what the VMM would do to cause latency. Signed-off-by:
Arjan van de Ven <arjan@linux.intel.com> Signed-off-by:
Rafael J. Wysocki <rafael.j.wysocki@intel.com> Signed-off-by:
David Arcari <darcari@redhat.com>
-
David Arcari authored
JIRA: https://issues.redhat.com/browse/RHEL-11351 commit 2f3d08f0 Author: Arjan van de Ven <arjan@linux.intel.com> Date: Mon Jun 5 15:47:15 2023 +0000 intel_idle: Add support for using intel_idle in a VM guest using just hlt In a typical VM guest, the mwait instruction is not available, leaving only the 'hlt' instruction (which causes a VMEXIT to the host). So for this common case, intel_idle will detect the lack of mwait, and fail to initialize (after which another idle method would step in which will just use hlt always). Other (non-common) cases exist; the table below shows the before/after for these: +------------+--------------------------+-------------------------+ | Hypervisor | Idle method before patch | Idle method after patch | | exposes | | | +============+==========================+=========================+ | nothing | default_idle fallback | intel_idle VM table | | (common) | (straight "hlt") | | +------------+--------------------------+-------------------------+ | mwait | intel_idle mwait table | intel_idle mwait table | +------------+--------------------------+-------------------------+ | ACPI | ACPI C1 state ("hlt") | intel_idle VM table | +------------+--------------------------+-------------------------+ This is only applicable to CPUs known by intel_idle. For the bare metal case, unknown CPU models will use the ACPI tables (when available) to get estimates for latency and break even point for longer idle states. In guests, the common case is that ACPI tables are not available, but even when they are available, they can't and don't provide the latency information for the longer (mwait based) states. For this scenario (unknown CPU model), the default_idle mode (no ACPI) or ACPI C1 (ACPI avaible) will be used. By providing capability to do this with the intel_idle driver, we can do better than the fallback or ACPI table methods. While this current change only gets us to the existing behavior, later patches in this series will add new capabilities such as optimized TLB flushing. In order to do this, a simplified version of the initialization function for VM guests is created, and this will be called if the CPU is recognized, but mwait is not supported, and we're in a VM guest. One thing to note is that the max latency (and break even) of this C1 state is higher than the typical bare metal C1 state. Because hlt causes a vmexit, and the cost of vmexit + hypervisor overhead + vmenter is typically in the order of upto 5 microseconds... even if the hypervisor does not actually goes into a hardware power saving state. Signed-off-by:
Arjan van de Ven <arjan@linux.intel.com> [ rjw: Dropped redundant checks from should_verify_mwait() ] Signed-off-by:
Rafael J. Wysocki <rafael.j.wysocki@intel.com> Signed-off-by:
David Arcari <darcari@redhat.com>
-
David Arcari authored
JIRA: https://issues.redhat.com/browse/RHEL-11351 commit 7826c069 Author: Arjan van de Ven <arjan@linux.intel.com> Date: Mon Jun 5 15:47:14 2023 +0000 intel_idle: clean up the (new) state_update_enter_method function Now that the logic for state_update_enter_method() is in its own function, the long if .. else if .. else if .. else if chain can be simplified by just returning from the function at the various places. This does not change functionality, but it makes the logic much simpler to read or modify later. Signed-off-by:
Arjan van de Ven <arjan@linux.intel.com> Signed-off-by:
Rafael J. Wysocki <rafael.j.wysocki@intel.com> Signed-off-by:
David Arcari <darcari@redhat.com>
-
David Arcari authored
JIRA: https://issues.redhat.com/browse/RHEL-11351 commit 4622ba92 Author: Arjan van de Ven <arjan@linux.intel.com> Date: Mon Jun 5 15:47:13 2023 +0000 intel_idle: refactor state->enter manipulation into its own function Since the 6.4 kernel, the logic for updating a state's enter method based on "environmental conditions" (command line options, cpu sidechannel workarounds etc etc) has gotten pretty complex. This patch refactors this into a seperate small, self contained function (no behavior changes) for improved readability and to make future changes to this logic easier to do and understand. Signed-off-by:
Arjan van de Ven <arjan@linux.intel.com> Signed-off-by:
Rafael J. Wysocki <rafael.j.wysocki@intel.com> Signed-off-by:
David Arcari <darcari@redhat.com>
-
David Arcari authored
JIRA: https://issues.redhat.com/browse/RHEL-11351 commit bd446829 Author: Artem Bityutskiy <artem.bityutskiy@linux.intel.com> Date: Wed Apr 19 17:39:47 2023 +0300 intel_idle: mark few variables as __read_mostly The intention is to clean up the code and make it look a bit more consistent. Mark all unitialized module parameter variables as __read_mostly, not just one of them. The other parameters are read-mostly too. Signed-off-by:
Artem Bityutskiy <artem.bityutskiy@linux.intel.com> Signed-off-by:
Rafael J. Wysocki <rafael.j.wysocki@intel.com> Signed-off-by:
David Arcari <darcari@redhat.com>
-
David Arcari authored
JIRA: https://issues.redhat.com/browse/RHEL-11351 commit 4152379a Author: Artem Bityutskiy <artem.bityutskiy@linux.intel.com> Date: Thu Apr 20 09:47:21 2023 +0300 intel_idle: do not sprinkle module parameter definitions around This is a cleanup which improves code consistency. Move the force_irq_on module parameter variable and definition to the same place where we have variables and definitions for other module parameters. Signed-off-by:
Artem Bityutskiy <artem.bityutskiy@linux.intel.com> Reviewed-by:
Zhang Rui <rui.zhang@intel.com> Signed-off-by:
Rafael J. Wysocki <rafael.j.wysocki@intel.com> Signed-off-by:
David Arcari <darcari@redhat.com>
-
David Arcari authored
JIRA: https://issues.redhat.com/browse/RHEL-11351 commit db1ae0c9 Author: Artem Bityutskiy <artem.bityutskiy@linux.intel.com> Date: Wed Apr 19 17:39:45 2023 +0300 intel_idle: fix confusing message By default, all non-POLL C-states are entered with interrupts disabled. There are 2 ways to make 'intel_idle' enter C-states with interrupts enabled: 1. Mark the C-state with the CPUIDLE_FLAG_IRQ_ENABLE flag. 2. Use the force_irq_on module parameter. The former is the "proper" way of doing it, it is per-C-state and per-platform. The latter is for debugging purposes only. The problem is that intel_idle prints the "forced intel_idle_irq" message in both cases, even though the former case does not needed this message, because nothing is forced there. This patch addresses the problem. Signed-off-by:
Artem Bityutskiy <artem.bityutskiy@linux.intel.com> Reviewed-by:
Zhang Rui <rui.zhang@intel.com> Signed-off-by:
Rafael J. Wysocki <rafael.j.wysocki@intel.com> Signed-off-by:
David Arcari <darcari@redhat.com>
-
David Arcari authored
JIRA: https://issues.redhat.com/browse/RHEL-11351 commit 00433eae Author: Artem Bityutskiy <artem.bityutskiy@linux.intel.com> Date: Wed Apr 19 17:39:44 2023 +0300 intel_idle: improve C-state flags handling robustness The following C-state flags are currently mutually-exclusive and should not be combined: * IRQ_ENABLE * IBRS * XSTATE There is a warning for the situation when the IRQ_ENABLE flag is combined with the IBRS flag, but no warnings for other combinations. This is inconsistent and prone to errors. Improve the situation by adding warnings for all the unexpected combinations. Add a couple of helpful commentaries too. Signed-off-by:
Artem Bityutskiy <artem.bityutskiy@linux.intel.com> Reviewed-by:
Zhang Rui <rui.zhang@intel.com> Signed-off-by:
Rafael J. Wysocki <rafael.j.wysocki@intel.com> Signed-off-by:
David Arcari <darcari@redhat.com>
-
David Arcari authored
JIRA: https://issues.redhat.com/browse/RHEL-11351 commit 1abffbd8 Author: Artem Bityutskiy <artem.bityutskiy@linux.intel.com> Date: Wed Apr 19 17:39:43 2023 +0300 intel_idle: further intel_idle_init_cstates_icpu() cleanup Introduce a temporary 'state' variable for referencing the currently processed C-state in the intel_idle_init_cstates_icpu() function. This makes code lines shorter and easier to read. Signed-off-by:
Artem Bityutskiy <artem.bityutskiy@linux.intel.com> Reviewed-by:
Zhang Rui <rui.zhang@intel.com> Signed-off-by:
Rafael J. Wysocki <rafael.j.wysocki@intel.com> Signed-off-by:
David Arcari <darcari@redhat.com>
-
David Arcari authored
JIRA: https://issues.redhat.com/browse/RHEL-11351 commit a78032e9 Author: Artem Bityutskiy <artem.bityutskiy@linux.intel.com> Date: Thu Apr 20 09:47:18 2023 +0300 intel_idle: clean up intel_idle_init_cstates_icpu() The intel_idle_init_cstates_icpu() function includes a loop that iterates over every C-state. Inside the loop, the same C-state data is referenced 2 ways: 1. as cpuidle_state_table[cstate] 2. as drv->states[drv->state_count] (but it is a copy of #1, not the same object). Make the code be more consistent and easier to read by using only the 2nd way. So the code structure would be as follows: 1. Use cpuidle_state_table[cstate] 2. Copy cpuidle_state_table[cstate] to drv->states[drv->state_count] 3. Use only drv->states[drv->state_count] from this point. Note, this change introduces a checkpatch.pl warning (too long line), but it will be addressed in the next patch. Signed-off-by:
Artem Bityutskiy <artem.bityutskiy@linux.intel.com> Reviewed-by:
Zhang Rui <rui.zhang@intel.com> Signed-off-by:
Rafael J. Wysocki <rafael.j.wysocki@intel.com> Signed-off-by:
David Arcari <darcari@redhat.com>
-
David Arcari authored
JIRA: https://issues.redhat.com/browse/RHEL-11351 commit 91048ce4 Author: Artem Bityutskiy <artem.bityutskiy@linux.intel.com> Date: Wed Apr 19 17:39:41 2023 +0300 intel_idle: use pr_info() instead of printk() Substitute 'printk()' with 'pr_info()', because 'intel_idle' already uses 'pr_debug()', so using 'pr_info()' will be more consistent. In addition to this, this patch addresses the following checkpatch.pl warning: WARNING: printk() should include KERN_<LEVEL> facility level Signed-off-by:
Artem Bityutskiy <artem.bityutskiy@linux.intel.com> Reviewed-by:
Zhang Rui <rui.zhang@intel.com> Signed-off-by:
Rafael J. Wysocki <rafael.j.wysocki@intel.com> Signed-off-by:
David Arcari <darcari@redhat.com>
-
Jan Stancek authored
Signed-off-by:
Jan Stancek <jstancek@redhat.com>
-
Jan Stancek authored
Merge: PHX: Random system hang during suspend/resume due to race condition with GFXOFF, interrupts and RLC MR: https://gitlab.com/redhat/rhel/src/kernel/rhel-9/-/merge_requests/930 Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=2232662 Signed-off-by:
Mika Penttilä <mpenttil@redhat.com> Approved-by:
Michel Dänzer <mdaenzer@redhat.com> Approved-by:
Jocelyn Falempe <jfalempe@redhat.com> Signed-off-by:
Jan Stancek <jstancek@redhat.com>
-
Jan Stancek authored
MR: https://gitlab.com/redhat/rhel/src/kernel/rhel-9/-/merge_requests/861 Upstream-status: Rhel-only JIRA: https://issues.redhat.com/browse/RHEL-1267 This reverts commit 7b1ca29c. That commit is known to cause performance regression, it caused a significant increase in CPU utilization for a udp/ipv6 test case. Signed-off-by:
Mohammad Kabat <mkabat@redhat.com> 3777c981e3a5 (Mohammad Kabat) Revert "net/mlx5e: Switch to using napi_build_skb()" drivers/net/ethernet/mellanox/mlx5/core/en_rx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Approved-by:
Marcelo Ricardo Leitner <mleitner@redhat.com> Approved-by:
Kamal Heib <kheib@redhat.com> Signed-off-by:
Jan Stancek <jstancek@redhat.com>
-
- Oct 02, 2023
-
-
Jiri Benc authored
Add kernel/Kconfig.locks to the LOCKING PRIMITIVES path list See merge request redhat/centos-stream/src/kernel/documentation!604
-
Scott Weaver authored
Signed-off-by:
Scott Weaver <scweaver@redhat.com>
-
David Hildenbrand authored
Let's add myself as reviewer, so I can ACK merge requests from the MM perspective. Signed-off-by:
David Hildenbrand <david@redhat.com>
-