Skip to content
Snippets Groups Projects
Commit 6e2cfb75 authored by David Arcari's avatar David Arcari
Browse files

cpuidle, intel_idle: Fix CPUIDLE_FLAG_IRQ_ENABLE *again*

JIRA: https://issues.redhat.com/browse/RHEL-11351



commit 6d9c7f51
Author: Peter Zijlstra <peterz@infradead.org>
Date:   Thu Jan 12 20:43:32 2023 +0100

    cpuidle, intel_idle: Fix CPUIDLE_FLAG_IRQ_ENABLE *again*

    So objtool found this bug:

      vmlinux.o: warning: objtool: intel_idle_irq+0x10c: call to trace_hardirqs_off() leaves .noinstr.text section

    As per commit 32d4fd57 ("cpuidle,intel_idle: Fix CPUIDLE_FLAG_IRQ_ENABLE"):

      "must not have tracing in idle functions"

    Clearly people can't read and tinker along until splat dissapears.
    This straight up reverts commit d295ad34 ("intel_idle: Fix false
    positive RCU splats due to incorrect hardirqs state").

    It doesn't re-introduce the problem because preceding patches fixed it
    properly.

    Fixes: d295ad34 ("intel_idle: Fix false positive RCU splats due to incorrect hardirqs state")
Signed-off-by: default avatarPeter Zijlstra (Intel) <peterz@infradead.org>
Signed-off-by: default avatarIngo Molnar <mingo@kernel.org>
Tested-by: default avatarTony Lindgren <tony@atomide.com>
Tested-by: default avatarUlf Hansson <ulf.hansson@linaro.org>
Acked-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
Acked-by: default avatarFrederic Weisbecker <frederic@kernel.org>
    Link: https://lore.kernel.org/r/20230112195540.434302128@infradead.org



Signed-off-by: default avatarDavid Arcari <darcari@redhat.com>
parent 1c903960
No related branches found
No related tags found
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment