Christopher Obbard authored 1 month ago and Caleb Connolly committed 1 week ago

There is a race condition between UFS and ICE that causes the board
to not boot all the time in fedora. Disable the ice node (for now).

Signed-off-by: Christopher Obbard <christopher.obbard@linaro.org>

Ilias Apalodimas authored 1 month ago and Caleb Connolly committed 1 week ago

Workaround dma-dma kernel bug [0] by disabling dts nodes.

[0]: https://web.git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?h=next-20250307&id=e521f516716de7895acd1b5b7fac788214a390b9



Signed-off-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>
Signed-off-by: Christopher Obbard <christopher.obbard@linaro.org>

Christopher Obbard authored 1 month ago and Caleb Connolly committed 1 week ago

For the micro usb port to work correctly as a host port, it needs
to provide 5V. Since we cannot use a hub, force the 5V regulator
to provide VBUS during boot.

Signed-off-by: Christopher Obbard <christopher.obbard@linaro.org>

Christopher Obbard authored 1 month ago and Caleb Connolly committed 1 week ago

Force the micro USB port to run in host mode. Currently it will only
work with a powered USB hub since the vbus regulator is not yet
hooked up.

Signed-off-by: Christopher Obbard <christopher.obbard@linaro.org>

Christopher Obbard authored 1 month ago and Caleb Connolly committed 1 week ago

With a USB type C hub connected, the USB init sequence during boot
doesn't seem to enumerate the devices. Call `usb reset` during boot
to re-enumerate the USB devices.

Signed-off-by: Christopher Obbard <christopher.obbard@linaro.org>

Load firmware for the peripheral if necessary.

Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
Signed-off-by: Caleb Connolly <caleb.connolly@linaro.org>

Qualcomm peripherals like UART, SPI, I2C, etc are all exposed under a
common GENI Serial Engine wrapper device. Replace the stub driver we use
for this currently with a full-on misc device and implement support for
loading peripheral firmware.

Each of the peripherals has it's own protocol-specific firmware, this is
stored on the internal storage of the device with a well-known partition
type GUID.

To support this, GENI will bind peripherals in two stages. First the
ones that already have firmware loaded (such as the serial port) are
bound in the typical way. But devices that require firmware loading are
deferred until EVT_LAST_STAGE_INIT. At this point we can be sure that
the storage device is available, so we load the firmware and then bind
and probe the remaining children.

Child devices are expected to determine if firmware loading is necessary
and call qcom_geni_load_firmware().

Since Linux currently doesn't support loading firmware (and firmware may
not be available), we probe all GENI peripherals to ensure that they
always load firmwaree if necessary.

Signed-off-by: Caleb Connolly <caleb.connolly@linaro.org>

Correct the error messages so they accurately describe that we failed to
disable the clocks, not to enable them.

Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
Signed-off-by: Caleb Connolly <caleb.connolly@linaro.org>

These are all usually enabled, hence we don't (yet) bother configuring
their RCG src clocks.

Add them to remove the errors about missing clocks when the UFS and MMC
drivers probe.

Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
Link: https://lore.kernel.org/r/20250317-sc7280-mmc-ufs-clocks-v1-2-38e05c16511b@linaro.org


Signed-off-by: Caleb Connolly <caleb.connolly@linaro.org>

We can now correctly identify which partition U-Boot is flashed to
between uefi, xbl, and boot (including A/B support) so enable capsule
update support for all boards.

Signed-off-by: Caleb Connolly <caleb.connolly@linaro.org>

Calling scsi_scan() results in all the block devices (and EFI block
devices) being destroyed and re-created. This breaks the EFI filesystem
drivers during capsule update.

Remove the call, since boards really should be calling scsi_scan()
themselves during board_init().

Signed-off-by: Caleb Connolly <caleb.connolly@linaro.org>

Expand capsule update support to correctly identify which partition
U-Boot is flashed to (between xbl, uefi, and boot including A/B
variants).

Use qcom_boot_source to determine if we were chainloaded from ABL,
meaning U-Boot is on the boot partition, otherwise we assume uefi if
it's available, finally leaving the xbl partition.

Set a different fw_name based on the target partition to prevent GUID
collisions, since a board may support U-Boot flashed to boot or XBL we
need to differentiate them since the U-Boot binary must be built
differently.

Signed-off-by: Caleb Connolly <caleb.connolly@linaro.org>

Keep track of whether we were loaded via ABL or if U-Boot is running as
a first-stage bootloader.

For now we set this based on if we have a valid external FDT or not,
since it isn't possible to chainload U-Boot from ABL without there being
an external FDT.

This will be used to inform the capsule update logic which partition
U-Boot is flashed to.

Signed-off-by: Caleb Connolly <caleb.connolly@linaro.org>

The SCSI layer now issues a SYNC_CACHE command after every write to
ensure there is no data loss due to a board reset after write.

Implement support for this command and remove the same logic from the
ATA write path to be consistent with other SCSI backends.

Ranges are not supported and the whole cache will be flushed in all
cases.

This was done per iteration in ata_scsiop_read_write(), but it's not
clear why this was the case, calling it once for the entire write ought
to achieve the same result.

Signed-off-by: Caleb Connolly <caleb.connolly@linaro.org>

We don't have a mechanism to safely shutdown block devices prior to a
baord reset or driver removal. Prevent data loss by synchronizing the
SCSI cache after every write.

In particular this solves the issue of capsule updates looping on some
devices because the board resets immediately after deleting the capsule
file and this write wouldn't be flushed in time.

This may impact NAND wear, but should be negligible given the usecases
for disk write in U-Boot.

Signed-off-by: Caleb Connolly <caleb.connolly@linaro.org>

This clears the 6th byte of cmd twice rather than setting the 9th byte
to 0. Fix it.

The only other command that sets the 9th byte is the 64-bit read, so
this likely never caused issues in practise.

Signed-off-by: Caleb Connolly <caleb.connolly@linaro.org>

Rui Silva authored 1 month ago and Caleb Connolly committed 3 weeks ago

The length of a property includes '\0' in a string type one, so
the length passed by needs to have that in account, if not,
when getting the property value it will fail because it
has the wrong size.

Signed-off-by: Rui Miguel Silva <rui.silva@linaro.org>
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
Reviewed-by: Caleb Connolly <caleb.connolly@linaro.org>
Link: https://lore.kernel.org/r/20250227094911.497219-2-rui.silva@linaro.org


Signed-off-by: Caleb Connolly <caleb.connolly@linaro.org>

Sam Day authored 1 month ago and Caleb Connolly committed 3 weeks ago

These are necessary for USB gadget to come up properly, now that
qcom_gate_clk_en fails on unknown clocks.

Signed-off-by: Sam Day <me@samcday.com>
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
Link: https://lore.kernel.org/r/20250319-sdm845-usb-clocks-v1-1-ddea854f62ec@samcday.com


Signed-off-by: Caleb Connolly <caleb.connolly@linaro.org>

Enable fastboot support over USB, using MMC as the backend. This will be
the internal eMMC on devices that have it, or the sdcard slot on devices
with UFS (if available).

We don't use a fixed address for the fastboot buffer because it's
allocated at runtime per-board. Entering fastboot mode should be done by
executing "run fastboot" or manually running:

fastboot -l $fastboot_addr_r usb 0

Signed-off-by: Caleb Connolly <caleb.connolly@linaro.org>

This is required for gadget modes to work on most platforms. It must be
disabled for dragonboard410c since that doesn't use dwc3. USB on other
MSM8916 platforms isn't supported by qcom_defconfig anyway.

Signed-off-by: Caleb Connolly <caleb.connolly@linaro.org>

Missing for UFS.

Signed-off-by: Caleb Connolly <caleb.connolly@linaro.org>

Necessary for UFS to successfully probe all clocks.

Signed-off-by: Caleb Connolly <caleb.connolly@linaro.org>

The RPMh PD is a vote-driven power-controller provided by the RPMh
co-processor. Since we aren't implementing power management support in
U-Boot (e.g. for entering low power states) we can just stub this and
rely on the votes provided by earlier boot stages.

Add a specific of_match to the PD stub to match against this for SC7280.
This is required for i2c and spi.

Signed-off-by: Caleb Connolly <caleb.connolly@linaro.org>

Some clock controllers are also power domain controllers, add support
for stubbing these too.

Signed-off-by: Caleb Connolly <caleb.connolly@linaro.org>

same as rb2 but just changed the DT.

Signed-off-by: Caleb Connolly <caleb.connolly@linaro.org>

Now that the rpm node has a generic compatible, replace the sm6115
specific one with that. This fixed clk stub not binding for rpmcc on
qcm2290/qrb2210 and enables MMC on RB1.

Signed-off-by: Caleb Connolly <caleb.connolly@linaro.org>

This reverts commit 131d5f916ed27ba13fee1dec99c8373039f0b50c.

needed when running in EL2.

Signed-off-by: Caleb Connolly <caleb.connolly@linaro.org>

for cmd-db and fb

Signed-off-by: Caleb Connolly <caleb.connolly@linaro.org>

This reverts commit 3d227912.

Under some conditions it's possible to hit the null condition here like
when running with OF_LIVE and using the ofnode API before
initr_of_live() is called. There is very little null
checking for this in the FDT framework, so returning null here can
result in weird null pointer conditions.

Instead let's return the control FDT in the fallback case, this is
usually what the user was expecting.

Signed-off-by: Caleb Connolly <caleb.connolly@linaro.org>

We already build arm64 images with frame pointers. Let's finally make
use of them in tandem with the new symbol lookup support by unwinding
the stack when an exception occurs, producing a backtrace similar to
those emitted by Linux.

In addition, introduce a dedicated unwind_stack() function which can be
called from anywhere to print a backtrace.

Signed-off-by: Caleb Connolly <caleb.connolly@linaro.org>

This is mostly a port of the Xen hypervisor implementation. The U-Boot
binary is built as normal, then its symbol table is fed into
tools/symbols to generate an optimised lookup table. U-Boot is rebuilt
with the symbol table and handling code in lib/symbols.c.

Based on code from Xen at
  c20850540ad6("x86/altcall: always use a temporary parameter stashing variable")

Signed-off-by: Caleb Connolly <caleb.connolly@linaro.org>

There was some very old code floating around for decoding symbols, it's
incomplete and is never built. Remove it so we can add a new
implementation.

Reviewed-by: Tom Rini <trini@konsulko.com>
Reviewed-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>
Signed-off-by: Caleb Connolly <caleb.connolly@linaro.org>

This reverts commit dbd5ad88.

It may be the case that MMC support is enabled even though the board
we're booting on doesn't have any MMC devices. Move the print over to
the print_mmc_devices() function where we can only print it if we
actually have MMC devices.

Signed-off-by: Caleb Connolly <caleb.connolly@linaro.org>

Signed-off-by: Caleb Connolly <caleb.connolly@linaro.org>

Simple env to boot an Android boot image via fastboot.

Signed-off-by: Caleb Connolly <caleb.connolly@linaro.org>

If available, otherwise fall back to cmdline.

Signed-off-by: Caleb Connolly <caleb.connolly@linaro.org>

Set the vendor ID to qcom and some common product ID for fastboot mode.

Signed-off-by: Caleb Connolly <caleb.connolly@linaro.org>