Skip to content
Snippets Groups Projects
  1. Jan 18, 2013
  2. Jan 17, 2013
    • Ben Hutchings's avatar
      staging: vt6656: Fix inconsistent structure packing · 1ee4c55f
      Ben Hutchings authored
      
      vt6656 has several headers that use the #pragma pack(1) directive to
      enable structure packing, but never disable it.  The layout of
      structures defined in other headers can then depend on which order the
      various headers are included in, breaking the One Definition Rule.
      
      In practice this resulted in crashes on x86_64 until the order of header
      inclusion was changed for some files in commit 11d404cb ('staging:
      vt6656: fix headers and add cfg80211.').  But we need a proper fix that
      won't be affected by future changes to the order of inclusion.
      
      This removes the #pragma pack(1) directives and adds __packed to the
      structure definitions for which packing appears to have been intended.
      
      Reported-and-tested-by: default avatarMalcolm Priestley <tvboxspy@gmail.com>
      Signed-off-by: default avatarBen Hutchings <ben@decadent.org.uk>
      Cc: stable@vger.kernel.org
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      1ee4c55f
  3. Jan 14, 2013
  4. Jan 09, 2013
  5. Jan 07, 2013
  6. Jan 03, 2013
Loading