Skip to content
Snippets Groups Projects
Select Git revision
  • krzk/sm8750/visense-cps-testing-on-top-of-sm8750-audio-lpass
  • release/qcomlt-6.6
  • release/qcomlt-6.0
  • tracking-qcomlt-sm8650
  • integration-linux-qcomlt-wip
  • tracking-pci-mhi-edma
  • release/qcomlt-6.4
  • master default
  • tracking-qcomlt-sa8155p-dts-drivers
  • tracking-qcomlt-arm64-defconfig
  • tracking-qcomlt-drm-msm
  • release/qcomlt-6.4-rt
  • integration-linux-qcomlt
  • caleb/qcomlt-6.4-uboot-demo
  • tracking-qcomlt-ufs
  • tracking-rb12
  • tracking-qcomlt-sm8450-dts
  • tracking-qcomlt-msm8996
  • tracking-qcomlt-sm8450-drivers
  • tracking-qcomlt-config-fragments
  • v6.6.9
  • v6.6.8
  • v6.6.7
  • v6.6.6
  • v6.6.5
  • v6.7-rc4
  • v6.6.4
  • v6.6.3
  • v6.7-rc3
  • v6.6.2
  • v6.7-rc2
  • v6.7-rc1
  • v6.6.1
  • v6.6
  • v6.6-rc7
  • v6.6-rc6
  • v6.6-rc5
  • v6.6-rc4
  • v6.6-rc3
  • v6.6-rc2
40 results
Search by author
  • Any Author
  • Abel Vesa Abel Vesa abel.vesa
  • Alexey Klimov Alexey Klimov alexey.klimov
  • Bartosz Golaszewski Bartosz Golaszewski bartosz_golaszewski
  • Bryan O'Donoghue Bryan O'Donoghue bryan.odonoghue
  • Caleb Connolly Caleb Connolly caleb_connolly
  • Chetan Sharma Chetan Sharma chetan_sharma
  • Christopher Obbard Christopher Obbard christopher.obbard
  • CodeLinaro CodeLinaro codelinaro
  • Dmitry Baryshkov Dmitry Baryshkov dmitry.baryshkov
  • Ettore Chimenti Ettore Chimenti ettore.chimenti
  • Eugen Hristev Eugen Hristev eugen.hristev
  • Joshua Sickmeyer Joshua Sickmeyer joshua.sickmeyer
  • Jun Nie Jun Nie jun_nie
  • Krzysztof Krzysztof krzysztof.kozlowski
  • Mani Sadhasivam Mani Sadhasivam manivannan.sadhasivam
  • Neil Armstrong Neil Armstrong neil.armstrong
  • Paul Neuhardt Paul Neuhardt paul.neuhardt
  • QCLT Bot Service Account QCLT Bot Service Account qclt-bot
  • Srini Kandagatla Srini Kandagatla srinivas.kandagatla
  • Stephan Gerhold Stephan Gerhold stephan.gerhold
20 authors
  1. Apr 22, 2022
  3. Apr 20, 2022
  5. Apr 18, 2022
  7. Mar 09, 2022
    • Eric W. Biederman's avatar
      coredump: Don't compile flat_core_dump when coredumps are disabled · f833116a
      Eric W. Biederman authored 
      
Recently the kernel test robot reported:
> In file included from include/linux/kernel.h:29,
>                     from fs/binfmt_flat.c:21:
>    fs/binfmt_flat.c: In function 'flat_core_dump':
> >> fs/binfmt_flat.c:121:50: error: invalid use of undefined type 'struct coredump_params'
>      121 |                 current->comm, current->pid, cprm->siginfo->si_signo);
>          |                                                  ^~
>    include/linux/printk.h:418:33: note: in definition of macro 'printk_index_wrap'
>      418 |                 _p_func(_fmt, ##__VA_ARGS__);                           \
>          |                                 ^~~~~~~~~~~
>    include/linux/printk.h:499:9: note: in expansion of macro 'printk'
>      499 |         printk(KERN_WARNING pr_fmt(fmt), ##__VA_ARGS__)
>          |         ^~~~~~
>    fs/binfmt_flat.c:120:9: note: in expansion of macro 'pr_warn'
>      120 |         pr_warn("Process %s:%d received signr %d and should have core dumped\n",
>          |         ^~~~~~~
>    At top level:
>    fs/binfmt_flat.c:118:12: warning: 'flat_core_dump' defined but not used [-Wunused-function]
>      118 | static int flat_core_dump(struct coredump_params *cprm)
>          |            ^~~~~~~~~~~~~~

The little dinky do nothing function flat_core_dump has always been
compiled unconditionally.  With my change to move coredump_params into
coredump.h coredump_params reasonably becomes unavailable when
coredump support is not compiled in.  Fix this old issue by simply not
compiling flat_core_dump when coredump support is not supported.

Fixes: a99a3e2e ("coredump: Move definition of struct coredump_params into coredump.h")
Reported-by: default avatarkernel test robot <lkp@intel.com>
Signed-off-by: default avatar"Eric W. Biederman" <ebiederm@xmission.com>
      f833116a
  9. Mar 08, 2022
  11. Mar 02, 2022
  13. Jun 29, 2021
  15. Apr 18, 2021
    • Damien Le Moal's avatar
      binfmt_flat: allow not offsetting data start · 04d82a6d
      Damien Le Moal authored 
      
Commit 2217b982 ("binfmt_flat: revert "binfmt_flat: don't offset
the data start"") restored offsetting the start of the data section by
a number of words defined by MAX_SHARED_LIBS. As a result, since
MAX_SHARED_LIBS is never 0, a gap between the text and data sections
always exists. For architectures which cannot support a such gap
between the text and data sections (e.g. riscv nommu), flat binary
programs cannot be executed.

To allow an architecture to request no data start offset to allow for
contiguous text and data sections for binaries flagged with
FLAT_FLAG_RAM, introduce the new config option
CONFIG_BINFMT_FLAT_NO_DATA_START_OFFSET. Using this new option, the
macro DATA_START_OFFSET_WORDS is conditionally defined in binfmt_flat.c
to MAX_SHARED_LIBS for architectures tolerating or needing the data
start offset (CONFIG_BINFMT_FLAT_NO_DATA_START_OFFSET disabled case)
and to 0 when CONFIG_BINFMT_FLAT_NO_DATA_START_OFFSET is enabled.
DATA_START_OFFSET_WORDS is used in load_flat_file() to calculate the
data section length and start position.

Signed-off-by: default avatarDamien Le Moal <damien.lemoal@wdc.com>
Signed-off-by: default avatarGreg Ungerer <gerg@linux-m68k.org>
      04d82a6d
  17. Aug 23, 2020
    • Max Filippov's avatar
      binfmt_flat: revert "binfmt_flat: don't offset the data start" · 2217b982
      Max Filippov authored 
      
binfmt_flat loader uses the gap between text and data to store data
segment pointers for the libraries. Even in the absence of shared
libraries it stores at least one pointer to the executable's own data
segment. Text and data can go back to back in the flat binary image and
without offsetting data segment last few instructions in the text
segment may get corrupted by the data segment pointer.

Fix it by reverting commit a2357223 ("binfmt_flat: don't offset the
data start").

Cc: stable@vger.kernel.org
Fixes: a2357223 ("binfmt_flat: don't offset the data start")
Signed-off-by: default avatarMax Filippov <jcmvbkbc@gmail.com>
Signed-off-by: default avatarGreg Ungerer <gerg@linux-m68k.org>
      2217b982
  19. Jun 08, 2020
  21. Jun 03, 2020
  23. May 07, 2020
  25. Jul 17, 2019
  27. Jun 29, 2019
    • Jann Horn's avatar
      fs/binfmt_flat.c: make load_flat_shared_library() work · 867bfa4a
      Jann Horn authored 
      load_flat_shared_library() is broken: It only calls load_flat_file() if
prepare_binprm() returns zero, but prepare_binprm() returns the number of
bytes read - so this only happens if the file is empty.

Instead, call into load_flat_file() if the number of bytes read is
non-negative. (Even if the number of bytes is zero - in that case,
load_flat_file() will see nullbytes and return a nice -ENOEXEC.)

In addition, remove the code related to bprm creds and stop using
prepare_binprm() - this code is loading a library, not a main executable,
and it only actually uses the members "buf", "file" and "filename" of the
linux_binprm struct. Instead, call kernel_read() directly.

Link: http://lkml.kernel.org/r/20190524201817.16509-1-jannh@google.com


Fixes: 287980e4 ("remove lots of IS_ERR_VALUE abuses")
Signed-off-by: default avatarJann Horn <jannh@google.com>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>
Cc: Kees Cook <keescook@chromium.org>
Cc: Nicolas Pitre <nicolas.pitre@linaro.org>
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Russell King <linux@armlinux.org.uk>
Cc: Greg Ungerer <gerg@linux-m68k.org>
Cc: <stable@vger.kernel.org>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
      867bfa4a
  29. Jun 23, 2019
  31. Apr 11, 2018
  33. Nov 02, 2017
    • Greg Kroah-Hartman's avatar
      License cleanup: add SPDX GPL-2.0 license identifier to files with no license · b2441318
      Greg Kroah-Hartman authored 
      
Many source files in the tree are missing licensing information, which
makes it harder for compliance tools to determine the correct license.

By default all files without license information are under the default
license of the kernel, which is GPL version 2.

Update the files which contain no license information with the 'GPL-2.0'
SPDX license identifier.  The SPDX identifier is a legally binding
shorthand, which can be used instead of the full boiler plate text.

This patch is based on work done by Thomas Gleixner and Kate Stewart and
Philippe Ombredanne.

How this work was done:

Patches were generated and checked against linux-4.14-rc6 for a subset of
the use cases:
 - file had no licensing information it it.
 - file was a */uapi/* one with no licensing information in it,
 - file was a */uapi/* one with existing licensing information,

Further patches will be generated in subsequent months to fix up cases
where non-standard license headers were used, and references to license
had to be inferred by heuristics based on keywords.

The analysis to determine which SPDX License Identifier to be applied to
a file was done in a spreadsheet of side by side results from of the
output of two independent scanners (ScanCode & Windriver) producing SPDX
tag:value files created by Philippe Ombredanne.  Philippe prepared the
base worksheet, and did an initial spot review of a few 1000 files.

The 4.13 kernel was the starting point of the analysis with 60,537 files
assessed.  Kate Stewart did a file by file comparison of the scanner
results in the spreadsheet to determine which SPDX license identifier(s)
to be applied to the file. She confirmed any determination that was not
immediately clear with lawyers working with the Linux Foundation.

Criteria used to select files for SPDX license identifier tagging was:
 - Files considered eligible had to be source code files.
 - Make and config files were included as candidates if they contained >5
   lines of source
 - File already had some variant of a license header in it (even if <5
   lines).

All documentation files were explicitly excluded.

The following heuristics were used to determine which SPDX license
identifiers to apply.

 - when both scanners couldn't find any license traces, file was
   considered to have no license information in it, and the top level
   COPYING file license applied.

   For non */uapi/* files that summary was:

   SPDX license identifier                            # files
   ---------------------------------------------------|-------
   GPL-2.0                                              11139

   and resulted in the first patch in this series.

   If that file was a */uapi/* path one, it was "GPL-2.0 WITH
   Linux-syscall-note" otherwise it was "GPL-2.0".  Results of that was:

   SPDX license identifier                            # files
   ---------------------------------------------------|-------
   GPL-2.0 WITH Linux-syscall-note                        930

   and resulted in the second patch in this series.

 - if a file had some form of licensing information in it, and was one
   of the */uapi/* ones, it was denoted with the Linux-syscall-note if
   any GPL family license was found in the file or had no licensing in
   it (per prior point).  Results summary:

   SPDX license identifier                            # files
   ---------------------------------------------------|------
   GPL-2.0 WITH Linux-syscall-note                       270
   GPL-2.0+ WITH Linux-syscall-note                      169
   ((GPL-2.0 WITH Linux-syscall-note) OR BSD-2-Clause)    21
   ((GPL-2.0 WITH Linux-syscall-note) OR BSD-3-Clause)    17
   LGPL-2.1+ WITH Linux-syscall-note                      15
   GPL-1.0+ WITH Linux-syscall-note                       14
   ((GPL-2.0+ WITH Linux-syscall-note) OR BSD-3-Clause)    5
   LGPL-2.0+ WITH Linux-syscall-note                       4
   LGPL-2.1 WITH Linux-syscall-note                        3
   ((GPL-2.0 WITH Linux-syscall-note) OR MIT)              3
   ((GPL-2.0 WITH Linux-syscall-note) AND MIT)             1

   and that resulted in the third patch in this series.

 - when the two scanners agreed on the detected license(s), that became
   the concluded license(s).

 - when there was disagreement between the two scanners (one detected a
   license but the other didn't, or they both detected different
   licenses) a manual inspection of the file occurred.

 - In most cases a manual inspection of the information in the file
   resulted in a clear resolution of the license that should apply (and
   which scanner probably needed to revisit its heuristics).

 - When it was not immediately clear, the license identifier was
   confirmed with lawyers working with the Linux Foundation.

 - If there was any question as to the appropriate license identifier,
   the file was flagged for further research and to be revisited later
   in time.

In total, over 70 hours of logged manual review was done on the
spreadsheet to determine the SPDX license identifiers to apply to the
source files by Kate, Philippe, Thomas and, in some cases, confirmation
by lawyers working with the Linux Foundation.

Kate also obtained a third independent scan of the 4.13 code base from
FOSSology, and compared selected files where the other two scanners
disagreed against that SPDX file, to see if there was new insights.  The
Windriver scanner is based on an older version of FOSSology in part, so
they are related.

Thomas did random spot checks in about 500 files from the spreadsheets
for the uapi headers and agreed with SPDX license identifier in the
files he inspected. For the non-uapi files Thomas did random spot checks
in about 15000 files.

In initial set of patches against 4.14-rc6, 3 files were found to have
copy/paste license identifier errors, and have been fixed to reflect the
correct identifier.

Additionally Philippe spent 10 hours this week doing a detailed manual
inspection and review of the 12,461 patched files from the initial patch
version early this week with:
 - a full scancode scan run, collecting the matched texts, detected
   license ids and scores
 - reviewing anything where there was a license detected (about 500+
   files) to ensure that the applied SPDX license was correct
 - reviewing anything where there was no detection but the patch license
   was not GPL-2.0 WITH Linux-syscall-note to ensure that the applied
   SPDX license was correct

This produced a worksheet with 20 files needing minor correction.  This
worksheet was then exported into 3 different .csv files for the
different types of files to be modified.

These .csv files were then reviewed by Greg.  Thomas wrote a script to
parse the csv files and add the proper SPDX tag to the file, in the
format that the file expected.  This script was further refined by Greg
based on the output to detect more types of files automatically and to
distinguish between header and source .c files (which need different
comment types.)  Finally Greg ran the script using the .csv files to
generate the patches.

Reviewed-by: default avatarKate Stewart <kstewart@linuxfoundation.org>
Reviewed-by: default avatarPhilippe Ombredanne <pombredanne@nexb.com>
Reviewed-by: default avatarThomas Gleixner <tglx@linutronix.de>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      b2441318
  35. Sep 09, 2017
  37. Sep 04, 2017
  39. Aug 01, 2017
  41. Jul 16, 2017
  43. Jul 03, 2017
  45. Mar 02, 2017
  47. Jul 28, 2016