Merge tag 'Wimplicit-fallthrough-clang-5.14-rc2' of...
Merge tag 'Wimplicit-fallthrough-clang-5.14-rc2' of git://git.kernel.org/pub/scm/linux/kernel/git/gustavoars/linux Pull fallthrough fixes from Gustavo Silva: "This fixes many fall-through warnings when building with Clang and -Wimplicit-fallthrough, and also enables -Wimplicit-fallthrough for Clang, globally. It's also important to notice that since we have adopted the use of the pseudo-keyword macro fallthrough, we also want to avoid having more /* fall through */ comments being introduced. Contrary to GCC, Clang doesn't recognize any comments as implicit fall-through markings when the -Wimplicit-fallthrough option is enabled. So, in order to avoid having more comments being introduced, we use the option -Wimplicit-fallthrough=5 for GCC, which similar to Clang, will cause a warning in case a code comment is intended to be used as a fall-through marking. The patch for Makefile also enforces this. We had almost 4,000 of these issues for Clang in the beginning, and there might be a couple more out there when building some architectures with certain configurations. However, with the recent fixes I think we are in good shape and it is now possible to enable the warning for Clang" * tag 'Wimplicit-fallthrough-clang-5.14-rc2' of git://git.kernel.org/pub/scm/linux/kernel/git/gustavoars/linux: (27 commits) Makefile: Enable -Wimplicit-fallthrough for Clang powerpc/smp: Fix fall-through warning for Clang dmaengine: mpc512x: Fix fall-through warning for Clang usb: gadget: fsl_qe_udc: Fix fall-through warning for Clang powerpc/powernv: Fix fall-through warning for Clang MIPS: Fix unreachable code issue MIPS: Fix fall-through warnings for Clang ASoC: Mediatek: MT8183: Fix fall-through warning for Clang power: supply: Fix fall-through warnings for Clang dmaengine: ti: k3-udma: Fix fall-through warning for Clang s390: Fix fall-through warnings for Clang dmaengine: ipu: Fix fall-through warning for Clang iommu/arm-smmu-v3: Fix fall-through warning for Clang mmc: jz4740: Fix fall-through warning for Clang PCI: Fix fall-through warning for Clang scsi: libsas: Fix fall-through warning for Clang video: fbdev: Fix fall-through warning for Clang math-emu: Fix fall-through warning cpufreq: Fix fall-through warning for Clang drm/msm: Fix fall-through warning in msm_gem_new_impl() ...
Showing
- Makefile 3 additions, 6 deletionsMakefile
- arch/mips/include/asm/fpu.h 1 addition, 1 deletionarch/mips/include/asm/fpu.h
- arch/mips/mm/tlbex.c 2 additions, 0 deletionsarch/mips/mm/tlbex.c
- arch/powerpc/platforms/powermac/smp.c 1 addition, 0 deletionsarch/powerpc/platforms/powermac/smp.c
- arch/s390/kernel/uprobes.c 1 addition, 0 deletionsarch/s390/kernel/uprobes.c
- drivers/char/powernv-op-panel.c 1 addition, 0 deletionsdrivers/char/powernv-op-panel.c
- drivers/cpufreq/longhaul.c 0 additions, 2 deletionsdrivers/cpufreq/longhaul.c
- drivers/dma/ipu/ipu_idmac.c 2 additions, 0 deletionsdrivers/dma/ipu/ipu_idmac.c
- drivers/dma/mpc512x_dma.c 1 addition, 0 deletionsdrivers/dma/mpc512x_dma.c
- drivers/dma/ti/k3-udma.c 1 addition, 0 deletionsdrivers/dma/ti/k3-udma.c
- drivers/gpu/drm/i915/gem/i915_gem_shrinker.c 1 addition, 0 deletionsdrivers/gpu/drm/i915/gem/i915_gem_shrinker.c
- drivers/gpu/drm/msm/msm_gem.c 1 addition, 1 deletiondrivers/gpu/drm/msm/msm_gem.c
- drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c 1 addition, 0 deletionsdrivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c
- drivers/mmc/host/jz4740_mmc.c 2 additions, 0 deletionsdrivers/mmc/host/jz4740_mmc.c
- drivers/mtd/chips/cfi_util.c 2 additions, 2 deletionsdrivers/mtd/chips/cfi_util.c
- drivers/net/ethernet/netronome/nfp/flower/conntrack.c 1 addition, 0 deletionsdrivers/net/ethernet/netronome/nfp/flower/conntrack.c
- drivers/net/wireless/mediatek/mt76/mt7921/main.c 1 addition, 0 deletionsdrivers/net/wireless/mediatek/mt76/mt7921/main.c
- drivers/pci/proc.c 1 addition, 1 deletiondrivers/pci/proc.c
- drivers/power/supply/ab8500_fg.c 2 additions, 0 deletionsdrivers/power/supply/ab8500_fg.c
- drivers/power/supply/abx500_chargalg.c 1 addition, 0 deletionsdrivers/power/supply/abx500_chargalg.c
Loading
Please register or sign in to comment