proc: proc_pid_ns takes super_block as an argument
syzbot found that touch /proc/testfile causes NULL pointer dereference at tomoyo_get_local_path() because inode of the dentry is NULL. Before c59f415a, Tomoyo received pid_ns from proc's s_fs_info directly. Since proc_pid_ns() can only work with inode, using it in the tomoyo_get_local_path() was wrong. To avoid creating more functions for getting proc_ns, change the argument type of the proc_pid_ns() function. Then, Tomoyo can use the existing super_block to get pid_ns. Link: https://lkml.kernel.org/r/0000000000002f0c7505a5b0e04c@google.com Link: https://lkml.kernel.org/r/20200518180738.2939611-1-gladkov.alexey@gmail.com Reported-by:<syzbot+c1af344512918c61362c@syzkaller.appspotmail.com> Fixes: c59f415a ("Use proc_pid_ns() to get pid_namespace from the proc superblock") Signed-off-by:
Alexey Gladkov <gladkov.alexey@gmail.com> Signed-off-by:
Eric W. Biederman <ebiederm@xmission.com>
Showing
- fs/locks.c 2 additions, 2 deletionsfs/locks.c
- fs/proc/array.c 1 addition, 1 deletionfs/proc/array.c
- fs/proc/base.c 5 additions, 5 deletionsfs/proc/base.c
- fs/proc/self.c 1 addition, 1 deletionfs/proc/self.c
- fs/proc/thread_self.c 1 addition, 1 deletionfs/proc/thread_self.c
- include/linux/proc_fs.h 2 additions, 2 deletionsinclude/linux/proc_fs.h
- kernel/fork.c 1 addition, 1 deletionkernel/fork.c
- net/ipv6/ip6_flowlabel.c 1 addition, 1 deletionnet/ipv6/ip6_flowlabel.c
- security/tomoyo/realpath.c 1 addition, 1 deletionsecurity/tomoyo/realpath.c
Loading
Please register or sign in to comment