Skip to content
Snippets Groups Projects
Commit 50f83737 authored by Øyvind A. Holm's avatar Øyvind A. Holm Committed by Sinclair Yeh
Browse files

drm/vmwgfx: Revert "drm/vmwgfx: Replace numeric parameter like 0444 with macro"


This reverts commit 2d8e60e8 ("drm/vmwgfx: Replace numeric
parameter like 0444 with macro")

The commit belongs to the series of 1285 patches sent to LKML on
2016-08-02, it changes the representation of file permissions from the
octal value "0600" to "S_IRUSR | S_IWUSR".

The general consensus was that the changes does not increase
readability, quite the opposite; 0600 is easier to parse mentally than
S_IRUSR | S_IWUSR.

It also causes argument inconsistency, due to commit 04319d89
("drm/vmwgfx: Add an option to change assumed FB bpp") that added
another call to module_param_named() where the permissions are written
as 0600.

Signed-off-by: default avatarØyvind A. Holm <sunny@sunbase.org>
Reviewed-by: default avatarSinclair Yeh <syeh@vmware.com>
parent e9cebe83
No related branches found
No related tags found
No related merge requests found
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment