Skip to content
Snippets Groups Projects
  1. Jul 10, 2015
  2. Dec 11, 2014
  3. Aug 26, 2014
  4. Jul 12, 2014
  5. Dec 02, 2013
  6. Nov 13, 2013
  7. Nov 06, 2013
  8. Feb 28, 2013
    • Nishanth Menon's avatar
      scripts/kernel-doc: handle struct member __aligned without numbers · 9dc30918
      Nishanth Menon authored
      
      Commit ef5da59f ("scripts/kernel-doc: handle struct member
      __aligned") permits "char something [123] __aligned(8);".
      
      However, by using \d we constraint ourselves with integers.  This is not
      always the case.  In fact, it might be better to do char something[123]
      __aligned(sizeof(u16));
      
      For example, With wireless_dev defining:
      
          u8 address[ETH_ALEN] __aligned(sizeof(u16));
      
      With \d, scripts/kernel-doc erroneously says:
      
          Warning(include/net/cfg80211.h:2618): Excess struct/union/enum/typedef member 'address' description in 'wireless_dev'
      
      This is because the regex __aligned\s*\(\d+\) fails match at \d as
      sizeof is used.
      
      So replace \d with .  to indicate "something" in kernel-doc to ignore
      __aligned(SOMETHING) in structs.  With this change, we can use integers
      OR sizeof() or macros as we please.
      
      Signed-off-by: default avatarNishanth Menon <nm@ti.com>
      Cc: Fengguang Wu <fengguang.wu@intel.com>
      Cc: Johannes Berg <johannes.berg@intel.com>
      Cc: Randy Dunlap <rdunlap@infradead.org>
      Cc: Michal Marek <mmarek@suse.cz>
      Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
      Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
      9dc30918
  9. Jan 03, 2013
    • Greg Kroah-Hartman's avatar
      misc: remove __dev* attributes. · 6ae14171
      Greg Kroah-Hartman authored
      
      CONFIG_HOTPLUG is going away as an option.  As a result, the __dev*
      markings need to be removed.
      
      This change removes the last of the __dev* markings from the kernel from
      a variety of different, tiny, places.
      
      Based on patches originally written by Bill Pemberton, but redone by me
      in order to handle some of the coding style issues better, by hand.
      
      Cc: Bill Pemberton <wfp5p@virginia.edu>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      6ae14171
  10. Dec 06, 2012
  11. Nov 27, 2012
  12. Oct 05, 2012
    • Daniel Santos's avatar
      kernel-doc: don't mangle whitespace in Example section · 12ae6779
      Daniel Santos authored
      
      A section with the name "Example" (case-insensitive) has a special meaning
      to kernel-doc.  These sections are output using mono-type fonts.  However,
      leading whitespace is stripped, thus robbing a lot of meaning from this,
      as indented code examples will be mangled.
      
      This patch preserves the leading whitespace for "Example" sections.  More
      accurately, it preserves it for all sections, but removes it later if the
      section isn't an "Example" section.
      
      Signed-off-by: default avatarDaniel Santos <daniel.santos@pobox.com>
      Cc: Randy Dunlap <rdunlap@xenotime.net>
      Cc: Michal Marek <mmarek@suse.cz>
      Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
      Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
      12ae6779
    • Daniel Santos's avatar
      kernel-doc: bugfix - empty line in Example section · e314ba31
      Daniel Santos authored
      
      If you have a section named "Example" that contains an empty line,
      attempting to generate htmldocs give you the error:
      
      /path/Documentation/DocBook/kernel-api.xml:3455: parser error : Opening and ending tag mismatch: programlisting line 3449 and para
         </para><para>
                ^
      /path/Documentation/DocBook/kernel-api.xml:3473: parser error : Opening and ending tag mismatch: para line 3467 and programlisting
      </programlisting></informalexample>
                       ^
      /path/Documentation/DocBook/kernel-api.xml:3678: parser error : Opening and ending tag mismatch: programlisting line 3672 and para
         </para><para>
                ^
      /path/Documentation/DocBook/kernel-api.xml:3701: parser error : Opening and ending tag mismatch: para line 3690 and programlisting
      </programlisting></informalexample>
                       ^
      unable to parse
      /path/Documentation/DocBook/kernel-api.xml
      
      Essentially, the script attempts to close a <programlisting> with a
      closing tag for a <para> block.  This patch corrects the problem by
      simply not outputting anything extra when we're dumping pre-formatted
      text, since the empty line will be rendered correctly anyway.
      
      Signed-off-by: default avatarDaniel Santos <daniel.santos@pobox.com>
      Cc: Randy Dunlap <rdunlap@xenotime.net>
      Cc: Michal Marek <mmarek@suse.cz>
      Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
      Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
      e314ba31
    • Daniel Santos's avatar
      kernel-doc: bugfix - multi-line macros · 65478428
      Daniel Santos authored
      
      Prior to this patch the following code breaks:
      
      /**
       * multiline_example - this breaks kernel-doc
       */
       #define multiline_example( \
      myparam)
      
      Producing this error:
      
      Error(somefile.h:983): cannot understand prototype: 'multiline_example( \ '
      
      This patch fixes the issue by appending all lines ending in a blackslash
      (optionally followed by whitespace), removing the backslash and any
      whitespace after it prior to appending (just like the C pre-processor
      would).
      
      This fixes a break in kerel-doc introduced by the additions to rbtree.h.
      
      Signed-off-by: default avatarDaniel Santos <daniel.santos@pobox.com>
      Cc: Randy Dunlap <rdunlap@xenotime.net>
      Cc: Michal Marek <mmarek@suse.cz>
      Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
      Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
      65478428
  13. Aug 31, 2012
  14. Aug 17, 2012
  15. Jan 23, 2012
  16. Mar 31, 2011
  17. Jan 06, 2011
    • Randy Dunlap's avatar
      kernel-doc: code reorganization · 8484baaa
      Randy Dunlap authored
      
      Move 'main' code vs. subroutines around so that they are not so
      intermixed, for better readability/understanding (relative to Perl).
      It was messy to follow the primary flow of code execution with the
      code being mixed.  Now the code begins with data initialization,
      followed by all subroutines, then ends with the main code execution.
      
      This is almost totally source code movement, with a few changes as
      needed for forward declarations.
      
      Signed-off-by: default avatarRandy Dunlap <randy.dunlap@oracle.com>
      Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
      8484baaa
  18. Nov 18, 2010
    • Randy Dunlap's avatar
      kernel-doc: escape xml for structs · 2b35f4d9
      Randy Dunlap authored
      
      scripts/kernel-doc was leaving unescaped '<', '>', and '&' in
      generated xml output for structs.  This causes xml parser errors.
      Convert these characters to "&lt;", "&gt;", and "&amp;" as needed
      to prevent errors.
      
      Most of the conversion was already done; complete it just before
      output.
      
      Documentation/DocBook/device-drivers.xml:41883: parser error : StartTag: invalid element name
      #define INPUT_KEYMAP_BY_INDEX	(1 << 0)
      
      Signed-off-by: default avatarRandy Dunlap <randy.dunlap@oracle.com>
      Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
      2b35f4d9
  19. Sep 11, 2010
  20. Aug 11, 2010
    • Randy Dunlap's avatar
      mtd/nand_base: fix kernel-doc warnings & typos · b6d676db
      Randy Dunlap authored
      
      Fix mtd/nand_base.c kernel-doc warnings and typos.
      
      Warning(drivers/mtd/nand/nand_base.c:893): No description found for parameter 'mtd'
      Warning(drivers/mtd/nand/nand_base.c:893): No description found for parameter 'ofs'
      Warning(drivers/mtd/nand/nand_base.c:893): No description found for parameter 'len'
      Warning(drivers/mtd/nand/nand_base.c:893): No description found for parameter 'invert'
      Warning(drivers/mtd/nand/nand_base.c:930): No description found for parameter 'mtd'
      Warning(drivers/mtd/nand/nand_base.c:930): No description found for parameter 'ofs'
      Warning(drivers/mtd/nand/nand_base.c:930): No description found for parameter 'len'
      Warning(drivers/mtd/nand/nand_base.c:987): No description found for parameter 'mtd'
      Warning(drivers/mtd/nand/nand_base.c:987): No description found for parameter 'ofs'
      Warning(drivers/mtd/nand/nand_base.c:987): No description found for parameter 'len'
      Warning(drivers/mtd/nand/nand_base.c:2087): No description found for parameter 'len'
      
      Signed-off-by: default avatarRandy Dunlap <randy.dunlap@oracle.com>
      Cc: David Woodhouse <dwmw2@infradead.org>
      Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
      Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
      b6d676db
  21. Aug 10, 2010
    • Randy Dunlap's avatar
      mtd/nand_base: fix kernel-doc warnings & typos · db9ebb7c
      Randy Dunlap authored
      
      Fix mtd/nand_base.c kernel-doc warnings and typos.
      
      Warning(drivers/mtd/nand/nand_base.c:893): No description found for parameter 'mtd'
      Warning(drivers/mtd/nand/nand_base.c:893): No description found for parameter 'ofs'
      Warning(drivers/mtd/nand/nand_base.c:893): No description found for parameter 'len'
      Warning(drivers/mtd/nand/nand_base.c:893): No description found for parameter 'invert'
      Warning(drivers/mtd/nand/nand_base.c:930): No description found for parameter 'mtd'
      Warning(drivers/mtd/nand/nand_base.c:930): No description found for parameter 'ofs'
      Warning(drivers/mtd/nand/nand_base.c:930): No description found for parameter 'len'
      Warning(drivers/mtd/nand/nand_base.c:987): No description found for parameter 'mtd'
      Warning(drivers/mtd/nand/nand_base.c:987): No description found for parameter 'ofs'
      Warning(drivers/mtd/nand/nand_base.c:987): No description found for parameter 'len'
      Warning(drivers/mtd/nand/nand_base.c:2087): No description found for parameter 'len'
      
      Signed-off-by: default avatarRandy Dunlap <randy.dunlap@oracle.com>
      Signed-off-by: default avatarDavid Woodhouse <David.Woodhouse@intel.com>
      db9ebb7c
  22. Mar 24, 2010
  23. Mar 12, 2010
  24. Feb 27, 2010
  25. Dec 02, 2009
    • Jason Baron's avatar
      tracing: Add DEFINE_EVENT(), DEFINE_SINGLE_EVENT() support to docbook · 3a9089fd
      Jason Baron authored
      
      The introduction of the new 'DECLARE_EVENT_CLASS()' obviates the
      need for the 'TRACE_EVENT()' macro in some cases. Thus, docbook
      style comments that used to live with 'TRACE_EVENT()' are now
      moved to 'DEFINE_EVENT()'. Thus, we need to make the docbook
      system understand the new 'DEFINE_EVENT()' macro. In addition
      I've tried to futureproof the patch, by also adding support for
      'DEFINE_SINGLE_EVENT()', since there has been discussion about
      renaming: TRACE_EVENT() -> DEFINE_SINGLE_EVENT().
      
      Without this patch the tracepoint docbook fails to build.
      
      I've verified that this patch correctly builds the tracepoint
      docbook which currently covers signals, and irqs.
      
      Changes in v2:
       - properly indent perl 'if' statements
      
      Signed-off-by: default avatarJason Baron <jbaron@redhat.com>
      Acked-by: default avatarSteven Rostedt <rostedt@goodmis.org>
      Acked-by: default avatarRandy Dunlap <randy.dunlap@oracle.com>
      Cc: William Cohen <wcohen@redhat.com>
      Cc: Frederic Weisbecker <fweisbec@gmail.com>
      Cc: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>
      Cc: Masami Hiramatsu <mhiramat@redhat.com>
      LKML-Reference: <200912011718.nB1HIn7t011371@int-mx04.intmail.prod.int.phx2.redhat.com>
      Signed-off-by: default avatarIngo Molnar <mingo@elte.hu>
      3a9089fd
  26. Sep 18, 2009
  27. Jul 01, 2009
  28. Jun 20, 2009
  29. Jun 09, 2009
  30. May 02, 2009
  31. May 01, 2009
  32. Feb 11, 2009
    • Randy Dunlap's avatar
      kernel-doc: fix syscall wrapper processing · b4870bc5
      Randy Dunlap authored
      
      Fix kernel-doc processing of SYSCALL wrappers.
      
      The SYSCALL wrapper patches played havoc with kernel-doc for
      syscalls.  Syscalls that were scanned for DocBook processing
      reported warnings like this one, for sys_tgkill:
      
      Warning(kernel/signal.c:2285): No description found for parameter 'tgkill'
      Warning(kernel/signal.c:2285): No description found for parameter 'pid_t'
      Warning(kernel/signal.c:2285): No description found for parameter 'int'
      
      because the macro parameters all "look like" function parameters,
      although they are not:
      
      /**
       *  sys_tgkill - send signal to one specific thread
       *  @tgid: the thread group ID of the thread
       *  @pid: the PID of the thread
       *  @sig: signal to be sent
       *
       *  This syscall also checks the @tgid and returns -ESRCH even if the PID
       *  exists but it's not belonging to the target process anymore. This
       *  method solves the problem of threads exiting and PIDs getting reused.
       */
      SYSCALL_DEFINE3(tgkill, pid_t, tgid, pid_t, pid, int, sig)
      {
      ...
      
      This patch special-cases the handling SYSCALL_DEFINE* function
      prototypes by expanding them to
      	long sys_foobar(type1 arg1, type1 arg2, ...)
      
      Signed-off-by: default avatarRandy Dunlap <randy.dunlap@oracle.com>
      Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
      Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
      b4870bc5
  33. Dec 19, 2008
  34. Dec 02, 2008
Loading