Skip to content
Snippets Groups Projects
  1. Nov 22, 2013
  2. Nov 21, 2013
  3. Nov 20, 2013
  4. Nov 19, 2013
  5. Nov 18, 2013
  6. Nov 16, 2013
  7. Nov 15, 2013
  8. Nov 14, 2013
    • Nicolin Chen's avatar
      ASoC: wm8962: Turn on regcache_cache_only before disabling regulator · 50bfcf2d
      Nicolin Chen authored
      
      It's safer to turn on regcache_cache_only before disabling regulator since
      the driver will turn off the regcache_cache_only after enabling regulator.
      
      If we remain cache_only false, some command like 'amixer cset' would get
      failure if being run before wm8962_resume().
      
      Signed-off-by: default avatarNicolin Chen <b42378@freescale.com>
      Signed-off-by: default avatarMark Brown <broonie@linaro.org>
      Cc: stable@vger.kernel.org
      50bfcf2d
    • Takashi Iwai's avatar
      ALSA: jack: Unregister input device at disconnection · 32b85442
      Takashi Iwai authored
      
      The recent change in sysfs triggered a kernel WARNING at unloading a
      sound driver like
      
        WARNING: CPU: 3 PID: 2247 at fs/sysfs/group.c:214 sysfs_remove_group+0xe8/0xf0()
        sysfs group ffffffff81ab7b20 not found for kobject 'event14'
      
      for each jack instance.  It's because the unregistration of jack input
      device is done in dev_free callback, which is called after
      snd_card_disconnect().  Since device_unregister(card->card_dev) is
      called in snd_card_disconnect(), the whole sysfs entries belonging to
      card->card_dev have been already removed recursively.  Thus this
      results in a warning as input_unregister_device() yet tries to
      unregister the already removed sysfs entry.
      
      For fixing this mess, we need to unregister the jack input device at
      dev_disconnect callback so that it's called before unregistering the
      card->card_dev.
      
      Reviwed-by: default avatarMark Brown <broonie@linaro.org>
      Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
      32b85442
    • Takashi Iwai's avatar
      ALSA: pcsp: Fix the order of input device unregistration · 6408eac2
      Takashi Iwai authored
      
      The current code may access to the already freed object.  The input
      device must be accessed and unregistered before freeing the top level
      sound object.
      
      Cc: <stable@vger.kernel.org>
      Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
      6408eac2
    • Oskar Schirmer's avatar
      ASoC: fsl: imx-pcm-fiq: omit fiq counter to avoid harm in unbalanced situations · fc7dc61d
      Oskar Schirmer authored
      
      Unbalanced calls to snd_imx_pcm_trigger() may result in endless
      FIQ activity and thus provoke eternal sound. While on the first glance,
      the switch statement looks pretty symmetric, the SUSPEND/RESUME
      pair is not: the suspend case comes along snd_pcm_suspend_all(),
      which for fsl/imx-pcm-fiq is called only at snd_soc_suspend(),
      but the resume case originates straight from the SNDRV_PCM_IOCTL_RESUME.
      This way userland may provoke an unbalanced resume, which might cause
      the fiq_enable counter to increase and never return to zero again,
      so eventually imx_pcm_fiq is never disabled.
      
      Simply removing the fiq_enable will solve the problem, as long as
      one never goes play and capture game simultaneously, but beware
      trying both at once, the early TRIGGER_STOP will cut off the other
      activity prematurely. So now playing and capturing is scrutinized
      separately, instead of by counting.
      
      Signed-off-by: default avatarOskar Schirmer <oskar@scara.com>
      Signed-off-by: default avatarMark Brown <broonie@linaro.org>
      Cc: stable@vger.kernel.org
      fc7dc61d
  9. Nov 13, 2013
Loading