scsi: core: avoid host-wide host_busy counter for scsi_mq
It isn't necessary to check the host depth in scsi_queue_rq() any more since it has been respected by blk-mq before calling scsi_queue_rq() via getting driver tag. Lots of LUNs may attach to same host and per-host IOPS may reach millions, so we should avoid expensive atomic operations on the host-wide counter in the IO path. This patch implements scsi_host_busy() via blk_mq_tagset_busy_iter() with one scsi command state for reading the count of busy IOs for scsi_mq. It is observed that IOPS is increased by 15% in IO test on scsi_debug (32 LUNs, 32 submit queues, 1024 can_queue, libaio/dio) in a dual-socket system. Cc: Jens Axboe <axboe@kernel.dk> Cc: Ewan D. Milne <emilne@redhat.com> Cc: Omar Sandoval <osandov@fb.com>, Cc: "Martin K. Petersen" <martin.petersen@oracle.com>, Cc: James Bottomley <james.bottomley@hansenpartnership.com>, Cc: Christoph Hellwig <hch@lst.de>, Cc: Kashyap Desai <kashyap.desai@broadcom.com> Cc: Hannes Reinecke <hare@suse.de> Cc: Laurence Oberman <loberman@redhat.com> Cc: Bart Van Assche <bvanassche@acm.org> Link: https://lore.kernel.org/r/20191025065855.6309-1-ming.lei@redhat.com Signed-off-by:Ming Lei <ming.lei@redhat.com> Reviewed-by:
Jens Axboe <axboe@kernel.dk> Reviewed-by:
Bart Van Assche <bvanassche@acm.org> Signed-off-by:
Martin K. Petersen <martin.petersen@oracle.com>
Showing
- drivers/scsi/hosts.c 18 additions, 1 deletiondrivers/scsi/hosts.c
- drivers/scsi/scsi.c 1 addition, 1 deletiondrivers/scsi/scsi.c
- drivers/scsi/scsi_lib.c 22 additions, 23 deletionsdrivers/scsi/scsi_lib.c
- drivers/scsi/scsi_priv.h 1 addition, 1 deletiondrivers/scsi/scsi_priv.h
- include/scsi/scsi_cmnd.h 1 addition, 0 deletionsinclude/scsi/scsi_cmnd.h
- include/scsi/scsi_host.h 1 addition, 2 deletionsinclude/scsi/scsi_host.h
Loading
Please register or sign in to comment