blk: replace bioset_create_nobvec() with a flags arg to bioset_create()
"flags" arguments are often seen as good API design as they allow easy extensibility. bioset_create_nobvec() is implemented internally as a variation in flags passed to __bioset_create(). To support future extension, make the internal structure part of the API. i.e. add a 'flags' argument to bioset_create() and discard bioset_create_nobvec(). Note that the bio_split allocations in drivers/md/raid* do not need the bvec mempool - they should have used bioset_create_nobvec(). Suggested-by:Christoph Hellwig <hch@infradead.org> Reviewed-by:
Christoph Hellwig <hch@infradead.org> Reviewed-by:
Ming Lei <ming.lei@redhat.com> Signed-off-by:
NeilBrown <neilb@suse.com> Signed-off-by:
Jens Axboe <axboe@kernel.dk>
Showing
- block/bio.c 22 additions, 38 deletionsblock/bio.c
- block/blk-core.c 1 addition, 1 deletionblock/blk-core.c
- drivers/block/drbd/drbd_main.c 1 addition, 1 deletiondrivers/block/drbd/drbd_main.c
- drivers/md/bcache/super.c 2 additions, 2 deletionsdrivers/md/bcache/super.c
- drivers/md/dm-crypt.c 1 addition, 1 deletiondrivers/md/dm-crypt.c
- drivers/md/dm-io.c 1 addition, 1 deletiondrivers/md/dm-io.c
- drivers/md/dm.c 1 addition, 1 deletiondrivers/md/dm.c
- drivers/md/md.c 1 addition, 1 deletiondrivers/md/md.c
- drivers/md/raid1.c 1 addition, 1 deletiondrivers/md/raid1.c
- drivers/md/raid10.c 1 addition, 1 deletiondrivers/md/raid10.c
- drivers/md/raid5-cache.c 1 addition, 1 deletiondrivers/md/raid5-cache.c
- drivers/md/raid5-ppl.c 1 addition, 1 deletiondrivers/md/raid5-ppl.c
- drivers/md/raid5.c 1 addition, 1 deletiondrivers/md/raid5.c
- drivers/target/target_core_iblock.c 1 addition, 1 deletiondrivers/target/target_core_iblock.c
- fs/block_dev.c 1 addition, 1 deletionfs/block_dev.c
- fs/btrfs/extent_io.c 2 additions, 1 deletionfs/btrfs/extent_io.c
- fs/xfs/xfs_super.c 2 additions, 1 deletionfs/xfs/xfs_super.c
- include/linux/bio.h 4 additions, 2 deletionsinclude/linux/bio.h
Loading
Please register or sign in to comment