Skip to content
Snippets Groups Projects
  1. Nov 12, 2023
  2. Nov 09, 2023
  3. Nov 08, 2023
  4. Nov 07, 2023
  5. Nov 05, 2023
  6. Nov 04, 2023
  7. Nov 03, 2023
  8. Oct 29, 2023
  9. Oct 28, 2023
  10. Oct 14, 2023
  11. Oct 09, 2023
    • Jan Palus's avatar
    • Biswapriyo Nath's avatar
      Fix missing sentinel warning with clang · 157c16b0
      Biswapriyo Nath authored
      This fixes the compiler warnings similar as following.
      
      ../src/update-mime-database.cpp:393:50: warning: missing sentinel in function call [-Wsentinel]
        393 |                         g_strconcat(namespaceURI, " ", localName, NULL),
            |                                                                       ^
            |                                                                       , nullptr
      157c16b0
    • Tobias Mayer's avatar
      Fix false positive fdatasync detection on darwin · 7499ac1a
      Tobias Mayer authored
      The `has_function` feature in meson uses different detection methods
      depending on the contents of the `prefix` kwarg [1]:
      
       * if it contains `#include` directives it will copy the prefix into
         the test code and check if it compiles
       * if it doesn't contain an include or isn't specified, `has_function`
         will forward declare the function and test for it's existence by
         trying to link it to the default libraries
      
      The latter approach wrongly succeeds for `fdatasync` on darwin because
      the linker binds the function to a system call of the same name. Note
      that this result really is wrong because that system call has not
      the expected semantics of `fdatasync`.
      
      By adding an include for `unistd.h` we can get meson to use the
      first approach and the detection fails.
      
      Note that this has gone unnoticed so far because only recent versions
      of clang (the default compiler on darwin) started to treat implicit
      function declarations as an error.
      
      [1] https://github.com/mesonbuild/meson/blob/583d2815d1a130227f0f4db47e4ab2e80ebb6a61/mesonbuild/compilers/mixins/clike.py#L839-L846
      
      Fixes #211
      7499ac1a
  12. Oct 08, 2023
  13. Oct 07, 2023
Loading