Skip to content
Snippets Groups Projects
Commit 87876aa6 authored by Paul Moore's avatar Paul Moore Committed by Tom Hromatka
Browse files

tests: only use bogus syscall numbers in test 29


The goal of test 29 is to test bogus negative syscall numbers,
unfortunately it appears our choice of syscalls was not bogus on all
the architectures we support.  This commit fixes that by picking a
syscall number well outside the pseudo-syscall/PNR range and removing
the sysmips(2) syscall from the test so as to not cause problems
at a later date.

Signed-off-by: default avatarPaul Moore <paul@paul-moore.com>
Signed-off-by: default avatarTom Hromatka <tom.hromatka@oracle.com>
parent 2847f10d
No related branches found
No related tags found
No related merge requests found
......@@ -49,15 +49,8 @@ int main(int argc, char *argv[])
if (rc < 0)
goto out;
/* SCMP_SYS(sysmips) == 4294957190 (unsigned) */
rc = seccomp_rule_add(ctx, SCMP_ACT_KILL, SCMP_SYS(sysmips), 0);
if (rc < 0)
goto out;
rc = seccomp_rule_add_exact(ctx, SCMP_ACT_KILL, SCMP_SYS(sysmips), 0);
if (rc == 0)
goto out;
/* -10001 == 4294957295 (unsigned) */
rc = seccomp_rule_add_exact(ctx, SCMP_ACT_KILL, -10001, 0);
/* -100001 == 4294867295 (unsigned) */
rc = seccomp_rule_add_exact(ctx, SCMP_ACT_KILL, -100001, 0);
if (rc == 0)
goto out;
......
......@@ -32,13 +32,8 @@ def test(args):
f = SyscallFilter(ALLOW)
f.remove_arch(Arch())
f.add_arch(Arch("x86"))
f.add_rule(KILL, "sysmips")
try:
f.add_rule_exactly(KILL, "sysmips")
except RuntimeError:
pass
try:
f.add_rule_exactly(KILL, -10001)
f.add_rule_exactly(KILL, -100001)
except RuntimeError:
pass
return f
......
......@@ -9,8 +9,7 @@ test type: bpf-sim
# Testname Arch Syscall Arg0 Arg1 Arg2 Arg3 Arg4 Arg5 Result
29-sim-pseudo_syscall +x86 0-10 N N N N N N ALLOW
29-sim-pseudo_syscall +x86 4294957190 N N N N N N ALLOW
29-sim-pseudo_syscall +x86 4294957295 N N N N N N ALLOW
29-sim-pseudo_syscall +x86 4294867295 N N N N N N ALLOW
test type: bpf-valgrind
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment