docs: kernel_feat.py: fix potential command injection
The kernel-feat directive passes its argument straight to the shell. This is unfortunate and unnecessary. Let's always use paths relative to $srctree/Documentation/ and use subprocess.check_call() instead of subprocess.Popen(shell=True). This also makes the code shorter. This is analogous to commit 3231dd58 ("docs: kernel_abi.py: fix command injection") where we did exactly the same thing for kernel_abi.py, somehow I completely missed this one. Link: https://fosstodon.org/@jani/111676532203641247 Reported-by:Jani Nikula <jani.nikula@intel.com> Signed-off-by:
Vegard Nossum <vegard.nossum@oracle.com> Cc: stable@vger.kernel.org Signed-off-by:
Jonathan Corbet <corbet@lwn.net> Link: https://lore.kernel.org/r/20240110174758.3680506-1-vegard.nossum@oracle.com
Showing
- Documentation/admin-guide/features.rst 1 addition, 1 deletionDocumentation/admin-guide/features.rst
- Documentation/arch/arc/features.rst 1 addition, 1 deletionDocumentation/arch/arc/features.rst
- Documentation/arch/arm/features.rst 1 addition, 1 deletionDocumentation/arch/arm/features.rst
- Documentation/arch/arm64/features.rst 1 addition, 1 deletionDocumentation/arch/arm64/features.rst
- Documentation/arch/loongarch/features.rst 1 addition, 1 deletionDocumentation/arch/loongarch/features.rst
- Documentation/arch/m68k/features.rst 1 addition, 1 deletionDocumentation/arch/m68k/features.rst
- Documentation/arch/mips/features.rst 1 addition, 1 deletionDocumentation/arch/mips/features.rst
- Documentation/arch/nios2/features.rst 1 addition, 1 deletionDocumentation/arch/nios2/features.rst
- Documentation/arch/openrisc/features.rst 1 addition, 1 deletionDocumentation/arch/openrisc/features.rst
- Documentation/arch/parisc/features.rst 1 addition, 1 deletionDocumentation/arch/parisc/features.rst
- Documentation/arch/powerpc/features.rst 1 addition, 1 deletionDocumentation/arch/powerpc/features.rst
- Documentation/arch/riscv/features.rst 1 addition, 1 deletionDocumentation/arch/riscv/features.rst
- Documentation/arch/s390/features.rst 1 addition, 1 deletionDocumentation/arch/s390/features.rst
- Documentation/arch/sh/features.rst 1 addition, 1 deletionDocumentation/arch/sh/features.rst
- Documentation/arch/sparc/features.rst 1 addition, 1 deletionDocumentation/arch/sparc/features.rst
- Documentation/arch/x86/features.rst 1 addition, 1 deletionDocumentation/arch/x86/features.rst
- Documentation/arch/xtensa/features.rst 1 addition, 1 deletionDocumentation/arch/xtensa/features.rst
- Documentation/sphinx/kernel_feat.py 11 additions, 44 deletionsDocumentation/sphinx/kernel_feat.py
- Documentation/translations/zh_CN/arch/loongarch/features.rst 1 addition, 1 deletionDocumentation/translations/zh_CN/arch/loongarch/features.rst
- Documentation/translations/zh_CN/arch/mips/features.rst 1 addition, 1 deletionDocumentation/translations/zh_CN/arch/mips/features.rst
Loading
Please register or sign in to comment