Skip to content
Snippets Groups Projects
Commit bd915ae7 authored by Martin Blumenstingl's avatar Martin Blumenstingl Committed by Neil Armstrong
Browse files

drm/meson: Don't remove bridges which are created by other drivers


Stop calling drm_bridge_remove() for bridges allocated/managed by other
drivers in the remove paths of meson_encoder_{cvbs,dsi,hdmi}.
drm_bridge_remove() unregisters the bridge so it cannot be used
anymore. Doing so for bridges we don't own can lead to the video
pipeline not being able to come up after -EPROBE_DEFER of the VPU
because we're unregistering a bridge that's managed by another driver.
The other driver doesn't know that we have unregistered it's bridge
and on subsequent .probe() we're not able to find those bridges anymore
(since nobody re-creates them).

This fixes probe errors on Meson8b boards with the CVBS outputs enabled.

Fixes: 09847723 ("drm/meson: remove drm bridges at aggregate driver unbind time")
Fixes: 42dcf15f ("drm/meson: add DSI encoder")
Cc:  <stable@vger.kernel.org>
Reported-by: default avatarSteve Morvai <stevemorvai@hotmail.com>
Signed-off-by: default avatarMartin Blumenstingl <martin.blumenstingl@googlemail.com>
Reviewed-by: Neil Armstrong's avatarNeil Armstrong <neil.armstrong@linaro.org>
Tested-by: default avatarSteve Morvai <stevemorvai@hotmail.com>
Link: https://lore.kernel.org/r/20240215220442.1343152-1-martin.blumenstingl@googlemail.com


Reviewed-by: Neil Armstrong's avatarNeil Armstrong <neil.armstrong@linaro.org>
Signed-off-by: Neil Armstrong's avatarNeil Armstrong <neil.armstrong@linaro.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20240215220442.1343152-1-martin.blumenstingl@googlemail.com
parent 65323796
No related branches found
No related tags found
No related merge requests found
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment