Skip to content
Snippets Groups Projects
Commit 12bc1494 authored by Peter Rashleigh's avatar Peter Rashleigh Committed by Andrew Lunn
Browse files

net: dsa: mv88e6xxx: Fix error when setting port policy on mv88e6393x


mv88e6393x_port_set_policy doesn't correctly shift the ptr value when
converting the policy format between the old and new styles, so the
target register ends up with the ptr being written over the data bits.

Shift the pointer to align with the format expected by
mv88e6393x_port_policy_write().

Fixes: 6584b260 ("net: dsa: mv88e6xxx: implement .port_set_policy for Amethyst")
Signed-off-by: default avatarPeter Rashleigh <peter@rashleigh.ca>
Reviewed-by: default avatarSimon Horman <horms@kernel.org>
Message-ID: <20241016040822.3917-1-peter@rashleigh.ca>
Signed-off-by: default avatarAndrew Lunn <andrew@lunn.ch>
parent eb592008
No related merge requests found
......@@ -1713,6 +1713,7 @@ int mv88e6393x_port_set_policy(struct mv88e6xxx_chip *chip, int port,
ptr = shift / 8;
shift %= 8;
mask >>= ptr * 8;
ptr <<= 8;
err = mv88e6393x_port_policy_read(chip, port, ptr, &reg);
if (err)
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment