net: bcmgenet: synchronize UMAC_CMD access
The UMAC_CMD register is written from different execution contexts and has insufficient synchronization protections to prevent possible corruption. Of particular concern are the acceses from the phy_device delayed work context used by the adjust_link call and the BH context that may be used by the ndo_set_rx_mode call. A spinlock is added to the driver to protect contended register accesses (i.e. reg_lock) and it is used to synchronize accesses to UMAC_CMD. Fixes: 1c1008c7 ("net: bcmgenet: add main driver file") Cc: stable@vger.kernel.org Signed-off-by:Doug Berger <opendmb@gmail.com> Acked-by:
Florian Fainelli <florian.fainelli@broadcom.com> Signed-off-by:
David S. Miller <davem@davemloft.net>
Showing
- drivers/net/ethernet/broadcom/genet/bcmgenet.c 11 additions, 1 deletiondrivers/net/ethernet/broadcom/genet/bcmgenet.c
- drivers/net/ethernet/broadcom/genet/bcmgenet.h 3 additions, 1 deletiondrivers/net/ethernet/broadcom/genet/bcmgenet.h
- drivers/net/ethernet/broadcom/genet/bcmgenet_wol.c 7 additions, 1 deletiondrivers/net/ethernet/broadcom/genet/bcmgenet_wol.c
- drivers/net/ethernet/broadcom/genet/bcmmii.c 2 additions, 0 deletionsdrivers/net/ethernet/broadcom/genet/bcmmii.c
Loading
Please register or sign in to comment