Skip to content
Snippets Groups Projects
Commit f47188d5 authored by Pierre-Louis Bossart's avatar Pierre-Louis Bossart Committed by Madhulika Dolke
Browse files

UPSTREAM: ASoC: soc-pcm: test refcount before triggering


On start/pause_release/resume, when more than one FE is connected to
the same BE, it's possible that the trigger is sent more than
once. This is not desirable, we only want to trigger a BE once, which
is straightforward to implement with a refcount.

For stop/pause/suspend, the problem is more complicated: the check
implemented in snd_soc_dpcm_can_be_free_stop() may fail due to a
conceptual deadlock when we trigger the BE before the FE. In this
case, the FE states have not yet changed, so there are corner cases
where the TRIGGER_STOP is never sent - the dual case of start where
multiple triggers might be sent.

This patch suggests an unconditional trigger in all cases, without
checking the FE states, using a refcount protected by the BE PCM
stream lock.

Signed-off-by: default avatarPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: default avatarKai Vehmanen <kai.vehmanen@linux.intel.com>
Reviewed-by: default avatarBard Liao <yung-chuan.liao@linux.intel.com>
Reviewed-by: default avatarRanjani Sridharan <ranjani.sridharan@linux.intel.com>
Link: https://lore.kernel.org/r/20211207173745.15850-6-pierre-louis.bossart@linux.intel.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>

BUG=b:218766331
TEST=Test sound cards are listed and audio playback works.

Signed-off-by: default avatarTerry Cheong <htcheong@chromium.org>
Signed-off-by: default avatarMadhulika Dolke <madhulika.dolke@intel.com>
(cherry picked from commit 848aedfd)
Change-Id: Iee94cae20e002d4451641ed6cd65d129a81dabae
parent 8b1b7aa0
No related branches found
No related tags found
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment