UPSTREAM: ASoC: soc-pcm: Move debugfs removal out of spinlock
The recent fix for DPCM locking also covered the loop in dpcm_be_disconnect() with the FE stream lock. This caused an unexpected side effect, thought: calling debugfs_remove_recursive() in the spinlock may lead to lockdep splats as the code there assumes the SOFTIRQ-safe context. For avoiding the problem, this patch changes the disconnection procedure to two phases: at first, the matching entries are removed from the linked list, then the resources are freed outside the lock. Fixes: b7898396 ("ASoC: soc-pcm: Fix and cleanup DPCM locking") Reported-and-tested-by:Marek Szyprowski <m.szyprowski@samsung.com> Signed-off-by:
Takashi Iwai <tiwai@suse.de> Link: https://lore.kernel.org/r/20220119155249.26754-3-tiwai@suse.de Signed-off-by:
Mark Brown <broonie@kernel.org> (cherry picked from commit 9f620684) BUG=b:218766331 TEST=Test sound cards are listed and audio playback works. Signed-off-by:
Terry Cheong <htcheong@chromium.org> Signed-off-by:
Madhulika Dolke <madhulika.dolke@intel.com> Change-Id: I33dfc6d50417b663a510fc0384b863e278d3d1b0
Loading
Please register or sign in to comment