Skip to content
Snippets Groups Projects
Select Git revision
  • aosp-new/busytown-mac-infra-release
  • aosp-new/sdk-release
  • aosp-new/build-tools-release
  • aosp-new/mirror-goog-main-external
  • aosp-new/main
  • aosp-new/master
  • aosp-new/upstream-master
  • aosp-new/emu-dev
  • aosp-new/simpleperf-release
  • ks-aosp.lnx.15.0.r1-rel
  • aosp-new/emu-35-4-release
  • aosp-new/emu-35-4-dev
  • aosp-new/emu-35-5-dev
  • aosp-new/emu-35-5-release
  • aosp-new/emu-35-6-release
  • aosp-new/emu-master-dev
  • aosp-new/android15-qpr2-release
  • aosp-new/android15-qpr2-s1-release
  • aosp-new/android15-qpr2-s2-release
  • aosp-new/studio-2024.3.1
  • LA.QSSI.14.0.r1-20100-qssi.0
  • aml_tz6_351400020
  • aml_tz4_334103000
  • aml_tz5_342903000
  • aml_tz3_315301000
  • aml_tz2_306503000
  • q_tzdata_aml_297701000
  • aml_mpr_351416060
  • aml_ext_351423040
  • aml_tet_351415080
  • aml_per_351410020
  • aml_hef_351420080
  • aml_art_351410020
  • aml_net_351410060
  • aml_wif_351410040
  • aml_con_351412000
  • aml_sta_351416000
  • aml_sdk_351415000
  • aml_ase_351412000
  • aml_odp_351421000
40 results
Search by author
  • Any Author
  • 72162444 72162444 72162444 72162444 gaochangning
  • Aakash Dave Aakash Dave aakash.dave
  • Aaron Kim Aaron Kim akim
  • Aaron Kloc Aaron Kloc akloc
  • Aaron Lan Aaron Lan aaron.lan
  • Aaron Nabil Aaron Nabil aaronna
  • Aaron Pohle Aaron Pohle aaron.pohle
  • Abbott Chung Abbott Chung chung.abbott
  • Abdallah Omar Abdallah Omar abdallah_omar
  • Abdessamii Chalbi Abdessamii Chalbi abdessamii.chalbi
  • Abdul Hussain Sirajudeen Abdul Hussain Sirajudeen abdul.hussain
  • Abdullah Alghamdi Abdullah Alghamdi a.alghamdi
  • Abdullah Elmarghany Abdullah Elmarghany abdullah_elmarghany
  • Abel Fang Abel Fang abel_fang
  • Abhijeet Badurkar Abhijeet Badurkar abhijeet.badurkar
  • Abhijit Adsule Abhijit Adsule adsule
  • Abhijit Murthy Abhijit Murthy abhijit
  • Abhi Khanal Abhi Khanal akhanal
  • Abhilash Sahoo Abhilash Sahoo abhilashsahoo
  • Abhimanyu Raj Abhimanyu Raj abhimanyu.raj
20 authors
  1. Sep 08, 2022
    • Spandan Das's avatar
      Declare the headers of the ndk_library · e510bd17
      Spandan Das authored 
      This creates a dependency edge between the ndk_library and its headers,
which should be a no-op in regular Soong builds. This dependency edge
will be used in the Multi-tree project to export the relevant .h files into a well
known location

Test: m nothing
Bug: 239044713
Change-Id: I353794e005f69dc349ad15db47c8881dd506dff2
      e510bd17
  3. Aug 15, 2022
  5. Aug 12, 2022
    • Chih-Hung Hsieh's avatar
      Suppress deprecated-non-prototype warnings · 8a7aa16a
      Chih-Hung Hsieh authored 
      * Reduce number of warnings in a default global build.
* They should be fixed before AOSP upgrade to C2x.

Bug: 239661264
Bug: 241601211
Test: presubmit
Change-Id: I76ccfe11af97c51802b60b68f4fb125b99a02d4e
      8a7aa16a
  7. Jun 29, 2022
  9. Jun 28, 2022
  11. May 31, 2022
  13. May 23, 2022
    • Adenilson Cavalcanti's avatar
      Revert "[zlib] Adding PMULL based CRC-32 for aarch64" · 0e6b3ca1
      Adenilson Cavalcanti authored 
      This reverts commit a0771caebe87477558454cc6d793562e3afe74ac.

Reason for revert: Missing call to CPU features detection

Original change's description:
> [zlib] Adding PMULL based CRC-32 for aarch64
>
> Using the polynomial multiplication instruction allows to improve a bit
> more the decompression speed of gzipped content in zlib.
>
> The average gains are not massive though (around +4.9%), but is more expressive
> for some relevant content (e.g. +10% for HTMLx4 & JPEG, +6% for JS) in more
> recent chip designs.
>
> Since Chrome is distributed as a 64bit binary (i.e. aarch64) only for
> higher end devices, it should be safe from a performance perspective.
>
> For lower spec devices, the same serial crc32 code using the crypto
> extensions is used, therefore no change on behavior for 32bit.
>
> Bug: 873725
> Change-Id: I33b9b345b82b5256ec922324984f9a371949bbe6
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422723


> Reviewed-by: default avatarChris Blume <cblume@chromium.org>
> Commit-Queue: Adenilson Cavalcanti <cavalcantii@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1006184}

Bug: 873725
Change-Id: I7b6a2bfb60a96bc640b59187c5dd63590d09599e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3659852


Reviewed-by: default avatarNoel Gordon <noel@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1006331}
NOKEYCHECK=True
GitOrigin-RevId: 42a820acf433146b284bb195b0c3507244cf1c30
      0e6b3ca1
  15. May 22, 2022
    • Adenilson Cavalcanti's avatar
      [zlib] Adding PMULL based CRC-32 for aarch64 · 80b28c99
      Adenilson Cavalcanti authored 
      Using the polynomial multiplication instruction allows to improve a bit
more the decompression speed of gzipped content in zlib.

The average gains are not massive though (around +4.9%), but is more expressive
for some relevant content (e.g. +10% for HTMLx4 & JPEG, +6% for JS) in more
recent chip designs.

Since Chrome is distributed as a 64bit binary (i.e. aarch64) only for
higher end devices, it should be safe from a performance perspective.

For lower spec devices, the same serial crc32 code using the crypto
extensions is used, therefore no change on behavior for 32bit.

Bug: 873725
Change-Id: I33b9b345b82b5256ec922324984f9a371949bbe6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422723


Reviewed-by: default avatarChris Blume <cblume@chromium.org>
Commit-Queue: Adenilson Cavalcanti <cavalcantii@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1006184}
NOKEYCHECK=True
GitOrigin-RevId: a0771caebe87477558454cc6d793562e3afe74ac
      80b28c99
  17. May 18, 2022
  19. May 17, 2022
  21. May 15, 2022
    • Noel Gordon's avatar
      [zlib_bench] check deflate consumed all input · 7085d03b
      Noel Gordon authored 
      zlib_compress deflate() should consume all the input data. Add a check
and fail the deflation if there is unconsumed input data when the zlib deflate() call returns.

What about inflate()? zlib_bench knows the expected length of the data
(it is the original input length) and fails with a Z_DATA_ERROR if the zlib_uncompress inflate() output data length does not match.

Bug: 798943
Change-Id: Ibdc9752754a52343ea6139ce9cc5a99c2a0a57a7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3630105


Auto-Submit: Noel Gordon <noel@chromium.org>
Reviewed-by: default avatarChris Blume <cblume@chromium.org>
Commit-Queue: Chris Blume <cblume@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1003565}
NOKEYCHECK=True
GitOrigin-RevId: 4cc4f4c0086c2e5ad52bff6be7e2430b72ebcba9
      7085d03b
  23. May 13, 2022
  25. May 12, 2022
  27. May 03, 2022
  29. May 02, 2022
  31. Apr 30, 2022
    • Noel Gordon's avatar
      [zlib bench] Add script to run zlib_bench --check[-binary] files ... · 961141d1
      Noel Gordon authored 
      Given an input file corpus, run zlib_bench --check[-binary] over those
files and output the results to stdout.

Bug: 798943,1316541
Change-Id: If99ea34af7f05698e8cea1dc3ca7e548b9f9d1bc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3614630


Reviewed-by: default avatarAdenilson Cavalcanti <cavalcantii@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Auto-Submit: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/main@{#998063}
NOKEYCHECK=True
GitOrigin-RevId: 25ee43caf00528cee12f4d10c6202766ebe0afe7
      961141d1
    • Noel Gordon's avatar
      [zlib][asop] Complete USE_ZLIB_RABIN_KARP_ROLLING_HASH feature · 27c2f474
      Noel Gordon authored 
      If USE_ZLIB_RABIN_KARP_ROLLING_HASH build-time option is defined, use
the Rabin-Karp hash. This disables CRC SIMD hashing on ARM and Intel,
which will degrade compression speed.

However, the compressed output matches canonical zlib output, for the
same input, and that should resolve ASOP OTA issue 1316541.

To ensure the Rabin-Karp hash is used correctly in chromium zlib, the
first step is to go back to using canonical fill_window(). To do this
combine the ARM NEON and Intel SSE2 slide_hash() routines in a common
framework called slide_hash_simd(). Remove fill_window_sse.c and undo
deflate_read_buf() rename: name it back to canonical read_buf().

Change insert_string(): by default it uses CRC32C hashes on all ports
(ARM, Intel) so add code comments to state that. If Rabin-Karp hashes
are enabled, disable CRC32C hashes.

Add a new deflate internal state variable chromium_zlib_hash, used to
detect which type of hashing is enabled (Rabin-Karp, CRC32C). Set the
state variable in deflateInit2_ after cpu_check_features() detection,
with #ifdef guards matching the #ifdef logic of insert_string().

Change canonical fill_window() to insert hashes into {hash,prev} hash
chains based on hash type (Rabin-Karp, CRC32C). Prior to this change,
the ARM port was inserting Rabin-Karp hashes into hash chains even if
CRC32 hashing was active when s->insert was > 0.

Change longest_match() and deflate_fast(): update them to use the new
deflate state variable chromium_zlib_hash.

Compression performance degrades when Rabin-Karp hashing is used, but
is unchanged when CRC32C hashing is enabled (chromium zlib default).

Compat: if Rabin-Karp hashing is enabled, zlib-bench --check built as normal and against canonical zlib 1.2.11, produce the same compressed output for the snappy corpora for gzip,zlib,raw types and compression levels 1..9.

Bug: 1316541
Change-Id: I0d5ee6240f0b7eac4653d60a29d459d994c3871f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3596671


Reviewed-by: default avatarChris Blume <cblume@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Reviewed-by: default avatarAdenilson Cavalcanti <cavalcantii@chromium.org>
Cr-Commit-Position: refs/heads/main@{#998062}
NOKEYCHECK=True
GitOrigin-RevId: 2bd100e46361a459b41a29212ea8f97a4837a06c
      27c2f474
    • Noel Gordon's avatar
      [zlib bench] Add check option modifier --check-binary · 61174f4f
      Noel Gordon authored 
      Per CL:3591994 if the --check option is given, compress the input file
and output the length and crc32 of the compressed data.

Add check option modifier: --check-binary, which writes the compressed
data to the output as well.

Also normalize the check output compression details: use the base-name
of the input file, instead of its full-path name.

Bug: 798943,1316541
Change-Id: Ia27f09b1ad583bda8e9c82c62a5b24b619f6713a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3616433


Commit-Queue: Noel Gordon <noel@chromium.org>
Auto-Submit: Noel Gordon <noel@chromium.org>
Reviewed-by: default avatarAdenilson Cavalcanti <cavalcantii@chromium.org>
Commit-Queue: Adenilson Cavalcanti <cavalcantii@chromium.org>
Cr-Commit-Position: refs/heads/main@{#998055}
NOKEYCHECK=True
GitOrigin-RevId: 5ae6f05e848868027ac1a78f191c4a43919e8c94
      61174f4f
  33. Apr 29, 2022
    • Adenilson Cavalcanti's avatar
      [zlib] Re-sync with zlib 1.2.12, patch 15 of N · e28c5403
      Adenilson Cavalcanti authored 
      The last two changes came from the 'develop' branch of canonical
zlib and should address some issues on 1.2.12 that are going to
be featured on the upcoming 1.2.12.x.

With this patch landing, Chromium's zlib will be 1.2.12 + fixes
(plus our optimizations).

Ported:
 - Eliminate use of ULL constants.
 - Fix crc32.c to compile local functions only if used.
 - zlib 1.2.12
 - Silence some warnings from Visual Studio C.
 - Correct incorrect inputs provided to the CRC functions.

Bug: 1032721
Change-Id: I3903ae4de5f42427fae1cca8052ad300f5a07b30
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3611239


Commit-Queue: Adenilson Cavalcanti <cavalcantii@chromium.org>
Reviewed-by: default avatarChris Blume <cblume@chromium.org>
Reviewed-by: default avatarNoel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/main@{#997532}
NOKEYCHECK=True
GitOrigin-RevId: 9eb3d1c886a4dd302304241e74a75127e2069d17
      e28c5403
  35. Apr 28, 2022
  37. Apr 27, 2022
  39. Apr 26, 2022
  41. Apr 25, 2022
  43. Apr 22, 2022
  45. Apr 21, 2022
  47. Apr 20, 2022
  49. Apr 19, 2022
    • Noel Gordon's avatar
      [zlib_bench] Add compressed data integrity --check option · be2c3787
      Noel Gordon authored 
      If --check option is given, compress the input file. Report the length
of the compresssed data, and the crc32 of the compressed data.

For the GZIP and ZLIB DEFLATE stream types, also report the data those
stream types [1] store at the end of the compressed data.

Add the --check option to program usage message. Also change the usage
message to always report the zlib verion number.

[1] See RFC-1952 GZIP, RFC 1950 ZLIB.

Bug: 798943,1316541
Change-Id: Id9d5a918b3ae142077d654f82ca6c9bd40762cfe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3591994


Auto-Submit: Noel Gordon <noel@chromium.org>
Reviewed-by: default avatarAdenilson Cavalcanti <cavalcantii@chromium.org>
Commit-Queue: Adenilson Cavalcanti <cavalcantii@chromium.org>
Cr-Commit-Position: refs/heads/main@{#993581}
NOKEYCHECK=True
GitOrigin-RevId: ce61cdae957433ff9955863b07826f0d6fdc9f3c
      be2c3787
  51. Apr 11, 2022