Select Git revision
Search by author
- Any Author
- authors
-
72162444 72162444 gaochangning
-
Aakash Dave aakash.dave
-
Aaron Kim akim
-
Aaron Kloc akloc
-
Aaron Lan aaron.lan
-
Aaron Nabil aaronna
-
Aaron Pohle aaron.pohle
-
Abbott Chung chung.abbott
-
Abdallah Omar abdallah_omar
-
Abdessamii Chalbi abdessamii.chalbi
-
Abdul Hussain Sirajudeen abdul.hussain
-
Abdullah Alghamdi a.alghamdi
-
Abdullah Elmarghany abdullah_elmarghany
-
Abel Fang abel_fang
-
Abhijeet Badurkar abhijeet.badurkar
-
Abhijit Adsule adsule
-
Abhijit Murthy abhijit
-
Abhi Khanal akhanal
-
Abhilash Sahoo abhilashsahoo
-
Abhimanyu Raj abhimanyu.raj
- Apr 15, 2019
-
-
Richard Townsend authored
Fixes a failing GN assertion for Windows on Arm as it uses a separate path to check CRC32 extension support, so no OS-specific defines are needed. Bug: 810125 Change-Id: I172b4ecd66d94d195f1ccac4c6108ea2a40972a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1567678 Commit-Queue: Adenilson Cavalcanti <cavalcantii@chromium.org> Commit-Queue: Richard Townsend <richard.townsend@arm.com> Reviewed-by:
Adenilson Cavalcanti <cavalcantii@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#651040} Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src Cr-Mirrored-Commit: 38bf6e359de031ec11566e446d6f7bbcd4dfc9d6
-
Noel Gordon authored
Add OS_FUCHSIA ARM CPU feature detection and enable the crc32 feature on the ARM version of Fuchsia (which is aarch64 only, FTR). For perf, see the results crbug.com/810125/#c17 .. crbug.com/810125/#c19. Add BUILD.gn asserts in the ARM crc32 feature rules: to vet any build expectations (e.g., that the android NDK is installed on is_android), or cause gn errors if the ARM OS type is not supported. Bug: 810125 Change-Id: Id6759d4c6142924c09c591b61117dca529955175 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1472990 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#650712} Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src Cr-Mirrored-Commit: c96f4c5c7a0cdaf823373c4bb417978b8321ffb2
-
- Apr 08, 2019
-
-
Tom Anderson authored
//third_party/zlib currently gets duplicated in 418 DSOs when building 'all'. This CL makes zlib a component so that component builds are a bit smaller/faster. Also rename zlib/names.h to zlib/chromeconf.h and remove it from patch files. BUG=941663 R=thakis Change-Id: I520d7ed30d0cfc322ebf1b9fb31bfbf5469f0209 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1545510 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#648854} Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src Cr-Mirrored-Commit: d7ee2f99fc936f2162a65b9bf087af94646248e8
-
- Mar 29, 2019
-
-
Daniel Rubery authored
Since it's not possible to truncate a file from within a sandbox, we need to track the file size independently, and only consider the first |file_length| bytes of the file. TESTED=Manually, by printing the hashes on chrome://safe-browsing, and verifying they are correct. It's currently impossible to test this automatically, since our unit tests do not run in the sandbox. Bug: 944633 Change-Id: I99c84a69e1ce4d4a08e5bd92d6a1b63e807b0233 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1535258 Reviewed-by:
Satoru Takabayashi <satorux@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#645810} Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src Cr-Mirrored-Commit: 662e1489291632b12980347ba5d9bc77844f6e68
-
- Mar 28, 2019
-
-
Daniel Cheng authored
Bug: 902789 Tbr: agl@chromium.org Tbr: avi@chromium.org Tbr: blundell@chromium.org Tbr: derat@chromium.org Tbr: digit@chromium.org Tbr: marq@chromium.org Tbr: pkasting@chromium.org Tbr: rouslan@chromium.org Tbr: rsesek@chromium.org Tbr: sandersd@chromium.org Tbr: weili@chromium.org Tbr: yuweih@chromium.org Change-Id: I6bb9a5b4be7e52b77af325251dc230fa6f04891d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1544243 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Reviewed-by:
Adam Langley <agl@chromium.org> Reviewed-by:
Yuwei Huang <yuweih@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#645569} Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src Cr-Mirrored-Commit: d07ef716df3130b069bf6ac0ee435c2c4490c285
-
Peter Wen authored
Move the build targets to //third_party/android_sdk. Move files for android_platform into //third_party/android_platform. Tbr for build target renaming. Tbr: thakis@chromium.org Bug: 947060 Change-Id: I1ec7117b042a2bfe22c6dbc7985256465318cab7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1543468 Commit-Queue: Peter Wen <wnwen@chromium.org> Reviewed-by:
-
- Feb 15, 2019
-
-
Noel Gordon authored
Android aarch64 has different PMULL and CRC32 feature values compared to Android aarch32. Rename init_arm_features to _arm_check_features to be consistent with the _MSC_VER code. Add Android aarch64 feature value support. Use the correct return type for the platform feature detectors (getauxval and android_getCpuFeatures). Add comments and a TODO for OS_ZIRCON. Bug: 810125 Change-Id: Ie1526b1d6d3ebeba76d49a83911b335ffce1b288 Reviewed-on: https://chromium-review.googlesource.com/c/1472810 Reviewed-by:
Mike Klein <mtklein@chromium.org> Reviewed-by:
-
- Feb 14, 2019
-
-
Benoît Lizé authored
zlib uses malloc() to allocate temporary data. Unfortunately, on Android, jemalloc (malloc()'s underlying implementation) caches temporary data after free() in a thread-local cache. As renderers don't allocate from malloc() often in background threads, this data is not reclaimed. This increases memory usage by up to 256kiB per background compression thread, which is the cause for a sizable malloc() memory regression from foreground string compression (see linked bug). The deeper reason for the regression is more complex, see details in the linked bug, and https://docs.google.com/document/d/1aRIifaHF5l9relq9vHirTOWt2AZoAkDNqHiYZrWGE9A/edit?usp=sharing It involves some interaction between: - jemalloc implementation and memory accounting - Android's configuration of jemalloc - Chrome's allocation and threading patterns - zlib's allocation patterns Nevertheless, the regression is real, and to mitigate it, use PartitionAlloc to allocate zlib's temporary data. This is not necessary for decompression, as the allocation patterns are not the same, and the main thread doesn't have the same issues. As such, only do it for compression, to avoid a needlessly complex CL. On PartitionAlloc vs malloc(): The only path using partition alloc in this CL in from the renderer process, where it is already widely used. The issue is less likely to appear in the browser process as malloc() is more widely used there, though further investigation may reveal issues. Android vs everywhere: The issue is present at least with jemalloc(), that is Android. However thread caches and arena-allocators are used on other platforms as well, and as the allocation is not performance-sensitive, using PartitionAlloc everwhere makes the code simpler, and protects against potential issues (as we know that this specific issue does not arise with PartitionAlloc). Bug: 931553, 924164 Change-Id: I9e94e9cea5d51fac67b04fdb1681427e57bfbe1f Reviewed-on: https://chromium-review.googlesource.com/c/1472578 Commit-Queue: Benoit L <lizeb@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#632372} Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src Cr-Mirrored-Commit: 5e7e1b1967f6d36206d0f18bcf25d99041bfdc37
-
- Feb 13, 2019
-
-
Noel Gordon authored
The program options handling has grown a little weedy. Add get_options helper. The wrapper (gzip|zlib|raw) is a required arg, not an optional arg, so remove --wrapper. Limit the --compression level to [1-9] since 0 causes compression failure in practice. Use Z_DEFAULT_COMPRESSION if --compression is not given (zlib@6). Make the compression_level static global since it is a program-level constant. Update usage helper. Bug: 798943 Change-Id: I8e19bd029c1163a00a1b6a2a252c1a4e5da1a633 Reviewed-on: https://chromium-review.googlesource.com/c/1460242 Reviewed-by:
Chris Blume <cblume@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#631624} Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src Cr-Mirrored-Commit: 74c7f46559047433d694f20cf574815bfa4cb8a6
-
- Jan 31, 2019
-
-
Adenilson Cavalcanti authored
This enables reading bigger chunks of data in the DEFLATE decoder on aarch64. Basically instead of performing 2x 32-bit loads (i.e. ldrb w22,[x9]) followed by a second write in higher lane of the register (i.e. w23), memcpy will do a 64-bit load to the same register. (i.e. ldr x22, [x9]). This also allows to halve the amount of following operations (i.e. adds and shifts), improving performance in decompression. For JavaScript content the gain was close to 14% in big cores (A72) and 9% for little cores (A53). Bug: 812499 Change-Id: I010604ee62e72a769ce2a7912afb7e334adefacf Reviewed-on: https://chromium-review.googlesource.com/c/1447042 Reviewed-by:
-
- Jan 11, 2019
-
-
Benoît Lizé authored
ParkableString compression allocates a temporary buffer inside GzipCompress using UncheckedMalloc(). From a finch experiment (see bug), there is a statistically significant increase in malloc() footprint on Android, even though the only allocations are temporary. To mitigate the regression, use PartitionAlloc to allocate the temporary data. This changes: - compression_utils.cc: take an external output buffer for compression. - parkable_string.cc: Allocate the temporary buffer with PartitionAlloc, on the buffer partition. Bug: 920194 Change-Id: I57c42f67ea0b09e1ae9137beade4dd0d3c6ef258 Reviewed-on: https://chromium-review.googlesource.com/c/1404083 Reviewed-by:
Benoit L <lizeb@chromium.org> Reviewed-by:
-
- Jan 08, 2019
-
-
Avi Drissman authored
This is purely a mechanical change; there is no intended behavior change. BUG=837308 R=agl@chromium.org Change-Id: I4505d29594dba38102d90f07276afb3828fcf995 Reviewed-on: https://chromium-review.googlesource.com/c/1399517 Commit-Queue: Adam Langley <agl@chromium.org> Reviewed-by:
-
- Jan 02, 2019
-
-
Avi Drissman authored
This is purely a mechanical change; there is no intended behavior change. BUG=837308 R=agl@chromium.org Change-Id: I1d226c45e473949a8af47311a6e089e5d9df10b4 Reviewed-on: https://chromium-review.googlesource.com/c/1392748 Commit-Queue: Adam Langley <agl@chromium.org> Reviewed-by:
-
- Dec 20, 2018
-
-
Monica Salama authored
The uncompressed size might be unreasonable in case the data we uncompress with GzipUncompress does not have the right format or is corrupted which will lead to resize to attempt to throw an exception. The two possible exceptions from resize() are length_error and bad_alloc. In case the exception attempted is length_error (which I assumed based on that the error reported is Xlength_error) checking for std::string::max_size() would avoid such a crash. Bug: 911865 Change-Id: Ida8f845c1334ef0097765d168c19034c6ca00cc0 Reviewed-on: https://chromium-review.googlesource.com/c/1380035 Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Monica Salama <msalama@google.com> Cr-Original-Commit-Position: refs/heads/master@{#618224} Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src Cr-Mirrored-Commit: 322bc779d3bf6945bf646caa437b90fc59e8ff8c
-
- Dec 13, 2018
-
-
Tiancong Wang authored
Using the ARM crc32 instruction can boost the speed of gzip content decompression, which can improve performances in cases where lots of webpages are served using 'content-encoding: gzip'. Expected to have ~50% decompression speed improvement on elm. Bug: 848897, 810125 Change-Id: I9f090950209e6a68271c6926700b7335e14c7cbf Reviewed-on: https://chromium-review.googlesource.com/c/1372548 Commit-Queue: Adenilson Cavalcanti <cavalcantii@chromium.org> Reviewed-by:
-
- Dec 07, 2018
-
-
Mike Klein authored
It's possible to get here while building for ARM64. Change-Id: Icf621059f4cfdec28d71437917ebb348369e6c26 Reviewed-on: https://chromium-review.googlesource.com/c/1368105 Reviewed-by:
Leon Scroggins <scroggo@chromium.org> Commit-Queue: Mike Klein <mtklein@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#614819} Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src Cr-Mirrored-Commit: 6ffae24943b91fd5ad63a5a6bec18c544244877b
-
- Nov 21, 2018
-
-
Benoît Lizé authored
On Windows, malloc() (in Chrome) never returns nullptr, instead triggering an OOM. Explicitly using UncheckedMalloc() to get nullptr in case of allocation failure. Bug: 905777 Change-Id: I56bf677710b606cc6ca69073f4cc2d34c4ef19dd Reviewed-on: https://chromium-review.googlesource.com/c/1344064 Reviewed-by:
-
- Nov 16, 2018
-
-
Benoît Lizé authored
This has two benefits: - Not touching the whole data (as most of it is not written to except for the initial memset() in vector's constructor.) - Allowing to recover from allocation failures. Bug: 905777 Change-Id: I748ec518af8cfc272a8342fdd567d957dbe1fbcc Reviewed-on: https://chromium-review.googlesource.com/c/1339872 Commit-Queue: Benoit L <lizeb@chromium.org> Reviewed-by:
-
- Nov 14, 2018
-
-
Tom Tan authored
Bug: 893460 Change-Id: I69914310f35a1b21159da701447651aba4f1b888 Reviewed-on: https://chromium-review.googlesource.com/c/1334934 Commit-Queue: Tom Tan <Tom.Tan@microsoft.com> Reviewed-by:
-
- Oct 31, 2018
-
-
Daniel Bratell authored
There are some circular include dependencies in the zlib build system because some parts are extracted into their own targets. To make gn check understand that, those targets need to be added to the allow_circular_includes_from list. Bug: 898837 Change-Id: Ic94c5f5ac88e10792b458f4d734c4ad0487023c2 Reviewed-on: https://chromium-review.googlesource.com/c/1299135 Reviewed-by:
-
- Oct 01, 2018
-
-
Daniel Bratell authored
Windows normally defines macros so that FAR expands to far, and far expands to nothing. Angle undefs far, leaving the FAR macro hanging, expanding to far which is not a legal keyword anymore. zlib already tries to handle that someone/something has undefined FAR but it doesn't handle that someone/something has undefined far. This patch changes that. This problem appeared in some jumbo builds in gpu/command_buffer/service which uses both angle and zlib. Bug: 889429 Change-Id: Ia3b10a9a82fc51b302c67b24a19f30a73bdda489 Reviewed-on: https://chromium-review.googlesource.com/1245723 Commit-Queue: Daniel Bratell <bratell@opera.com> Reviewed-by:
-
- Sep 20, 2018
-
-
Mike Klein authored
We noticed recently on the Skia tree that if we build Chromium's zlib with GCC, -O3, -m32, and -msse2, deflateInit2_() crashes. Might also need -fPIC... not sure. I tracked this down to a `movaps` (16-byte aligned store) to an address that was only 8-byte aligned. This address was somewhere in the middle of the deflate_state struct that deflateInit2_()'s job is to initialize. That deflate_state struct `s` is allocated using ZALLOC, which calls any user supplied zalloc if set, or the default if not. Neither one of these has any special alignment contract, so generally they'll tend to be 2*sizeof(void*) aligned. On 32-bit builds, that's 8-byte aligned. But because we've annotated crc0 as zalign(16), the natural alignment of the whole struct is 16-byte, and a compiler like GCC can feel free to use 16-byte aligned stores to parts of the struct that are 16-byte aligned, like the beginning, crc0, or any other part before or after crc0 that happens to fall on a 16-byte boundary. With -O3 and -msse2, GCC does exactly that, writing a few of the fields with one 16-byte store. The fix is simply to remove zalign(16). All the code that manipulates this field was actually already using unaligned loads and stores. You can see it all right at the top of crc_folding.c, CRC_LOAD and CRC_SAVE. This bug comes from the Intel performance patches we landed a few years ago, and isn't present in upstream zlib, Android's zlib, or Google's internal zlib. It doesn't seem to be tickled by Clang, and won't happen on 64-bit GCC builds: zalloc is likely 16-byte aligned there. I _think_ it's possible for it to trigger on non-x86 32-bit builds with GCC, but haven't tested that. I also have not tested MSVC. The moved comment is entirely to appease git cl format. Change-Id: Ie2d8eb9ddefa1e35e6d21ee4b29797f6949b0687 Reviewed-on: https://chromium-review.googlesource.com/1236613 Reviewed-by:
-
- Sep 04, 2018
-
-
Benoit Lize authored
Bug: 877044 Change-Id: I193aec9eaf8e0f59413b4b0c58489aeac48b5ad2 Reviewed-on: https://chromium-review.googlesource.com/1202143 Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
-
- Aug 23, 2018
-
-
George Burgess IV authored
ThinLTO emits warnings when linking modules with different target triples. Android uses armv7-a as its default triple, so the mixing with armv8-a here is problematic. Bug: 807147 Test: md5sum <(objdump -d crc32_simd.o) is the same for Android. Change-Id: If2bffc4090d3d94f158eea80d19ee9eb827fc837 Reviewed-on: https://chromium-review.googlesource.com/1147867 Commit-Queue: George Burgess <gbiv@chromium.org> Reviewed-by:
-
- Aug 22, 2018
-
-
Daniel Rubery authored
Currently, an encrypted file will simply fail to extract. It is useful for SafeBrowsing to be able to indicate that the file is encrypted, instead of malformed. Bug: 874621 Change-Id: Ie0b2448b0fd2340c554351d1131baa3854a73e44 Reviewed-on: https://chromium-review.googlesource.com/1176558 Reviewed-by:
-
- Aug 17, 2018
-
-
Adenilson Cavalcanti authored
Optimizations can have different impact depending on the compression level used. It is quite handy to be able to change the compression level used for experiments while optimizing zlib. This patch adds an optional flag (-compression) to allow passing the desired compression level (0 to 9). To keep consistency, the user has to pass the target wrapper format (e.g. -wrapper gzip|zlib|raw). Finally, a help parameter is now supported (i.e. ./zlib_bench -h | --help) that will print the expected parameters while invoking the tool. Change-Id: I0b29fc2bd31bfccc39a7b7a10b510d9ca46d47e2 Reviewed-on: https://chromium-review.googlesource.com/1180341 Commit-Queue: Adenilson Cavalcanti <cavalcantii@chromium.org> Reviewed-by:
-
Chris Blume authored
When a payload is compressed via zlib using a known-in-advance dictionary symbols that are distant can cause the compression output buffer to be overwritten. This patch applies a fix that comes from upstream: https://github.com/madler/zlib/commit/5c44459c3b28a9bd3283aaceab7c615f8020c531 That fix hasn't yet landed in the master branch. This will prevent us from generating those invalid payloads. BUG=874550 Change-Id: Ic421d7242450f866388c90cee67cbc48b92ed83c Reviewed-on: https://chromium-review.googlesource.com/1176284 Commit-Queue: Chris Blume <cblume@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
-
- Aug 15, 2018
-
-
Adenilson Cavalcanti authored
Using a faster hash function yields a considerable performance boost in compression (average 8% on A53 and 24% on A72). This change was enabled by previous patch with optimized crc32 using ARMv8-1 crypto extensions for performing CPU feature detection (so won't help older ARMv7 SoCs). Bug: 873759 Change-Id: I88ece549a63d923beef4f96a046acdf09e529784 Reviewed-on: https://chromium-review.googlesource.com/1173262 Reviewed-by:
-
- Aug 07, 2018
-
-
Adenilson Cavalcanti authored
This should help with compression of data, using NEON instructions (therefore useful for ARMv7/ARMv8). Average gains were around 4% to 5% in data compression, depending on the data entropy. Re-write of a patch contributed to Fedora Core, for reference: https://src.fedoraproject.org/rpms/zlib/c/25e9802713484882c27c1f979a6610a42414ee13?branch=master Bug: 863257 Change-Id: I76573d75843d6a63de75d8a9536da98515314543 Reviewed-on: https://chromium-review.googlesource.com/1136940 Reviewed-by:
-
- Aug 06, 2018
-
-
Che-yu Wu authored
Remove the #define which enables NOUNCRYPT by default. Correct the value of rest_read_compressed when decompressing an encrypted zip. Bug: crbug.com/869541 Change-Id: Ia86c1d234a8193f405147d35ad05c29fe86f812d Reviewed-on: https://chromium-review.googlesource.com/1161109 Reviewed-by:
-
- Jul 18, 2018
-
-
Wez authored
The AutoRoll server is located here: https://fuchsia-sdk-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio Change-Id: I0ff88b708c490cc760902e245e6473e90546c4b9 Reviewed-on: https://chromium-review.googlesource.com/1137750 Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Wez <wez@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#575870} Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src Cr-Mirrored-Commit: cf06d0263c89f4c2e8d89cc34e31d535ca90a22b
-
- May 30, 2018
-
-
Tom Anderson authored
After [1], a manual dependency on exe_and_shlib_deps is no longer necessary since it's automatically added. This CL removes all remaining manual references to exe_and_shlib_deps. [1] https://chromium.googlesource.com/chromium/src.git/+/d7ed1f0a9c28c932fddc834ca5de44f28266c7f5 BUG=845700 R=dpranke TBR=sky,mark Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:ios-simulator-full-configs;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_compile_x64_dbg;master.tryserver.chromium.android:android_compile_x86_dbg;master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I647442fb09eba4c055697bf26504abc3b3284d94 Reviewed-on: https://chromium-review.googlesource.com/1073613 Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#563028} Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src Cr-Mirrored-Commit: ce772faa73ab8fa58e848b61b786d449bb988237
-
- May 07, 2018
-
-
Avi Drissman authored
BUG=838398 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_compile_x64_dbg;master.tryserver.chromium.android:android_compile_x86_dbg;master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.linux:linux_mojo;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.win:win10_chromium_x64_rel_ng Change-Id: Ibb79d0d8090cece52d7a20269153718992c8c2d1 Reviewed-on: https://chromium-review.googlesource.com/1036570 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#556512} Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src Cr-Mirrored-Commit: ea15ea06b514d9a95af39d7e35235fdf948da0c8
-
- May 02, 2018
-
-
Takuto Ikuta authored
Bug: 428099 Change-Id: I33a10720a3231dec560aa431dba182929226f664 Reviewed-on: https://chromium-review.googlesource.com/1036716 Reviewed-by:
-
- Apr 04, 2018
-
-
Jochen Eisinger authored
All other logging in that file is DVLOG(1), so be consistent R=satorux@chromium.org Change-Id: I1c0dc9128cc3c681b6c26dd169fe73a7323af97b Reviewed-on: https://chromium-review.googlesource.com/975602 Reviewed-by:
-
- Mar 27, 2018
-
-
Adenilson Cavalcanti authored
Generate optimized code that will help ARMv8 chips (between 2 to 10% perf gain on ARMv8 little/big cores) at the expense of a small perf regression on older chips (i.e. ARMv7). Bug: 772870 Change-Id: Ifc47870724da9790c944f76fedcc225d0a896caf Reviewed-on: https://chromium-review.googlesource.com/976521 Commit-Queue: Adenilson Cavalcanti <cavalcantii@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#546016} Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src Cr-Mirrored-Commit: ffc960a39d26fda610e0023667b2465118b8580a
-
- Mar 14, 2018
-
-
Tom Anderson authored
Linux distros like Gentoo have a philosophy of not statically-linking dependencies. The reason is not necessarily to save disk space, but because they like to compile with their own flags and patches applied. This CL fixes the zlib unbundle for them. BUG=800977 Change-Id: I129d95a5a4b6c4183666f712609b2e3f0509526e Reviewed-on: https://chromium-review.googlesource.com/947464 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
-
- Feb 22, 2018
-
-
Matt Menke authored
Gavin has left the team, and reviews should no longer be going his way. Chris has moved up, and is no longer focused on networking. TBR=thakis@chromium.org,droger@chromium.org Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I3e4be8a12cd0cab7cdfe62de527b59cafba5eccb Reviewed-on: https://chromium-review.googlesource.com/928847 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Chris Bentzel <cbentzel@chromium.org> Reviewed-by:
-
- Feb 16, 2018
-
-
Adenilson Cavalcanti authored
CRC32 affects performance for both image decoding (PNG) as also in general browsing while accessing websites that serve content using compression (i.e. Content-Encoding: gzip). This patch implements an optimized CRC32 function using the dedicated instruction available in ARMv8a. We only support ARM Little-Endian (LE). This instruction is available in new Android devices featuring an ARMv8 SoC, like Nexus 5x and Google Pixel. It should be between 3x (A72) to 7x faster (A53) than the C implementation currently used by zlib for 8KB vectors. This is performance critical code and can be called with both large (8KB) or small vectors, therefore we must avoid extraneous function calls or branching (otherwise the performance benefits are negated). So the use of 'public' variables to read the CPU features status flags (i.e. arm_cpu_enable_crc32 | pmull). Finally it also introduces code to perform run-time ARM CPU feature detection on the supported platforms: Android and Linux/CrOS. We build and link the CRC32 instruction dependent code, but will decide to use it at run-time if the ARM CPU supports the CRC32 instruction. Otherwise, we fallback to using zlib's default C implementation. This approach allows to use the instruction in both 32bits and 64bits and works fine either in ARMv7 or ARMv8 processor. I tested the generated Chrome apk in both a Nexus 6 (ARMv7) and a Google Pixel (ARMv8). The crc32 function benefited from input from Yang Zang and Mike Klein, while the arm_features benefited from input from Noel Gordon. Bug: 709716 Change-Id: I315c1216f8b3a8d88607630a28737c41f52a2f5d Reviewed-on: https://chromium-review.googlesource.com/801108 Reviewed-by:
-
- Feb 13, 2018
-
-
Chris Blume authored
We use a different set of names in root and contrib directories for the same purpose. This patch consolidates the names. BUG=764431 Change-Id: I346a6f9ab67423b97843346bab6b0c58f516ed1d Reviewed-on: https://chromium-review.googlesource.com/914469 Commit-Queue: Chris Blume <cblume@chromium.org> Reviewed-by:
-
