Skip to content
Snippets Groups Projects
Select Git revision
0 results
Search by author
  • Any Author
0 authors
  1. Nov 19, 2014
  3. Nov 18, 2014
  5. Nov 13, 2014
    • robert.bradford's avatar
      Enable zlib SIMD optimisations on Mac OS X builds · f0d2963e
      robert.bradford authored 
      With ninja builds generated from gyp on a Mac it is necessary to specify the
cflags to use as EXTRA_CFLAGS in an xcode_settings block in the gyp file. With
gn this is not necessary and led to confusion resulting in Mac builds not being
enabled in the original CL. As all Intel based Mac systems have SSE2 the
compiler does not require "-msse2" as it can always use that.

This change also initialised the global variables, as a result the variable is
moved from being a common symbol to being in the BSS section of the library.
This is necessary as unfortunately the linker on Mac cannot handle common
symbols with static libraries.

blink layout test inspector/layers/layer-canvas-log.html may start failing on
Mac with this change (See BUG below)

TEST=Build on Mac OS X and net_unittests --gtest_filter=*Compressed* run and
uses optimised code paths
BUG=430557

Review URL: https://codereview.chromium.org/705053002

Cr-Original-Commit-Position: refs/heads/master@{#304089}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 01686c1a7b233fcb8ab16b41ad3ffe58aef09cd1
      f0d2963e
  7. Nov 08, 2014
  9. Nov 05, 2014
    • robert.bradford's avatar
      Reland "Integrate SIMD optimisations for zlib" · 10dd686e
      robert.bradford authored 
      This version uses a "pthread_once" implementation, using Windows
synchronisation primitives, imported from tcmalloc.

Previous CLs:
https://codereview.chromium.org/677713002/
https://codereview.chromium.org/552123005

This version of the CL also runs fine on Windows Server 2003.

These optimisations have been published on zlib mailing list and at
https://github.com/jtkukunas/zlib/

This change merges the following optimisation patches:
- "For x86, add CPUID check."
- "Adds SSE2 optimized hash shifting to fill_window."
- "add SSE4.2 optimized hash function"
- "add PCLMULQDQ optimized CRC folding"

From Jim Kukunas <james.t.kukunas@linux.intel.com>; and adapts them to the
current zlib version in Chromium.

The optimisations are enabled at runtime if all the necessary CPU features are
present. As the optimisations require extra cflags to enable the compiler to
use the instructions the optimisations are held in their own static library
with a stub implementation to allow linking on other platforms.

TEST=net_unittests(GZipUnitTest) passes, Chrome functions and performance
improvement seen on RoboHornet benchmark on Linux Desktop
BUG=401517

Review URL: https://codereview.chromium.org/678423002

Cr-Original-Commit-Position: refs/heads/master@{#302799}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 02a95e3084f979084fa8586e1718a6e6dd4c22da
      10dd686e
  11. Oct 24, 2014
    • qyearsley's avatar
      Revert of Reland "Integrate SIMD optimisations for zlib" (patchset #2 id:40001... · 32301181
      qyearsley authored 
      Revert of Reland "Integrate SIMD optimisations for zlib" (patchset #2 id:40001 of https://codereview.chromium.org/677713002/)

Reason for revert:
Speculatively reverting because XP Tests (1) is having failures.

https://build.chromium.org/p/chromium.win/builders/XP%20Tests%20(1)

Original issue's description:
> Reland "Integrate SIMD optimisations for zlib"
>
> This reland adds an MSan suppression entry to work around gaps in MSan's
> support for some of the intrinsics this patch uses. This version also inlines
> the insert_string_sse function as it uses inline assembly and therefore does
> not need to be in the static library.
>
> Original CL: https://codereview.chromium.org/552123005
>
> These optimisations have been published on zlib mailing list and at
> https://github.com/jtkukunas/zlib/
>
> This change merges the following optimisation patches:
> - "For x86, add CPUID check."
> - "Adds SSE2 optimized hash shifting to fill_window."
> - "add SSE4.2 optimized hash function"
> - "add PCLMULQDQ optimized CRC folding"
>
> From Jim Kukunas <james.t.kukunas@linux.intel.com>; and adapts them to the
> current zlib version in Chromium.
>
> The optimisations are enabled at runtime if all the necessary CPU features are
> present. As the optimisations require extra cflags to enable the compiler to
> use the instructions the optimisations are held in their own static library
> with a stub implementation to allow linking on other platforms.
>
> TEST=net_unittests(GZipUnitTest) passes, Chrome functions and performance
> improvement seen on RoboHornet benchmark on Linux Desktop
> BUG=401517
>
> Committed: https://crrev.com/a5022d5eab6f77889aceed6ab0ccaf44a657ffc4
> Cr-Commit-Position: refs/heads/master@{#301162}

TBR=agl@chromium.org,hans@chromium.org,robert.bradford@intel.com
NOTREECHECKS=true
NOTRY=true
BUG=401517

Review URL: https://codereview.chromium.org/665203006

Cr-Original-Commit-Position: refs/heads/master@{#301221}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 5d38e0bd32f9a7e4766b877711c710df986d74ed
      32301181
    • robert.bradford's avatar
      Reland "Integrate SIMD optimisations for zlib" · a8515195
      robert.bradford authored 
      This reland adds an MSan suppression entry to work around gaps in MSan's
support for some of the intrinsics this patch uses. This version also inlines
the insert_string_sse function as it uses inline assembly and therefore does
not need to be in the static library.

Original CL: https://codereview.chromium.org/552123005

These optimisations have been published on zlib mailing list and at
https://github.com/jtkukunas/zlib/

This change merges the following optimisation patches:
- "For x86, add CPUID check."
- "Adds SSE2 optimized hash shifting to fill_window."
- "add SSE4.2 optimized hash function"
- "add PCLMULQDQ optimized CRC folding"

From Jim Kukunas <james.t.kukunas@linux.intel.com>; and adapts them to the
current zlib version in Chromium.

The optimisations are enabled at runtime if all the necessary CPU features are
present. As the optimisations require extra cflags to enable the compiler to
use the instructions the optimisations are held in their own static library
with a stub implementation to allow linking on other platforms.

TEST=net_unittests(GZipUnitTest) passes, Chrome functions and performance
improvement seen on RoboHornet benchmark on Linux Desktop
BUG=401517

Review URL: https://codereview.chromium.org/677713002

Cr-Original-Commit-Position: refs/heads/master@{#301162}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: a5022d5eab6f77889aceed6ab0ccaf44a657ffc4
      a8515195
  13. Oct 23, 2014
    • robert.bradford's avatar
      Revert of Integrate SIMD optimisations for zlib (patchset #14 id:280001 of... · 23dbc912
      robert.bradford authored 
      Revert of Integrate SIMD optimisations for zlib (patchset #14 id:280001 of https://codereview.chromium.org/552123005/)

Reason for revert:
Strong candidate for: multiple Linux MSan test failures with:

SUMMARY: MemorySanitizer: use-of-uninitialized-value ??:0 ??

Including: CompressionUtilsTest.GzipCompression

Original issue's description:
> Integrate SIMD optimisations for zlib
>
> These optimisations have been published on zlib mailing list and at
> https://github.com/jtkukunas/zlib/
>
> This change merges the following optimisation patches:
> - "For x86, add CPUID check."
> - "Adds SSE2 optimized hash shifting to fill_window."
> - "add SSE4.2 optimized hash function"
> - "add PCLMULQDQ optimized CRC folding"
>
> From Jim Kukunas <james.t.kukunas@linux.intel.com> and adapts them to the
> current zlib version in Chromium.
>
> The optimisations are enabled at runtime if all the necessary CPU features are
> present. As the optimisations require extra cflags to enable the compiler to
> use the instructions the optimisations are held in their own static library
> with a stub implementation to allow linking on other platforms.
>
> TEST=net_unittests(GZipUnitTest) passes, Chrome functions and performance
> improvement seen on RoboHornet benchmark on Linux Desktop
> BUG=401517
>
> Committed: https://crrev.com/e045ec106de29562ae94eafccde49a7b73848471
> Cr-Commit-Position: refs/heads/master@{#300866}

TBR=agl@chromium.org,nathan.d.ciobanu@intel.com
NOTREECHECKS=true
NOTRY=true
BUG=401517

Review URL: https://codereview.chromium.org/671163003

Cr-Original-Commit-Position: refs/heads/master@{#300889}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: ca54b3014721cdc27e4a17dd2c82fe5811fa39cc
      23dbc912
    • robert.bradford's avatar
      Integrate SIMD optimisations for zlib · 02acec91
      robert.bradford authored 
      These optimisations have been published on zlib mailing list and at
https://github.com/jtkukunas/zlib/

This change merges the following optimisation patches:
- "For x86, add CPUID check."
- "Adds SSE2 optimized hash shifting to fill_window."
- "add SSE4.2 optimized hash function"
- "add PCLMULQDQ optimized CRC folding"

From Jim Kukunas <james.t.kukunas@linux.intel.com> and adapts them to the
current zlib version in Chromium.

The optimisations are enabled at runtime if all the necessary CPU features are
present. As the optimisations require extra cflags to enable the compiler to
use the instructions the optimisations are held in their own static library
with a stub implementation to allow linking on other platforms.

TEST=net_unittests(GZipUnitTest) passes, Chrome functions and performance
improvement seen on RoboHornet benchmark on Linux Desktop
BUG=401517

Review URL: https://codereview.chromium.org/552123005

Cr-Original-Commit-Position: refs/heads/master@{#300866}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: e045ec106de29562ae94eafccde49a7b73848471
      02acec91
  15. Oct 07, 2014
  17. Sep 23, 2014
  19. Sep 22, 2014
  21. Sep 13, 2014
  23. Aug 13, 2014
  25. Aug 01, 2014
    • thakis@chromium.org's avatar
      Refactor how clang warning flags are set. · 1eea7046
      thakis@chromium.org authored 
      Previously, every gyp file that wanted to set clang warnings had to check
for clang==1 and then set cflags and xcode_settings.WARNING_CFLAGS. Factor
this out, so that targets only need to set clang_warning_flags for warnings
that apply to all platforms. (Per-platform flags still need to be set manually.)

This removes existing duplication from gyp files, and prevents adding more
duplication when trying to add the same warning flags for clang/win.

BUG=82385
R=hans@chromium.org, scottmg@chromium.org
TBR=various owners

Review URL: https://codereview.chromium.org/437543007

Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: dcbc32cc8063d329ba9128807b05d912d7d3679e
      1eea7046
  27. Jul 31, 2014
    • scottmg@chromium.org's avatar
      gn win: Fix potentially uninitialized variable warning in zip_internal · 8796c17e
      scottmg@chromium.org authored 
      The gn Windows build says

d:\src\cr3\src\third_party\zlib\google\zip_internal.cc(62) : error C2220: warning treated as error - no 'object' file generated
d:\src\cr3\src\third_party\zlib\google\zip_internal.cc(62) : warning C4701: potentially uninitialized local variable 'creation_disposition' used

This warning is disabled in the gyp build, but it seems better to keep
it on if possible, and it seems like depending on the flags passed to
ZipOpenFunc, it could indeed be passing an uninitialized value to
::CreateFile. Setting it explicitly to 0 will cause ::CreateFile to
fail, if it's left unset by the ifs.

R=satorux@chromium.org
BUG=354261

Review URL: https://codereview.chromium.org/430963002

Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 167c929e90ac048545bdf16cf454c03b3bae2882
      8796c17e
  29. Jun 20, 2014
  31. May 07, 2014
  33. May 02, 2014
  35. Apr 30, 2014
  37. Apr 29, 2014
  39. Mar 24, 2014
  41. Mar 06, 2014
  43. Feb 27, 2014
  45. Jan 17, 2014
  47. Jan 07, 2014
  49. Dec 26, 2013
  51. Dec 17, 2013
  53. Dec 09, 2013
  55. Dec 06, 2013
  57. Dec 03, 2013
  59. Sep 24, 2013
  61. Aug 30, 2013
  63. Aug 22, 2013