Select Git revision
Search by author
- Any Author
- authors
-
72162444 72162444 gaochangning
-
Aakash Dave aakash.dave
-
Aaron Kim akim
-
Aaron Kloc akloc
-
Aaron Lan aaron.lan
-
Aaron Nabil aaronna
-
Aaron Pohle aaron.pohle
-
Abbott Chung chung.abbott
-
Abdallah Omar abdallah_omar
-
Abdessamii Chalbi abdessamii.chalbi
-
Abdul Hussain Sirajudeen abdul.hussain
-
Abdullah Alghamdi a.alghamdi
-
Abdullah Elmarghany abdullah_elmarghany
-
Abel Fang abel_fang
-
Abhijeet Badurkar abhijeet.badurkar
-
Abhijit Adsule adsule
-
Abhijit Murthy abhijit
-
Abhi Khanal akhanal
-
Abhilash Sahoo abhilashsahoo
-
Abhimanyu Raj abhimanyu.raj
- Jan 24, 2020
-
-
Nico Weber authored
Ran `tools/clang/scripts/upload_revision.py efb130fc93059bdf02d3a83950ddabc5d119f9de`. This increases the clang version from 10 to 11. It also disables the use of vector instructions in zlib to work around new false positives in msan (see crbug.com/1045291). Bug: 1030664 Change-Id: I5417d3063f0d67a61cdf31141b05a51a56e84482 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014904 Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#735080} Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src Cr-Mirrored-Commit: 0aa05cca9db25a9fa8d18f77bf6b2452bc608ead
-
- Jan 23, 2020
-
-
Adenilson Cavalcanti authored
Due to its history, zlib has to support building for environments without access to basic C functions (e.g. memcpy, memset, etc) or in environments with odd memory management patterns (e.g. MSDOS). Therefore, it is good form to use zmemset/zmemcpy/etc for handling memory and the same applies for initializing a memory block to zero. Bug: 1032721 Change-Id: I8d898872ca00197cc7e961d7c49e1912073895c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016772 Reviewed-by:
Chris Blume <cblume@chromium.org> Reviewed-by:
vikas soni <vikassoni@chromium.org> Commit-Queue: Adenilson Cavalcanti <cavalcantii@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#734686} Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src Cr-Mirrored-Commit: bcdbc75cd3f832ad0527a00f5bf56aa437abf1f6
-
Adenilson Cavalcanti authored
Fix use of uninitialized memory reported by oss-fuzz (and confirmed by valgrind@aarch64) by properly setting deflate_state internal member (i.e. s->prev) to a valid value before use. For details, see: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=11360 Bug: 1032721 Change-Id: I6c7b2e87e81b8ccc6c39298fd3c704befd797b96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015667 Commit-Queue: Adenilson Cavalcanti <cavalcantii@chromium.org> Reviewed-by:
-
- Jan 14, 2020
-
-
Nico Weber authored
`gn format` recently changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. This CL was uploaded by git cl split. R=isherman@chromium.org Bug: 1041419 Change-Id: I91a90114ecefd7dc850abbc9f57811bd46432cdc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998796 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#731398} Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src Cr-Mirrored-Commit: 1f34a393281949df92a353b738d45370e78e1413
-
- Jan 13, 2020
-
-
Nico Weber authored
`gn format` recently changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. This CL was uploaded by git cl split. R=cblume@chromium.org Bug: 1041419 Change-Id: I7c5f71a3369485a78c6e7ba9490f893e15b65c9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1997933 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
-
- Jan 08, 2020
-
-
Adenilson Cavalcanti authored
This will allow to remove some duplicated code (i.e. thread synchronization) while at same time removing unnecessary use of inline ASM for Intel features detection. A few other advantages: - remove some extra logic (e.g. no need to test the platform to include the correct CPU detection header). - simplifies the buildsystem (i.e. we always include cpu_features.c) - get rid of the simd_stub file. Bug: 1032721 Change-Id: I9427b34ec09dddc41925844a6ec4e6aa4d8f3207 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1987190 Reviewed-by:
Mike Klein <mtklein@chromium.org> Reviewed-by:
Adenilson Cavalcanti <cavalcantii@chromium.org> Commit-Queue: Adenilson Cavalcanti <cavalcantii@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#729515} Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src Cr-Mirrored-Commit: d989ac2c596e88e7581eb93d053945a43c611124
-
- Dec 21, 2019
-
-
Hans Wennborg authored
This reverts commit 6f7e5e79cefe982ad84a88927565a88db2e592be. Reason for revert: This broke the build, e.g. https://ci.chromium.org/p/chromium/builders/ci/ios-device/144512 ../../third_party/zlib/cpu_features.c:75:13: error: unused function '_cpu_check_features' [-Werror,-Wunused-function] static void _cpu_check_features(void) ^ Original change's description: > Unify CPU features detection code > > This will allow to remove some duplicated code (i.e. thread synchronization) > while at same time removing unnecessary use of inline ASM for Intel features > detection. > > A few other advantages: > - remove some extra logic (e.g. no need to test the platform to include the > correct CPU detection header). > - simplifies the buildsystem (i.e. we always include cpu_features.c) > - get rid of the simd_stub file. > > Bug: 1032721 > Change-Id: Ic93472d3337bc2cbe092d4cf8fbe4b31b1ceca6d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976820 > Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#727039} Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src Cr-Mirrored-Commit: 9d8f976414a7608c3361718462253104a761c6bb
-
Adenilson Cavalcanti authored
This will allow to remove some duplicated code (i.e. thread synchronization) while at same time removing unnecessary use of inline ASM for Intel features detection. A few other advantages: - remove some extra logic (e.g. no need to test the platform to include the correct CPU detection header). - simplifies the buildsystem (i.e. we always include cpu_features.c) - get rid of the simd_stub file. Bug: 1032721 Change-Id: Ic93472d3337bc2cbe092d4cf8fbe4b31b1ceca6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976820 Reviewed-by:
-
- Dec 12, 2019
-
-
Adenilson Cavalcanti authored
This change will unify the x86 and Arm optimized implementations for insert_string (used for compression). The objective here is two-fold: a) Remove duplicated code. b) Better insulate deflate.c divergence when compared to vanilla zlib. Bug: 1032721 Change-Id: Id2f65398aeb5a6384708493f0f6ae1fcd14022c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960893 Reviewed-by:
-
- Dec 04, 2019
-
-
Chris Blume authored
It seems that some years ago clang@Windows didn't have the proper intrinsic required, which prompted the use of inline ASM. It has a side effect in that it will allow compilation of the optimized function within the same compilation unit while using regular compiler flags (i.e. 'crc32' instruction on x86 requires some special compiler flags). Main issue is that inline ASM is blocked on dependencies (e.g. 'base') that will be linked to NaCl. The main idea here is to allow the whole Chromium code base to use the highly optimized checksums in zlib (e.g. crc32 and Adler-32), exported through an interface (i.e. base::Crc32()). This patch fixes this issue by removing the use of inline ASM. The workaround is to use clang/gcc 'target attributes' to instruct the backend to use different code generation options for the optimized function, see: https://clang.llvm.org/docs/AttributeReference.html#target NOTE: While testing on my personal Windows PC, VS2019 including smmintrin.h was insufficient. I needed to explicitly include either immintrin.h or nmmintrin.h. I expected I would need that, but it seems to be working with just smmintrin.h. Bug: 902789 Change-Id: Id692fb839e20b26f9ba8b45538e652d5b140cd36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941688 Commit-Queue: Chris Blume <cblume@chromium.org> Reviewed-by:
-
- Nov 26, 2019
-
-
Chris Blume authored
This reverts commit ea6b9281bbf3ca08ccef8f5266f88de6f56c5ff6. Reason for revert: It turns out the V8 team needs the MSVC build. :) I tried installing the Clang compiler as part of Visual Studio 2017 and 2019 but neither of them became options in the toolchain. I'll need to spend more time figuring out how to get Clang on Windows. Original change's description: > Remove use of inline ASM in insert_string_sse > > It seems that some years ago clang@Windows didn't have the > proper intrinsic required, which prompted the use of inline > ASM. > > It has a side effect in that it will allow compilation of the > optimized function within the same compilation unit while using regular > compiler flags (i.e. 'crc32' instruction on x86 requires some special > compiler flags). > > Main issue is that inline ASM is blocked on dependencies (e.g. 'base') > that will be linked to NaCl. > > The main idea here is to allow the whole Chromium code base to use the > highly optimized checksums in zlib (e.g. crc32 and Adler-32), exported > through an interface (i.e. base::Crc32()). > > This patch fixes this issue by removing the use of inline ASM. > > The workaround is to use clang/gcc 'target attributes' to instruct the > backend to use different code generation options for the optimized > function, see: > https://clang.llvm.org/docs/AttributeReference.html#target > > Bug: 902789 > Change-Id: I0d139268aefb8335310c0e3f6533006be9af6470 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931272 > Reviewed-by:
-
- Nov 25, 2019
-
-
Adenilson Cavalcanti authored
It seems that some years ago clang@Windows didn't have the proper intrinsic required, which prompted the use of inline ASM. It has a side effect in that it will allow compilation of the optimized function within the same compilation unit while using regular compiler flags (i.e. 'crc32' instruction on x86 requires some special compiler flags). Main issue is that inline ASM is blocked on dependencies (e.g. 'base') that will be linked to NaCl. The main idea here is to allow the whole Chromium code base to use the highly optimized checksums in zlib (e.g. crc32 and Adler-32), exported through an interface (i.e. base::Crc32()). This patch fixes this issue by removing the use of inline ASM. The workaround is to use clang/gcc 'target attributes' to instruct the backend to use different code generation options for the optimized function, see: https://clang.llvm.org/docs/AttributeReference.html#target Bug: 902789 Change-Id: I0d139268aefb8335310c0e3f6533006be9af6470 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931272 Reviewed-by:
-
- Nov 21, 2019
-
-
Adenilson Cavalcanti authored
While investigating the use of RAW mode, I noticed that it was *slower* for compression than GZIP or ZLIB wrapper formats, which didn't make sense (i.e. we don't calculate a data integrity check using RAW mode). It turns out that the code was falling back to the portable implementation of insert_string(), instead of using the optimized version that rely on 'crc32w' as a hash function. The reason is that CPU features detection is not triggered while using RAW mode (i.e. we never call crc32() with a NULL buffer). This patch fixes this issue ensuring that RAW mode is going to be faster for both compression/decompression than either ZLIB or GZIP formats. Bug: 833361 Change-Id: I285297f67ffc0114700ed03c2186ad21aab8b40e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929634 Reviewed-by:
-
- Nov 14, 2019
-
-
Sam Maier authored
Allow users to set the compression level while using CompressHelper(). There is a 2x to 4x compression speed difference between levels [1..9], where it is possible to trade speed for better compression ratios (and vice-versa). It is up the user to experiment with the data to find the sweet spot for its application (default compression level is 6). Bug: 833361 Change-Id: Ia710cc7322707ace242133b283610eaa48def31f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912791 Commit-Queue: Adenilson Cavalcanti <cavalcantii@chromium.org> Commit-Queue: Sam Maier <smaier@chromium.org> Auto-Submit: Sam Maier <smaier@chromium.org> Reviewed-by:
-
- Nov 08, 2019
-
-
Sam Maier authored
compression_utils_portable This allows client code to select the wrapper format used which may be faster (e.g. zlib format on older ARMv7 and early ARMv8 SoCs) depending on the application. The wrapper format selection code was partially taken from zlib_bench.cc. Bug: 833361 Change-Id: I8a317e6abc8bd2d66f2e940406badfd7e930e809 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904505 Reviewed-by:
-
- Nov 04, 2019
-
-
Sam Maier authored
Change-Id: Ib538c60f5e1fa2e81432bc0992a482aced6eb7cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1897847 Auto-Submit: Sam Maier <smaier@chromium.org> Reviewed-by:
-
- Oct 24, 2019
-
-
Adenilson Cavalcanti authored
Missing functionality to be able to reuse portable helpers. Change-Id: If38e5f2b44cff9fb5f1744a59961ee6902f847f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876760 Reviewed-by:
Sam Maier <smaier@chromium.org> Reviewed-by:
-
- Oct 15, 2019
-
-
Jüri Valdmann authored
GCC parses the function __attribute__ syntax a bit differently from Clang, associating the attribute with the return type instead of the function if the return type is a pointer. This leads to certain zlib symbols, such as Cr_z_zError, to fail to be properly exported from the shared library. Fix by using ZEXTERN instead of ZEXPORT for the attribute which works the same for both GCC and Clang. Bug: 819294 Change-Id: I5707d1b0627a503df08df9ac0bb65fda69453989 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859788 Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
-
- Oct 01, 2019
-
-
Sylvain Defresne authored
base::Bind/base::Callback are deprecated in favor of either base::BindOnce/base::OnceCallback or base::BindRepeating/ base::RepeatingCallback (depending on whether the callback is invoked once or multiple time). Convert all uses of base::Bind/base::Callback in third_party/zlib/google to the recommended methods/types. Bug: 1007842 Change-Id: I45efc78b9138def0469912e5d733dbaeaa652407 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832270 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Satoru Takabayashi <satorux@chromium.org> Reviewed-by:
Satoru Takabayashi <satorux@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#701593} Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src Cr-Mirrored-Commit: 0bbcc5569581fbf220edd75e4f11a2b9a416fb82
-
- Sep 24, 2019
-
-
Sam Maier authored
This allows other users of Chromium's zlib library who don't depend on //base (for example, V8), to reuse some boilerplate code. Bug: 833361 Change-Id: Ifc9023fdb9915e0452d424b030e8a8e5ae1c0df3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819838 Reviewed-by:
-
- Sep 10, 2019
-
-
Gabriel Charette authored
Explicitly (to document for git log purposes), this removes: - base::test::ScopedTaskEnvironment - net::WithScopedTaskEnvironment - net::TestWithScopedTaskEnvironment - content::TestBrowserThreadBundle - web::TestWebThreadBundle Mass migrate stragglers which landed under old names after initial mass migration. TBR=dcheng@chromium.org (to bypass owners for mechanical changes outside //base) Bug: 992483 Change-Id: I16cab3611b7f1a0a869f9f3af22d5b2952f91da6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1791271 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Auto-Submit: Gabriel Charette <gab@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#695003} Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src Cr-Mirrored-Commit: 2dfa2ba40a372f4a08ba0d051b5cbe5accf2c526
-
- Aug 27, 2019
-
-
Sam Maier authored
cpu_features GN target moved from android_sdk to android_ndk TBR: minor rename of target Bug: 990407 Change-Id: I82e25a24716d73e17f2e19dd5e83e94b636b8b0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1756203 Auto-Submit: Sam Maier <smaier@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Sam Maier <smaier@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#690799} Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src Cr-Mirrored-Commit: 801f0550ba72ea0021e97552ec9b98267b69f673
-
- Aug 23, 2019
-
-
Gabriel Charette authored
This is a reland of 18947083c7e75ec6d5e8c3b729515d83bde41c59 The move_source_file.py script's formatting rules incorrectly formatted services/device/generic_sensor/platform_sensor_and_provider_unittest_win.cc after all. But we also can't rely 100% on git cl format (crbug.com/997063) so I ended up performing a git cl format && git add -up (+interactive addition of missing blank line after foo.h when included from top of foo.cc) Also added $ tools/git/move_source_file.py net/test/test_with_scoped_task_environment.h net/test/test_with_task_environment.h Original change's description: > [TaskEnvironment] Complete migration with header rename > > This is merely: > > $ tools/git/move_source_file.py base/test/scoped_task_environment.h base/test/task_environment.h > $ tools/git/move_source_file.py base/test/scoped_task_environment.cc base/test/task_environment.cc > $ tools/git/move_source_file.py base/test/scoped_task_environment_unittest.cc base/test/task_environment_unittest.cc > $ tools/git/move_source_file.py content/public/test/test_browser_thread_bundle.h content/public/test/browser_task_environment.h > $ tools/git/move_source_file.py content/public/test/test_browser_thread_bundle.cc content/public/test/browser_task_environment.cc > $ tools/git/move_source_file.py content/public/test/test_browser_thread_bundle_unittest.cc content/public/test/browser_task_environment_unittest.cc > $ tools/git/move_source_file.py ios/web/public/test/test_web_thread_bundle.h ios/web/public/test/web_task_environment.h > $ tools/git/move_source_file.py ios/web/test/test_web_thread_bundle.cc ios/web/test/web_task_environment.cc > > and a few manual renames in DEPS files missed by the script > > This CL uses --bypass-hooks to avoid having to git cl format because > many headers are being reordered by git cl format and it's too many to > figure out in a no-op CL which ones are okay with it. > windows.h for one should typically be first and another one of the > reorderings in PS3 even caused a compile failure: > https://chromium-review.googlesource.com/c/chromium/src/+/1764962/3/components/services/font/font_loader_unittest.cc > > TBR=dcheng@chromium.org > > Bug: 992483 > Change-Id: I32a4afd43ef779393c95d9873c157be2d3da1dd1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764962 > Reviewed-by:
Gabriel Charette <gab@chromium.org> > Reviewed-by:
-
Gabriel Charette authored
This reverts commit 18947083c7e75ec6d5e8c3b729515d83bde41c59. Reason for revert: broke Win Original change's description: > [TaskEnvironment] Complete migration with header rename > > This is merely: > > $ tools/git/move_source_file.py base/test/scoped_task_environment.h base/test/task_environment.h > $ tools/git/move_source_file.py base/test/scoped_task_environment.cc base/test/task_environment.cc > $ tools/git/move_source_file.py base/test/scoped_task_environment_unittest.cc base/test/task_environment_unittest.cc > $ tools/git/move_source_file.py content/public/test/test_browser_thread_bundle.h content/public/test/browser_task_environment.h > $ tools/git/move_source_file.py content/public/test/test_browser_thread_bundle.cc content/public/test/browser_task_environment.cc > $ tools/git/move_source_file.py content/public/test/test_browser_thread_bundle_unittest.cc content/public/test/browser_task_environment_unittest.cc > $ tools/git/move_source_file.py ios/web/public/test/test_web_thread_bundle.h ios/web/public/test/web_task_environment.h > $ tools/git/move_source_file.py ios/web/test/test_web_thread_bundle.cc ios/web/test/web_task_environment.cc > > and a few manual renames in DEPS files missed by the script > > This CL uses --bypass-hooks to avoid having to git cl format because > many headers are being reordered by git cl format and it's too many to > figure out in a no-op CL which ones are okay with it. > windows.h for one should typically be first and another one of the > reorderings in PS3 even caused a compile failure: > https://chromium-review.googlesource.com/c/chromium/src/+/1764962/3/components/services/font/font_loader_unittest.cc > > TBR=dcheng@chromium.org > > Bug: 992483 > Change-Id: I32a4afd43ef779393c95d9873c157be2d3da1dd1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764962 > Reviewed-by:
-
Gabriel Charette authored
This is merely: $ tools/git/move_source_file.py base/test/scoped_task_environment.h base/test/task_environment.h $ tools/git/move_source_file.py base/test/scoped_task_environment.cc base/test/task_environment.cc $ tools/git/move_source_file.py base/test/scoped_task_environment_unittest.cc base/test/task_environment_unittest.cc $ tools/git/move_source_file.py content/public/test/test_browser_thread_bundle.h content/public/test/browser_task_environment.h $ tools/git/move_source_file.py content/public/test/test_browser_thread_bundle.cc content/public/test/browser_task_environment.cc $ tools/git/move_source_file.py content/public/test/test_browser_thread_bundle_unittest.cc content/public/test/browser_task_environment_unittest.cc $ tools/git/move_source_file.py ios/web/public/test/test_web_thread_bundle.h ios/web/public/test/web_task_environment.h $ tools/git/move_source_file.py ios/web/test/test_web_thread_bundle.cc ios/web/test/web_task_environment.cc and a few manual renames in DEPS files missed by the script This CL uses --bypass-hooks to avoid having to git cl format because many headers are being reordered by git cl format and it's too many to figure out in a no-op CL which ones are okay with it. windows.h for one should typically be first and another one of the reorderings in PS3 even caused a compile failure: https://chromium-review.googlesource.com/c/chromium/src/+/1764962/3/components/services/font/font_loader_unittest.cc TBR=dcheng@chromium.org Bug: 992483 Change-Id: I32a4afd43ef779393c95d9873c157be2d3da1dd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764962 Reviewed-by:
-
- Aug 13, 2019
-
-
Noel Gordon authored
Per crbug.com/798943#c9 zlib_bench contains the snappy bench verbatim, for the reasons explained there. However, subsequent code changes were not cc-ed to me. Add an OWNERS file to vet changes. Bug: 798943 Change-Id: I51b68f78190b1277882e5aeeffdc7b4e377c630d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1746510 Commit-Queue: Chris Blume <cblume@chromium.org> Auto-Submit: Noel Gordon <noel@chromium.org> Reviewed-by:
-
- Aug 12, 2019
-
-
Jeremy Roman authored
Changed NULL to nullptr where the presubmit complained (due to new line wrapping). Generated by: https://chromium-review.googlesource.com/c/chromium/src/+/1689216 Bug: 981415 Tbr: johannes@chromium.org,mathp@chromium.org,satorux@chromium.org Change-Id: Icd574b69f75ead6dc6f34e7b4edcd52a53830640 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1702744 Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Raymes Khoury <raymes@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Yuwei Huang <yuweih@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#686003} Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src Cr-Mirrored-Commit: 7c5cfabd6bc582c20e0ae5e56adf8e9c8e22bce0
-
- Aug 09, 2019
-
-
Adenilson Cavalcanti authored
The helpers are portable code and don't depend on 'base' code, this fixes a layer violation. Another advantage is to make it easier to deploy Chromium's zlib i.e. no need to write your own helpers. Change-Id: I10a5452dd8835f1e1ec592d7c1c1cc3bb67f9e70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742295 Commit-Queue: Adenilson Cavalcanti <cavalcantii@chromium.org> Reviewed-by:
-
- Aug 08, 2019
-
-
Adenilson Cavalcanti authored
Faster symbol hashing has a positive impact on data compression speed (around 20% on Intel and 36% on Arm Cortex big cores). A misfeature is that the generated compressed output will differ from vanilla zlib (even though it is still valid 'DEFLATE-d' content) and in some cases has slightly better compression ratio. We offer here a way to disable the optimization if there is the expectation that compressed content should match when compared to vanilla zlib. Bug: 990489 Change-Id: I910e140eb15dd334eb869b078f940581249a7e6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742297 Reviewed-by:
-
- Aug 05, 2019
-
-
Adenilson Cavalcanti authored
Usage of CRC32 Castagnoli as a hash function for the hash table of symbols used for compression has a side effect where for compression level [4, 5] it will increase the required output buffer size by 0.1% (i.e. less than 1%) for a high entropy input (i.e. random data). To avoid a scenario where client code would fail while compressing data, this patch will increase the compressBound by 0.8% (i.e. 8x than worst case scenario). Validated using zlib_bench with the data from the 'Random Compression Challenge' on both Intel and Arm. Bug: 990489 Change-Id: I86c6ab09fce6ab09b45c502221864400b86a7d80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733790 Commit-Queue: Adenilson Cavalcanti <cavalcantii@chromium.org> Reviewed-by:
-
- Aug 01, 2019
-
-
Adenilson Cavalcanti authored
On Intel the instruction used is CRC-32C (Castagnoli), which uses a different polynomial than 'traditional' crc32 deployed in zlib. Fortunately ARM has instructions for both polynomials, so this patch will ensure that compressed content using Chromium's zlib will match i.e. checksums should be the same. Bug: https://issuetracker.google.com/115695768 Change-Id: Ia22bc150e89afa345a6d3149c30332a6c1e7934d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726551 Commit-Queue: Adenilson Cavalcanti <cavalcantii@chromium.org> Reviewed-by:
-
- Jul 25, 2019
-
-
Nico Weber authored
Code in src.git generally shouldn't be depended on by clients outside of src.git, so that we're able to atomically change it, and so that we're able to test changes in src.git with the CQ. See also discussion on https://chromium-review.googlesource.com/c/chromium/src/+/1648737 Prerequisite for https://chromium-review.googlesource.com/c/chromium/src/+/1715975 No behavior change for Chromium. Bug: 961769 Change-Id: I69e873528afc2c735b8fa28090449daae43853bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1718785 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
-
- Jul 19, 2019
-
-
Darin Fisher authored
This ends up conflicting with use of 'internal_state' as a member function name in mojo header files. It creates problems especially with jumbo builds. Fixing it here rather than just working around it in the jumbo build helps avoid others from stumbling over this in the future (especially as we start utilizing mojo more). Change-Id: I649fd80eb80c57e445b78819e9dc674adbf901bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1709871 Commit-Queue: Darin Fisher <darin@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Reviewed-by:
-
- Jun 24, 2019
-
-
Tomasz Śniatowski authored
Check use_thin_lto instead of thin_lto_enable_optimizations, as the latter is only defined in a BUILD.gn so can't be checked outside of it. Plus the intent of https://crrev.com/c/1642730 appears to have been to error out on LTO in general anyway. Fixes gn gen --args="is_clang=false target_cpu=\"arm\"" failing with: ERROR at //third_party/zlib/BUILD.gn:105:17: Undefined identifier assert(!thin_lto_enable_optimizations, ^---------------------------- Bug: 819294 Change-Id: Ibbcae447b01043edc8a118f4a3a3923f2d0ae261 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1667663 Auto-Submit: Tomasz Śniatowski <tsniatowski@vewd.com> Commit-Queue: Adenilson Cavalcanti <cavalcantii@chromium.org> Reviewed-by:
-
- Jun 11, 2019
-
-
Leon Scroggins III authored
Bug: https://issuetracker.google.com/115695768 Android would like to use Chromium's copy of zlib, to take advantage of its SIMD optimizations etc. However, it does not want the renames from chromeconf.h. Only include that file when building CHROMIUM/CHROME, so that Android's repo can have minimal differences from this one and build properly. See https://android-review.googlesource.com/c/platform/external/zlib/+/979128 Change-Id: I44985166edb16ccc3333f008e0840cdd8dbce055 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648737 Reviewed-by:
-
- Jun 10, 2019
-
-
Jose Dapena Paz authored
GCC compilation in ARM architectures with CRC32 extension was broken, as the extension was guarded for clang. For GCC we are enforcing armv8-a+crc architecture at module level, so the builtin extensions are available. Then we just include arm_acle.h to declare the required builtins. ThinLTO requires all modules to use same target, so this change makes GCC fail with ThinLTO (that was not supported anyway). Added a GN assert to explicitely fail in this case. Adapted from Vladislav Mukulov <vladislav.mukulov@lge.com> original patch. Bug: 819294 Change-Id: Ifa5cf64318f88220052c44126db90bef999b7113 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642730 Reviewed-by:
-
- May 14, 2019
-
-
Samuel Huang authored
This CL compresses DOM distiller's resources, which reduces Chrome's binary size by 86 kB on Android. Details: * Add compress="gzip" to all dom_distiller_resoruces.grdp items. * Add resource_utils.* with GetResrouceFromIdAsString() to centralize ui::ResourceBundle() usage, and perform uncompression. * Ensure that all IDR_* usage go through GetResourceFromIdAsString(). * Exception: WebUI (for chrome://dom-distiller), which uses content::WebUIDataSource, so decompression is already handled. Also update third_party/zlib: * Add GzipUncompress(base::StringPiece, std::string*), which allocates the output string (used by GetResrouceFromIdAsString()). * Add CompressionUtilsTest::GzipUncompressionFromStringPieceToString. Bug: 872559, 961866 Change-Id: I54f7f80bd3b90e9e0226901295043a25e714a938 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1606245 Commit-Queue: Samuel Huang <huangs@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#659695} Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src Cr-Mirrored-Commit: 400f6e823a75b4b8fada6e270071da8082527dc2
-
- Apr 18, 2019
-
-
Richard Townsend authored
This CL integrates feature detection across the file so that similar sections do similar things across all operating systems. Bug: 810125 Change-Id: I066226be69453ada72fa67632d09567ce246a860 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1569929 Reviewed-by:
-
- Apr 15, 2019
-
-
Richard Townsend authored
Fixes a failing GN assertion for Windows on Arm as it uses a separate path to check CRC32 extension support, so no OS-specific defines are needed. Bug: 810125 Change-Id: I172b4ecd66d94d195f1ccac4c6108ea2a40972a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1567678 Commit-Queue: Adenilson Cavalcanti <cavalcantii@chromium.org> Commit-Queue: Richard Townsend <richard.townsend@arm.com> Reviewed-by:
-
Noel Gordon authored
Add OS_FUCHSIA ARM CPU feature detection and enable the crc32 feature on the ARM version of Fuchsia (which is aarch64 only, FTR). For perf, see the results crbug.com/810125/#c17 .. crbug.com/810125/#c19. Add BUILD.gn asserts in the ARM crc32 feature rules: to vet any build expectations (e.g., that the android NDK is installed on is_android), or cause gn errors if the ARM OS type is not supported. Bug: 810125 Change-Id: Id6759d4c6142924c09c591b61117dca529955175 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1472990 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
-
