Skip to content
Snippets Groups Projects
Commit 9eb2a751 authored by Noel Gordon's avatar Noel Gordon Committed by Commit Bot
Browse files

Use default optimization on Android for zlib inflate chunk copy

Speculative fix: back off from using -O3 on Android for the inflate
chunk copy code to see if -O3 caused the perf bot regression on the
Android One bot, http://bit.ly/2AfaxhG

Bug: 772870
Change-Id: I06bd941224dacbc5d7024a65934faaa53e4a4ce5
Reviewed-on: https://chromium-review.googlesource.com/823503


Commit-Queue: Noel Gordon <noel@chromium.org>
Reviewed-by: default avatarMike Klein <mtklein@chromium.org>
Reviewed-by: default avatarChris Blume <cblume@chromium.org>
Reviewed-by: default avatarNoel Gordon <noel@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#523679}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 53edf03e13a1569f146f136c9e43bc6e476bf33e
parent 91155b5d
No related branches found
No related tags found
No related merge requests found
......@@ -94,11 +94,13 @@ source_set("zlib_inflate_chunk_simd") {
"contrib/optimizations/inflate.c",
]
if (!is_debug) {
# Use optimize_speed (-O3) to output the _smallest_ code.
configs -= [ "//build/config/compiler:default_optimization" ]
configs += [ "//build/config/compiler:optimize_speed" ]
}
# TODO(772870) back off from -O3 while investigating Android
# One perf bot PNG decode regression.
# if (!is_debug) {
# # Use optimize_speed (-O3) to output the _smallest_ code.
# configs -= [ "//build/config/compiler:default_optimization" ]
# configs += [ "//build/config/compiler:optimize_speed" ]
# }
}
}
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment