Skip to content
Snippets Groups Projects
  • Mike Klein's avatar
    Revert "Reland "zlib: inflate using wider loads and stores"" · 567815a5
    Mike Klein authored
    This reverts commit 0397489124ce7e6aced020f8b85f5034c7d5f49b.
    
    Reason for revert: appears to break Cronet.
    
    Original change's description:
    > Reland "zlib: inflate using wider loads and stores"
    > 
    > This reverts commit e1f30a329eccf19ce1c8772e873abf88970cb65c.
    > 
    > Reason for revert: This patch was originally reverted because
    > we have an ARMv6 build target (part of Cronet) which
    > incorrectly set NEON support in our build files. As a result,
    > the NEON intrinsics were included despite ARMv6 not
    > supporting NEON.
    > 
    > The build problem was addressed here:
    > https://chromium-review.googlesource.com/c/chromium/src/+/639931
    > 
    > Now that ARMv6 builds do not set NEON support, these zlib
    > changes (which are only applied if NEON support is set in the
    > build) will not cause errors on ARMv6 targets.
    > 
    > BUG=697280
    > 
    > Original change's description:
    > > zlib: inflate using wider loads and stores
    > > 
    > > In inflate_fast() the output pointer always has plenty of room to write.  
    > > This means that so long as the target is capable, wide un-aligned 
    > > loads and stores can be used to transfer several bytes at once.
    > > 
    > > When the reference distance is too short simply unroll the data a 
    > > little to increase the distance. Patch by Simon Hosie.
    > > 
    > > PNG decoding performance gains should be around 30-33%.
    > > 
    > > BUG=697280
    > > 
    > > Change-Id: I59854eb25d2b1e43561c8a2afaf9175bf10cf674
    > > Reviewed-on: https://chromium-review.googlesource.com/627098
    
    
    > > Reviewed-by: default avatarAdenilson Cavalcanti <cavalcantii@chromium.org>
    > > Reviewed-by: default avatarMike Klein <mtklein@chromium.org>
    > > Commit-Queue: Adenilson Cavalcanti <cavalcantii@chromium.org>
    > > Cr-Commit-Position: refs/heads/master@{#497866}
    > >
    > 
    > Change-Id: I0b4cd1a393464c960c6a1e48a022a20340781e75
    > Reviewed-on: https://chromium-review.googlesource.com/641575
    
    
    > Commit-Queue: Chris Blume <cblume@chromium.org>
    > Reviewed-by: default avatarAdenilson Cavalcanti <cavalcantii@chromium.org>
    > Reviewed-by: default avatarLeon Scroggins <scroggo@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#498580}
    
    TBR=scroggo@chromium.org,agl@chromium.org,cavalcantii@chromium.org,cblume@chromium.org,mtklein@chromium.org,adenilson.cavalcanti@arm.com
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    
    Bug: 697280
    Change-Id: I200e0e3b9cb9c884acfd6868067464a5f6cef804
    Reviewed-on: https://chromium-review.googlesource.com/669259
    
    
    Reviewed-by: default avatarMike Klein <mtklein@chromium.org>
    Reviewed-by: default avatarAdenilson Cavalcanti <cavalcantii@chromium.org>
    Commit-Queue: Mike Klein <mtklein@chromium.org>
    Cr-Original-Commit-Position: refs/heads/master@{#502474}
    Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
    Cr-Mirrored-Commit: 7a620575b0512b33708e723c260fe66b90b5b103
    567815a5