Skip to content
Snippets Groups Projects
Commit 4197bb04 authored by Eric Dumazet's avatar Eric Dumazet Committed by Victor Tasayco Loarte
Browse files

BACKPORT: tcp: make challenge acks less predictable

(cherry picked from commit 75ff39ccc1bd5d3c455b6822ab09e533c551f758)

CVE-2016-5696

Yue Cao claims that current host rate limiting of challenge ACKS
(RFC 5961) could leak enough information to allow a patient attacker
to hijack TCP sessions. He will soon provide details in an academic
paper.

This patch increases the default limit from 100 to 1000, and adds
some randomization so that the attacker can no longer hijack
sessions without spending a considerable amount of probes.

Based on initial analysis and patch from Linus.

Note that we also have per socket rate limiting, so it is tempting
to remove the host limit in the future.

v2: randomize the count of challenge acks per second, not the period.

Tracked-On: https://jira01.devtools.intel.com/browse/AW-2264


Fixes: 282f23c6 ("tcp: implement RFC 5961 3.2")
Reported-by: default avatarYue Cao <ycao009@ucr.edu>
Signed-off-by: default avatarEric Dumazet <edumazet@google.com>
Suggested-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
Cc: Yuchung Cheng <ycheng@google.com>
Cc: Neal Cardwell <ncardwell@google.com>
Acked-by: default avatarNeal Cardwell <ncardwell@google.com>
Acked-by: default avatarYuchung Cheng <ycheng@google.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
Change-Id: Ib46ba66f5e4a5a7c81bfccd7b0aa83c3d9e1b3bb
Bug: 30809774
Reviewed-on: https://android.intel.com/545361


Reviewed-by: default avatarMahe, Erwan <erwan.mahe@intel.com>
Reviewed-by: default avatarDubray, SimonX <simonx.dubray@intel.com>
Tested-by: default avatarMahe, Erwan <erwan.mahe@intel.com>
Reviewed-by: default avatarTasayco Loarte, VictorX <victorx.tasayco.loarte@intel.com>
Reviewed-by: default avatarMaalem, Saadi <saadi.maalem@intel.com>
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment