Skip to content
Snippets Groups Projects
Commit 3a15c850 authored by Eric Dumazet's avatar Eric Dumazet Committed by jenkins_ndg
Browse files

net: avoid signed overflows for SO_{SND|RCV}BUFFORCE

CAP_NET_ADMIN users should not be allowed to set negative
sk_sndbuf or sk_rcvbuf values, as it can lead to various memory
corruptions, crashes, OOM...

Note that before commit 82981930 ("net: cleanups in
sock_setsockopt()"), the bug was even more serious, since SO_SNDBUF
and SO_RCVBUF were vulnerable.

This needs to be backported to all known linux kernels.

Again, many thanks to syzkaller team for discovering this gem.

Change-Id: I158db8dd09043734287ba70be657881c5185fd71
Tracked-On: https://jira01.devtools.intel.com/browse/AW-4391


Signed-off-by: default avatarEric Dumazet <edumazet@google.com>
Reported-by: default avatarAndrey Konovalov <andreyknvl@google.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
Reviewed-on: https://android.intel.com/569900


Reviewed-by: default avatarLouis, FabienX <fabienx.louis@intel.com>
Tested-by: default avatarLouis, FabienX <fabienx.louis@intel.com>
Reviewed-by: default avatarDeverge, Jean-francoisX <jean-francoisx.deverge@intel.com>
Reviewed-by: default avatarDubray, SimonX <simonx.dubray@intel.com>
Reviewed-by: default avatarAkue, LoicX <loicx.akue@intel.com>
Reviewed-by: default avatarTasayco Loarte, VictorX <victorx.tasayco.loarte@intel.com>
parent b457f294
No related branches found
No related tags found
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment