Skip to content
Snippets Groups Projects
Commit fe0ebeaf authored by Qiu-ji Chen's avatar Qiu-ji Chen Committed by Greg Kroah-Hartman
Browse files

staging: greybus: uart: Fix atomicity violation in get_serial_info()


Our static checker found a bug where set_serial_info() uses a mutex, but
get_serial_info() does not. Fortunately, the impact of this is relatively
minor. It doesn't cause a crash or any other serious issues. However, if a
race condition occurs between set_serial_info() and get_serial_info(),
there is a chance that the data returned by get_serial_info() will be
meaningless.

Signed-off-by: default avatarQiu-ji Chen <chenqiuji666@gmail.com>
Fixes: 0aad5ad5 ("greybus/uart: switch to ->[sg]et_serial()")
Reviewed-by: default avatarJohan Hovold <johan+linaro@kernel.org>
Reviewed-by: default avatarDan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: default avatarAlex Elder <elder@riscstar.com>
Link: https://lore.kernel.org/r/20241107113337.402042-1-chenqiuji666@gmail.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent c4838879
No related branches found
No related tags found
No related merge requests found
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment