Skip to content
Snippets Groups Projects
Unverified Commit c05f1a4e authored by Maxime Ripard's avatar Maxime Ripard
Browse files

drm/bridge: sn65dsi83: Fix bridge removal


Commit 24417d5b ("drm/bridge: ti-sn65dsi83: Implement .detach
callback") moved the unregistration of the bridge DSI device and bridge
itself to the detach callback.

While this is correct for the DSI device detach and unregistration, the
bridge is added in the driver probe, and should thus be removed as part
of its remove callback.

Acked-by: default avatarSam Ravnborg <sam@ravnborg.org>
Reviewed-by: default avatarMarek Vasut <marex@denx.de>
Fixes: 24417d5b ("drm/bridge: ti-sn65dsi83: Implement .detach callback")
Signed-off-by: default avatarMaxime Ripard <maxime@cerno.tech>
Link: https://patchwork.freedesktop.org/patch/msgid/20211025151536.1048186-14-maxime@cerno.tech
parent 7abbc26f
No related branches found
No related tags found
No related merge requests found
......@@ -297,7 +297,6 @@ static void sn65dsi83_detach(struct drm_bridge *bridge)
mipi_dsi_detach(ctx->dsi);
mipi_dsi_device_unregister(ctx->dsi);
drm_bridge_remove(&ctx->bridge);
ctx->dsi = NULL;
}
......@@ -693,6 +692,7 @@ static int sn65dsi83_remove(struct i2c_client *client)
{
struct sn65dsi83 *ctx = i2c_get_clientdata(client);
drm_bridge_remove(&ctx->bridge);
of_node_put(ctx->host_node);
return 0;
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment