Skip to content
Snippets Groups Projects
Commit ba0a3926 authored by Mark Salter's avatar Mark Salter
Browse files

net: stmmac: dwmac-rk: fix oob read in rk_gmac_setup

Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=2122226



commit 0546b224
Author: John Keeping <john@metanate.com>
Date: Tue, 14 Dec 2021 19:10:09 +0000

    KASAN reports an out-of-bounds read in rk_gmac_setup on the line:

    	while (ops->regs[i]) {

    This happens for most platforms since the regs flexible array member is
    empty, so the memory after the ops structure is being read here.  It
    seems that mostly this happens to contain zero anyway, so we get lucky
    and everything still works.

    To avoid adding redundant data to nearly all the ops structures, add a
    new flag to indicate whether the regs field is valid and avoid this loop
    when it is not.

    Fixes: 3bb3d6b1 ("net: stmmac: Add RK3566/RK3568 SoC support")
Signed-off-by: default avatarJohn Keeping <john@metanate.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>

Signed-off-by: default avatarMark Salter <msalter@redhat.com>
parent af8ae374
No related branches found
No related tags found
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment