Skip to content
Snippets Groups Projects
Commit b938b5a2 authored by Guillaume Nault's avatar Guillaume Nault
Browse files

tcp: Fix a data-race around sysctl_tcp_mtu_probe_floor.

Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=2149949


Upstream Status: linux.git

commit 8e92d442
Author: Kuniyuki Iwashima <kuniyu@amazon.com>
Date:   Wed Jul 13 13:52:03 2022 -0700

    tcp: Fix a data-race around sysctl_tcp_mtu_probe_floor.

    While reading sysctl_tcp_mtu_probe_floor, it can be changed concurrently.
    Thus, we need to add READ_ONCE() to its reader.

    Fixes: c04b79b6 ("tcp: add new tcp_mtu_probe_floor sysctl")
Signed-off-by: default avatarKuniyuki Iwashima <kuniyu@amazon.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>

Signed-off-by: default avatarGuillaume Nault <gnault@redhat.com>
parent 33525328
No related merge requests found
......@@ -172,7 +172,7 @@ static void tcp_mtu_probing(struct inet_connection_sock *icsk, struct sock *sk)
} else {
mss = tcp_mtu_to_mss(sk, icsk->icsk_mtup.search_low) >> 1;
mss = min(READ_ONCE(net->ipv4.sysctl_tcp_base_mss), mss);
mss = max(mss, net->ipv4.sysctl_tcp_mtu_probe_floor);
mss = max(mss, READ_ONCE(net->ipv4.sysctl_tcp_mtu_probe_floor));
mss = max(mss, READ_ONCE(net->ipv4.sysctl_tcp_min_snd_mss));
icsk->icsk_mtup.search_low = tcp_mss_to_mtu(sk, mss);
}
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment