Skip to content
Snippets Groups Projects
Commit ac30bb60 authored by Alessandro Astone's avatar Alessandro Astone Committed by Treehugger Robot
Browse files

UPSTREAM: binder: Gracefully handle BINDER_TYPE_FDA objects with num_fds=0


Some android userspace is sending BINDER_TYPE_FDA objects with
num_fds=0. Like the previous patch, this is reproducible when
playing a video.

Before commit 09184ae9 BINDER_TYPE_FDA objects with num_fds=0
were 'correctly handled', as in no fixup was performed.

After commit 09184ae9 we aggregate fixup and skip regions in
binder_ptr_fixup structs and distinguish between the two by using
the skip_size field: if it's 0, then it's a fixup, otherwise skip.
When processing BINDER_TYPE_FDA objects with num_fds=0 we add a
skip region of skip_size=0, and this causes issues because now
binder_do_deferred_txn_copies will think this was a fixup region.

To address that, return early from binder_translate_fd_array to
avoid adding an empty skip region.

Fixes: 09184ae9 ("binder: defer copies of pre-patched txn data")
Acked-by: default avatarTodd Kjos <tkjos@google.com>
Cc: stable <stable@kernel.org>
Signed-off-by: default avatarAlessandro Astone <ales.astone@gmail.com>
Link: https://lore.kernel.org/r/20220415120015.52684-1-ales.astone@gmail.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Bug: 257685302
(cherry picked from commit ef38de92)
Change-Id: I34fab41c0c1beee366a5df4724b263e4385ad13b
Signed-off-by: default avatarCarlos Llamas <cmllamas@google.com>
parent befa134c
No related branches found
No related tags found
No related merge requests found
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment