can: kvaser_usb: Compare requested bittiming parameters with actual parameters...
can: kvaser_usb: Compare requested bittiming parameters with actual parameters in do_set_{,data}_bittiming [ Upstream commit 39d3df6b ] The device will respond with a CMD_ERROR_EVENT command, with error_code KVASER_USB_{LEAF,HYDRA}_ERROR_EVENT_PARAM, if the CMD_SET_BUSPARAMS_REQ contains invalid bittiming parameters. However, this command does not contain any channel reference. To check if the CMD_SET_BUSPARAMS_REQ was successful, redback and compare the requested bittiming parameters with the device reported parameters. Fixes: 080f40a6 ("can: kvaser_usb: Add support for Kvaser CAN/USB devices") Fixes: aec5fb22 ("can: kvaser_usb: Add support for Kvaser USB hydra family") Tested-by:Anssi Hannula <anssi.hannula@bitwise.fi> Co-developed-by:
Anssi Hannula <anssi.hannula@bitwise.fi> Signed-off-by:
Anssi Hannula <anssi.hannula@bitwise.fi> Signed-off-by:
Jimmy Assarsson <extja@kvaser.com> Link: https://lore.kernel.org/all/20221010185237.319219-12-extja@kvaser.com Signed-off-by:
Marc Kleine-Budde <mkl@pengutronix.de> Signed-off-by:
Sasha Levin <sashal@kernel.org>
Showing
- drivers/net/can/usb/kvaser_usb/kvaser_usb.h 12 additions, 3 deletionsdrivers/net/can/usb/kvaser_usb/kvaser_usb.h
- drivers/net/can/usb/kvaser_usb/kvaser_usb_core.c 90 additions, 6 deletionsdrivers/net/can/usb/kvaser_usb/kvaser_usb_core.c
- drivers/net/can/usb/kvaser_usb/kvaser_usb_hydra.c 129 additions, 21 deletionsdrivers/net/can/usb/kvaser_usb/kvaser_usb_hydra.c
- drivers/net/can/usb/kvaser_usb/kvaser_usb_leaf.c 53 additions, 11 deletionsdrivers/net/can/usb/kvaser_usb/kvaser_usb_leaf.c
Loading
Please register or sign in to comment