Skip to content
Snippets Groups Projects
Commit 7f05e20b authored by Andrea della Porta's avatar Andrea della Porta Committed by Rob Herring (Arm)
Browse files

of: address: Preserve the flags portion on 1:1 dma-ranges mapping


A missing or empty dma-ranges in a DT node implies a 1:1 mapping for dma
translations. In this specific case, the current behaviour is to zero out
the entire specifier so that the translation could be carried on as an
offset from zero. This includes address specifier that has flags (e.g.
PCI ranges).

Once the flags portion has been zeroed, the translation chain is broken
since the mapping functions will check the upcoming address specifier
against mismatching flags, always failing the 1:1 mapping and its entire
purpose of always succeeding.

Set to zero only the address portion while passing the flags through.

Fixes: dbbdee94 ("of/address: Merge all of the bus translation code")
Cc: stable@vger.kernel.org
Signed-off-by: default avatarAndrea della Porta <andrea.porta@suse.com>
Tested-by: default avatarHerve Codina <herve.codina@bootlin.com>
Link: https://lore.kernel.org/r/e51ae57874e58a9b349c35e2e877425ebc075d7a.1732441813.git.andrea.porta@suse.com


Signed-off-by: default avatarRob Herring (Arm) <robh@kernel.org>
parent 1a75e81b
No related merge requests found
......@@ -459,7 +459,8 @@ static int of_translate_one(const struct device_node *parent, const struct of_bu
}
if (ranges == NULL || rlen == 0) {
offset = of_read_number(addr, na);
memset(addr, 0, pna * 4);
/* set address to zero, pass flags through */
memset(addr + pbus->flag_cells, 0, (pna - pbus->flag_cells) * 4);
pr_debug("empty ranges; 1:1 translation\n");
goto finish;
}
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment