Skip to content
Snippets Groups Projects
Commit 5f9c55c8 authored by Jordy Zomer's avatar Jordy Zomer Committed by David S. Miller
Browse files

ipv6: check return value of ipv6_skip_exthdr


The offset value is used in pointer math on skb->data.
Since ipv6_skip_exthdr may return -1 the pointer to uh and th
may not point to the actual udp and tcp headers and potentially
overwrite other stuff. This is why I think this should be checked.

EDIT:  added {}'s, thanks Kees

Signed-off-by: default avatarJordy Zomer <jordy@pwning.systems>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 5d2ca2e1
No related branches found
No related tags found
No related merge requests found
......@@ -808,6 +808,12 @@ int esp6_input_done2(struct sk_buff *skb, int err)
struct tcphdr *th;
offset = ipv6_skip_exthdr(skb, offset, &nexthdr, &frag_off);
if (offset < 0) {
err = -EINVAL;
goto out;
}
uh = (void *)(skb->data + offset);
th = (void *)(skb->data + offset);
hdr_len += offset;
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment