Skip to content
Snippets Groups Projects
Commit 586cb22e authored by Waiman Long's avatar Waiman Long
Browse files

objtool: Teach get_alt_entry() about more relocation types

Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=2090231



commit 24ff6525
Author: Peter Zijlstra <peterz@infradead.org>
Date:   Thu, 30 Sep 2021 12:43:10 +0200

    objtool: Teach get_alt_entry() about more relocation types

    Occasionally objtool encounters symbol (as opposed to section)
    relocations in .altinstructions. Typically they are the alternatives
    written by elf_add_alternative() as encountered on a noinstr
    validation run on vmlinux after having already ran objtool on the
    individual .o files.

    Basically this is the counterpart of commit 44f6a7c0 ("objtool:
    Fix seg fault with Clang non-section symbols"), because when these new
    assemblers (binutils now also does this) strip the section symbols,
    elf_add_reloc_to_insn() is forced to emit symbol based relocations.

    As such, teach get_alt_entry() about different relocation types.

    Fixes: 9bc0bb50 ("objtool/x86: Rewrite retpoline thunk calls")
Reported-by: default avatarStephen Rothwell <sfr@canb.auug.org.au>
Reported-by: default avatarBorislav Petkov <bp@alien8.de>
Signed-off-by: default avatarPeter Zijlstra (Intel) <peterz@infradead.org>
Acked-by: default avatarJosh Poimboeuf <jpoimboe@redhat.com>
Tested-by: default avatarNathan Chancellor <nathan@kernel.org>
    Link: https://lore.kernel.org/r/YVWUvknIEVNkPvnP@hirez.programming.kicks-ass.net



Signed-off-by: default avatarWaiman Long <longman@redhat.com>
parent e0895dba
No related branches found
No related tags found
No related merge requests found
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment