Skip to content
Snippets Groups Projects
Commit 4ec4641d authored by Benjamin Gaignard's avatar Benjamin Gaignard Committed by Greg Kroah-Hartman
Browse files

media: usbtv: Remove useless locks in usbtv_video_free()

[ Upstream commit 65e6a277 ]

Remove locks calls in usbtv_video_free() because
are useless and may led to a deadlock as reported here:
https://syzkaller.appspot.com/x/bisect.txt?x=166dc872180000


Also remove usbtv_stop() call since it will be called when
unregistering the device.

Before 'c838530d' this issue would only be noticed if you
disconnect while streaming and now it is noticeable even when
disconnecting while not streaming.

Fixes: c838530d ("media: media videobuf2: Be more flexible on the number of queue stored buffers")
Fixes: f3d27f34 ("[media] usbtv: Add driver for Fushicai USBTV007 video frame grabber")

Signed-off-by: default avatarBenjamin Gaignard <benjamin.gaignard@collabora.com>
Reviewed-by: default avatarTomasz Figa <tfiga@chromium.org>
Tested-by: default avatarHans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: default avatarHans Verkuil <hverkuil-cisco@xs4all.nl>
[hverkuil: fix minor spelling mistake in log message]
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent a73d9964
No related branches found
No related tags found
No related merge requests found
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment