Skip to content
Snippets Groups Projects
Commit 4a9a7f9f authored by Remi Pommarel's avatar Remi Pommarel Committed by Greg Kroah-Hartman
Browse files

batman-adv: Do not let TT changes list grows indefinitely


[ Upstream commit fff8f17c ]

When TT changes list is too big to fit in packet due to MTU size, an
empty OGM is sent expected other node to send TT request to get the
changes. The issue is that tt.last_changeset was not built thus the
originator was responding with previous changes to those TT requests
(see batadv_send_my_tt_response). Also the changes list was never
cleaned up effectively never ending growing from this point onwards,
repeatedly sending the same TT response changes over and over, and
creating a new empty OGM every OGM interval expecting for the local
changes to be purged.

When there is more TT changes that can fit in packet, drop all changes,
send empty OGM and wait for TT request so we can respond with a full
table instead.

Fixes: e1bf0c14 ("batman-adv: tvlv - convert tt data sent within OGMs")
Signed-off-by: default avatarRemi Pommarel <repk@triplefau.lt>
Acked-by: default avatarAntonio Quartulli <Antonio@mandelbit.com>
Signed-off-by: default avatarSven Eckelmann <sven@narfation.org>
Signed-off-by: default avatarSimon Wunderlich <sw@simonwunderlich.de>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent fd0638fa
No related branches found
No related tags found
No related merge requests found
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment