[PATCH] mm: tlb_finish_mmu forget rss
zap_pte_range has been counting the pages it frees in tlb->freed, then tlb_finish_mmu has used that to update the mm's rss. That got stranger when I added anon_rss, yet updated it by a different route; and stranger when rss and anon_rss became mm_counters with special access macros. And it would no longer be viable if we're relying on page_table_lock to stabilize the mm_counter, but calling tlb_finish_mmu outside that lock. Remove the mmu_gather's freed field, let tlb_finish_mmu stick to its own business, just decrement the rss mm_counter in zap_pte_range (yes, there was some point to batching the update, and a subsequent patch restores that). And forget the anal paranoia of first reading the counter to avoid going negative - if rss does go negative, just fix that bug. Remove the mmu_gather's flushes and avoided_flushes from arm and arm26: no use was being made of them. But arm26 alone was actually using the freed, in the way some others use need_flush: give it a need_flush. arm26 seems to prefer spaces to tabs here: respect that. Signed-off-by:Hugh Dickins <hugh@veritas.com> Signed-off-by:
Andrew Morton <akpm@osdl.org> Signed-off-by:
Linus Torvalds <torvalds@osdl.org>
Showing
- arch/sparc64/mm/tlb.c 1 addition, 2 deletionsarch/sparc64/mm/tlb.c
- include/asm-arm/tlb.h 1 addition, 14 deletionsinclude/asm-arm/tlb.h
- include/asm-arm26/tlb.h 13 additions, 22 deletionsinclude/asm-arm26/tlb.h
- include/asm-generic/tlb.h 0 additions, 9 deletionsinclude/asm-generic/tlb.h
- include/asm-ia64/tlb.h 0 additions, 9 deletionsinclude/asm-ia64/tlb.h
- include/asm-sparc64/tlb.h 2 additions, 12 deletionsinclude/asm-sparc64/tlb.h
- mm/memory.c 1 addition, 1 deletionmm/memory.c
Loading
Please register or sign in to comment