Skip to content
Snippets Groups Projects
Commit 89249375 authored by Bart Van Assche's avatar Bart Van Assche
Browse files

ANDROID: scsi: ufs: Add more logging


The logs attached to bug 196797012 show that the error handler has been
activated and also that a SECURITY PROTOCOL OUT command is being
retried but not why. Hence this patch that adds more logging.

Notes:
- The code that initializes the completion status to
  OCS_INVALID_COMMAND_STATUS was introduced by the initial UFS commit.
  See also 7a3e97b0 ("[SCSI] ufshcd: UFS Host controller driver").
- The behavior to retry a command if the controller did not overwrite
  the completion status was introduced by commit e8e7f271 ("scsi:
  ufs: Improve UFS fatal error handling") without explaining why. From
  that commit:

  +       case OCS_INVALID_COMMAND_STATUS:
  +               result |= DID_REQUEUE << 16;
  +               break;

Bug: 196797012
Change-Id: I86ce4149babde1daf07af94464b878e9e697b37b
Signed-off-by: default avatarBart Van Assche <bvanassche@google.com>
parent 5b153f18
No related branches found
No related tags found
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment