Skip to content
Snippets Groups Projects
Commit 03c74f54 authored by Gavrilov Ilia's avatar Gavrilov Ilia Committed by Sasha Levin
Browse files

udp: fix incorrect parameter validation in the udp_lib_getsockopt() function


[ Upstream commit 4bb3ba7b ]

The 'len' variable can't be negative when assigned the result of
'min_t' because all 'min_t' parameters are cast to unsigned int,
and then the minimum one is chosen.

To fix the logic, check 'len' as read from 'optlen',
where the types of relevant variables are (signed) int.

Fixes: 1da177e4 ("Linux-2.6.12-rc2")
Reviewed-by: default avatarWillem de Bruijn <willemb@google.com>
Signed-off-by: default avatarGavrilov Ilia <Ilia.Gavrilov@infotecs.ru>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent b42e5643
No related branches found
No related tags found
No related merge requests found
......@@ -2748,11 +2748,11 @@ int udp_lib_getsockopt(struct sock *sk, int level, int optname,
if (get_user(len, optlen))
return -EFAULT;
len = min_t(unsigned int, len, sizeof(int));
if (len < 0)
return -EINVAL;
len = min_t(unsigned int, len, sizeof(int));
switch (optname) {
case UDP_CORK:
val = READ_ONCE(up->corkflag);
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment