- Mar 27, 2025
-
-
Augusto Caringi authored
Signed-off-by:Augusto Caringi <acaringi@redhat.com>
-
Augusto Caringi authored
MR: https://gitlab.com/redhat/centos-stream/src/kernel/centos-stream-9/-/merge_requests/6621 JIRA: https://issues.redhat.com/browse/RHEL-83988 Brew: https://brewweb.engineering.redhat.com/brew/taskinfo?taskID=67074892 Upstream Status: commits are found in Linus's git tree Upstream Status: RHEL-Only Omitted-Fix: e8a7824856def1c8608401b0d7d05566d6e81c95 Signed-off-by:
Nigel Croxon <ncroxon@redhat.com> Approved-by:
Vladis Dronov <vdronov@redhat.com> Approved-by:
Xiao Ni <xni@redhat.com> Approved-by:
Heinz Mauelshagen <heinzm@redhat.com> Approved-by:
CKI KWF Bot <cki-ci-bot+kwf-gitlab-com@redhat.com> Merged-by:
-
Augusto Caringi authored
Merge: [RHEL 9.7] NULL pointer dereference in bpf_sk_storage_tracing_allowed() when attaching BPF program to non-vmlinux BTF MR: https://gitlab.com/redhat/centos-stream/src/kernel/centos-stream-9/-/merge_requests/6524 JIRA: https://issues.redhat.com/browse/RHEL-82439 ``` commit 7332537962956fab2c055b37e5e2e6a0d2a8d6bf Author: Jared Kangas <jkangas@redhat.com> Date: Tue Jan 21 06:25:04 2025 -0800 bpf: Remove unnecessary BTF lookups in bpf_sk_storage_tracing_allowed When loading BPF programs, bpf_sk_storage_tracing_allowed() does a series of lookups to get a type name from the program's attach_btf_id, making the assumption that the type is present in the vmlinux BTF along the way. However, this results in btf_type_by_id() returning a null pointer if a non-vmlinux kernel BTF is attached to. Proof-of-concept on a kernel with CONFIG_IPV6=m: $ cat bpfcrash.c #include <unistd.h> #include <linux/bpf.h> #include <sys/syscall.h> static int bpf(enum bpf_cmd cmd, union bpf_attr *attr) { return syscall(__NR_bpf, cmd, attr, sizeof(*attr)); } int main(void) { const int btf_fd = bpf(BPF_BTF_GET_FD_BY_ID, &(union bpf_attr) { .btf_id = BTF_ID, }); if (btf_fd < 0) return 1; const int bpf_sk_storage_get = 107; const struct bpf_insn insns[] = { { .code = BPF_JMP | BPF_CALL, .imm = bpf_sk_storage_get}, { .code = BPF_JMP | BPF_EXIT }, }; return bpf(BPF_PROG_LOAD, &(union bpf_attr) { .prog_type = BPF_PROG_TYPE_TRACING, .expected_attach_type = BPF_TRACE_FENTRY, .license = (unsigned long)"GPL", .insns = (unsigned long)&insns, .insn_cnt = sizeof(insns) / sizeof(insns[0]), .attach_btf_obj_fd = btf_fd, .attach_btf_id = TYPE_ID, }); } $ sudo bpftool btf list | grep ipv6 2: name [ipv6] size 928200B $ sudo bpftool btf dump id 2 | awk '$3 ~ /inet6_sock_destruct/' [130689] FUNC 'inet6_sock_destruct' type_id=130677 linkage=static $ gcc -D_DEFAULT_SOURCE -DBTF_ID=2 -DTYPE_ID=130689 \ bpfcrash.c -o bpfcrash $ sudo ./bpfcrash This causes a null pointer dereference: Unable to handle kernel NULL pointer dereference at virtual address 0000000000000000 Call trace: bpf_sk_storage_tracing_allowed+0x8c/0xb0 P check_helper_call.isra.0+0xa8/0x1730 do_check+0xa18/0xb40 do_check_common+0x140/0x640 bpf_check+0xb74/0xcb8 bpf_prog_load+0x598/0x9a8 __sys_bpf+0x580/0x980 __arm64_sys_bpf+0x28/0x40 invoke_syscall.constprop.0+0x54/0xe8 do_el0_svc+0xb4/0xd0 el0_svc+0x44/0x1f8 el0t_64_sync_handler+0x13c/0x160 el0t_64_sync+0x184/0x188 Resolve this by using prog->aux->attach_func_name and removing the lookups. Fixes: 8e4597c6 ("bpf: Allow using bpf_sk_storage in FENTRY/FEXIT/RAW_TP") Suggested-by:
Martin KaFai Lau <martin.lau@linux.dev> Signed-off-by:
Jared Kangas <jkangas@redhat.com> Signed-off-by:
Martin KaFai Lau <martin.lau@kernel.org> Link: https://patch.msgid.link/20250121142504.1369436-1-jkangas@redhat.com Signed-off-by:
Alexei Starovoitov <ast@kernel.org>```> Signed-off-by:
CKI Backport Bot <cki-ci-bot+cki-gitlab-backport-bot@redhat.com> --- <small>Created 2025-03-06 16:33 UTC by backporter - [KWF FAQ](https://red.ht/kernel_workflow_doc) - [Slack #team-kernel-workflow](https://redhat-internal.slack.com/archives/C04LRUPMJQ5) - [Source](https://gitlab.com/cki-project/kernel-workflow/-/blob/main/webhook/utils/backporter.py) - [Documentation](https://gitlab.com/cki-project/kernel-workflow/-/blob/main/docs/README.backporter.md) - [Report an issue](https://gitlab.com/cki-project/kernel-workflow/-/issues/new?issue%5Btitle%5D=backporter%20webhook%20issue)</small > Approved-by:
Antoine Tenart <atenart@redhat.com> Approved-by:
Radu Rendec <rrendec@redhat.com> Approved-by:
-
Augusto Caringi authored
MR: https://gitlab.com/redhat/centos-stream/src/kernel/centos-stream-9/-/merge_requests/6618 JIRA: https://issues.redhat.com/browse/RHEL-45097 JIRA: https://issues.redhat.com/browse/RHEL-47460 JIRA: https://issues.redhat.com/browse/RHEL-84464 Signed-off-by:
David Arcari <darcari@redhat.com> Approved-by:
Lenny Szubowicz <lszubowi@redhat.com> Approved-by:
Steve Best <sbest@redhat.com> Approved-by:
-
Augusto Caringi authored
MR: https://gitlab.com/redhat/centos-stream/src/kernel/centos-stream-9/-/merge_requests/6423 JIRA: https://issues.redhat.com/browse/RHEL-79933 commit db5fd3cf8bf41b84b577b8ad5234ea95f327c9be Author: Muhammad Adeel <Muhammad.Adeel@ibm.com> Date: Fri, 7 Feb 2025 14:24:32 +0000 cgroup: Remove steal time from usage_usec The CPU usage time is the time when user, system or both are using the CPU. Steal time is the time when CPU is waiting to be run by the Hypervisor. It should not be added to the CPU usage time, hence removing it from the usage_usec entry. Fixes: 936f2a70 ("cgroup: add cpu.stat file to root cgroup") Acked-by:
Axel Busch <axel.busch@ibm.com> Acked-by:
Michal Koutný <mkoutny@suse.com> Signed-off-by:
Muhammad Adeel <muhammad.adeel@ibm.com> Signed-off-by:
Tejun Heo <tj@kernel.org> Signed-off-by:
Waiman Long <longman@redhat.com> Approved-by:
Thomas Huth <thuth@redhat.com> Approved-by:
Radostin Stoyanov <rstoyano@redhat.com> Approved-by:
Phil Auld <pauld@redhat.com> Approved-by:
-
Augusto Caringi authored
MR: https://gitlab.com/redhat/centos-stream/src/kernel/centos-stream-9/-/merge_requests/6549 Backport a series of improvements to dirty_log_test that make this test more robust, and in particular make it work in L1 Also backport a minor fix to KVM which needs to be present in L1 kernel to avoid the test failing, when run on Intel. JIRA: https://issues.redhat.com/browse/RHEL-67879 Tested: run the test few times Signed-off-by:
Maxim Levitsky <mlevitsk@redhat.com> Approved-by:
Vitaly Kuznetsov <vkuznets@redhat.com> Approved-by:
Cathy Avery <cavery@redhat.com> Approved-by:
-
Augusto Caringi authored
MR: https://gitlab.com/redhat/centos-stream/src/kernel/centos-stream-9/-/merge_requests/6428 JIRA: https://issues.redhat.com/browse/RHEL-71452 Upstream Status: RHEL only When in kdump we don't need any messaging about deprecated status. The kernel is limited to a single cpu single cpu by default which causes false messaging to show every time. Fix this by inverting the kdump boot test. To get proper messaging during standar boot. Signed-off-by:
Tomas Henzl <thenzl@redhat.com> Approved-by:
-
Augusto Caringi authored
MR: https://gitlab.com/redhat/centos-stream/src/kernel/centos-stream-9/-/merge_requests/6419 JIRA: https://issues.redhat.com/browse/RHEL-33903 Backport file verification with LSM and fsverity and associated BPF selftests Signed-off-by:
Gregory Bell <grbell@redhat.com> Approved-by:
Viktor Malik <vmalik@redhat.com> Approved-by:
Jerome Marchand <jmarchan@redhat.com> Approved-by:
-
Augusto Caringi authored
MR: https://gitlab.com/redhat/centos-stream/src/kernel/centos-stream-9/-/merge_requests/6418 JIRA: https://issues.redhat.com/browse/RHEL-78971 ``` commit 6d7bc938adca9024a6b51cf55d9b0542b653b69c Author: Luiz Capitulino <luizcap@redhat.com> Date: Mon Feb 10 22:48:56 2025 -0500 mm: hugetlb: avoid fallback for specific node allocation of 1G pages When using the HugeTLB kernel command-line to allocate 1G pages from a specific node, such as: default_hugepagesz=1G hugepages=1:1 If node 1 happens to not have enough memory for the requested number of 1G pages, the allocation falls back to other nodes. A quick way to reproduce this is by creating a KVM guest with a memory-less node and trying to allocate 1 1G page from it. Instead of failing, the allocation will fallback to other nodes. This defeats the purpose of node specific allocation. Also, specific node allocation for 2M pages don't have this behavior: the allocation will just fail for the pages it can't satisfy. This issue happens because HugeTLB calls memblock_alloc_try_nid_raw() for 1G boot-time allocation as this function falls back to other nodes if the allocation can't be satisfied. Use memblock_alloc_exact_nid_raw() instead, which ensures that the allocation will only be satisfied from the specified node. Link: https://lkml.kernel.org/r/20250211034856.629371-1-luizcap@redhat.com Fixes: b5389086ad7b ("hugetlbfs: extend the definition of hugepages parameter to support node allocation") Signed-off-by:
Luiz Capitulino <luizcap@redhat.com> Acked-by:
Oscar Salvador <osalvador@suse.de> Acked-by:
David Hildenbrand <david@redhat.com> Cc: "Mike Rapoport (IBM)" <rppt@kernel.org> Cc: Muchun Song <muchun.song@linux.dev> Cc: Zhenguo Yao <yaozhenguo1@gmail.com> Cc: Frank van der Linden <fvdl@google.com> Signed-off-by:
Andrew Morton <akpm@linux-foundation.org>```> Signed-off-by:
Aristeu Rozanski <arozansk@redhat.com> Approved-by:
Herton R. Krzesinski <herton@redhat.com> Approved-by:
Rafael Aquini <raquini@redhat.com> Approved-by:
-
Augusto Caringi authored
MR: https://gitlab.com/redhat/centos-stream/src/kernel/centos-stream-9/-/merge_requests/6609 JIRA: https://issues.redhat.com/browse/RHEL-70421 ``` commit 45f745dd1ac880ce299c0f92b874cda090ddade6 Author: Zijun Hu <quic_zijuhu@quicinc.com> Date: Fri Sep 20 02:58:14 2024 -0700 Bluetooth: btusb: Add one more ID 0x0489:0xe0f3 for Qualcomm WCN785x Add one more part with ID (0x0489, 0xe0f3) to usb_device_id table for Qualcomm WCN785x, and its device info from /sys/kernel/debug/usb/devices is shown below: T: Bus=01 Lev=01 Prnt=01 Port=13 Cnt=03 Dev#= 4 Spd=12 MxCh= 0 D: Ver= 1.10 Cls=e0(wlcon) Sub=01 Prot=01 MxPS=64 #Cfgs= 1 P: Vendor=0489 ProdID=e0f3 Rev= 0.01 C:* #Ifs= 2 Cfg#= 1 Atr=e0 MxPwr=100mA I:* If#= 0 Alt= 0 #EPs= 3 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb E: Ad=81(I) Atr=03(Int.) MxPS= 16 Ivl=1ms E: Ad=82(I) Atr=02(Bulk) MxPS= 64 Ivl=0ms E: Ad=02(O) Atr=02(Bulk) MxPS= 64 Ivl=0ms I:* If#= 1 Alt= 0 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb E: Ad=83(I) Atr=01(Isoc) MxPS= 0 Ivl=1ms E: Ad=03(O) Atr=01(Isoc) MxPS= 0 Ivl=1ms I: If#= 1 Alt= 1 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb E: Ad=83(I) Atr=01(Isoc) MxPS= 9 Ivl=1ms E: Ad=03(O) Atr=01(Isoc) MxPS= 9 Ivl=1ms I: If#= 1 Alt= 2 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb E: Ad=83(I) Atr=01(Isoc) MxPS= 17 Ivl=1ms E: Ad=03(O) Atr=01(Isoc) MxPS= 17 Ivl=1ms I: If#= 1 Alt= 3 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb E: Ad=83(I) Atr=01(Isoc) MxPS= 25 Ivl=1ms E: Ad=03(O) Atr=01(Isoc) MxPS= 25 Ivl=1ms I: If#= 1 Alt= 4 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb E: Ad=83(I) Atr=01(Isoc) MxPS= 33 Ivl=1ms E: Ad=03(O) Atr=01(Isoc) MxPS= 33 Ivl=1ms I: If#= 1 Alt= 5 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb E: Ad=83(I) Atr=01(Isoc) MxPS= 49 Ivl=1ms E: Ad=03(O) Atr=01(Isoc) MxPS= 49 Ivl=1ms I: If#= 1 Alt= 6 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb E: Ad=83(I) Atr=01(Isoc) MxPS= 63 Ivl=1ms E: Ad=03(O) Atr=01(Isoc) MxPS= 63 Ivl=1ms I: If#= 1 Alt= 7 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb E: Ad=83(I) Atr=01(Isoc) MxPS= 65 Ivl=1ms E: Ad=03(O) Atr=01(Isoc) MxPS= 65 Ivl=1ms Signed-off-by:
Zijun Hu <quic_zijuhu@quicinc.com> Signed-off-by:
Luiz Augusto von Dentz <luiz.von.dentz@intel.com>```> Signed-off-by:
José Ignacio Tornos Martínez <jtornosm@redhat.com> Approved-by:
Bastien Nocera <bnocera@redhat.com> Approved-by:
-
Augusto Caringi authored
MR: https://gitlab.com/redhat/centos-stream/src/kernel/centos-stream-9/-/merge_requests/6603 JIRA: https://issues.redhat.com/browse/RHEL-84144 Omitted-fix: 79f7319908fb ("can: mcp251xfd: __mcp251xfd_get_berr_counter(): use CAN_BUS_OFF_THRESHOLD instead of open coding it") Incorrectly identified as a fix by the KWF bot. This commit just mentions 3f9c26210cf8 ("can: error: add definitions for the different CAN error thresholds") in the description but it's NOT a fix for it. The scope of this upgrade is the CAN bus core (essentially net/can/), and it does not include the CAN bus interface drivers (drivers/net/can/). Signed-off-by:
Aaron Brookner <abrookne@redhat.com> Approved-by:
Davide Caratti <dcaratti@redhat.com> Approved-by:
-
- Mar 24, 2025
-
-
Augusto Caringi authored
Signed-off-by: -
Augusto Caringi authored
MR: https://gitlab.com/redhat/centos-stream/src/kernel/centos-stream-9/-/merge_requests/6615 ``` JIRA: https://issues.redhat.com/browse/RHEL-81906 This series includes a set of key fixes related to PCIe's bandwidth link training from upstream v6.13 by taking in content from upstream merge request d957ff7acaf2 "Merge branch 'pci/bwctrl'". Signed-off-by:
Myron Stowe <mstowe@redhat.com> ``` Approved-by:
John W. Linville <linville@redhat.com> Approved-by:
Desnes Nunes <desnesn@redhat.com> Approved-by:
Tony Camuso <tcamuso@redhat.com> Merged-by:
-
Augusto Caringi authored
MR: https://gitlab.com/redhat/centos-stream/src/kernel/centos-stream-9/-/merge_requests/6390 JIRA: https://issues.redhat.com/browse/RHEL-79821 The following upstream commits were not applied due to scope: 66bc1a173328 treewide: Use sysfs_bin_attr_simple_read() helper 4a62d588a84e thermal: core: Eliminate writable trip points masks dd64594ca2c5 thermal: Switch back to struct platform_driver::remove() cdd30ebb1b9f module: Convert symbol namespace to string literal Upstream commit 423de5b5bc5b is included in this patchset as it provides a fix for upstream 94c6110b0b13 which was included in a recent update to drivers/thermal Signed-off-by:
-
Augusto Caringi authored
MR: https://gitlab.com/redhat/centos-stream/src/kernel/centos-stream-9/-/merge_requests/6547 Description: Updates for powerpc perf mem data JIRA: https://issues.redhat.com/browse/RHEL-80602 Build Info: https://brewweb.engineering.redhat.com/brew/taskinfo?taskID=66923908 Tested: Verified Brew build test kernel RPMs Signed-off-by:
Mamatha Inamdar <minamdar@redhat.com> Approved-by:
-
Augusto Caringi authored
MR: https://gitlab.com/redhat/centos-stream/src/kernel/centos-stream-9/-/merge_requests/6514 JIRA: https://issues.redhat.com/browse/RHEL-81929 commit 747ae81883d21595b162cc40523a982024700fed Author: Joachim Vandersmissen <git@jvdsn.com> Date: Sun May 12 23:55:07 2024 -0500 certs: Add ECDSA signature verification self-test Commit c27b2d2012e1 ("crypto: testmgr - allow ecdsa-nist-p256 and -p384 in FIPS mode") enabled support for ECDSA in crypto/testmgr.c. The PKCS#7 signature verification API builds upon the KCAPI primitives to perform its high-level operations. Therefore, this change in testmgr.c also allows ECDSA to be used by the PKCS#7 signature verification API (in FIPS mode). However, from a FIPS perspective, the PKCS#7 signature verification API is a distinct "service" from the KCAPI primitives. This is because the PKCS#7 API performs a "full" signature verification, which consists of both hashing the data to be verified, and the public key operation. On the other hand, the KCAPI primitive does not perform this hashing step - it accepts pre-hashed data from the caller and only performs the public key operation. For this reason, the ECDSA self-tests in crypto/testmgr.c are not sufficient to cover ECDSA signature verification offered by the PKCS#7 API. This is reflected by the self-test already present in this file for RSA PKCS#1 v1.5 signature verification. The solution is simply to add a second self-test here for ECDSA. P-256 with SHA-256 hashing was chosen as those parameters should remain FIPS-approved for the foreseeable future, while keeping the performance impact to a minimum. The ECDSA certificate and PKCS#7 signed data was generated using OpenSSL. The input data is identical to the input data for the existing RSA self-test. Signed-off-by:
Joachim Vandersmissen <git@jvdsn.com> Reviewed-by:
Jarkko Sakkinen <jarkko@kernel.org> Acked-by:
Herbert Xu <herbert@gondor.apana.org.au> Signed-off-by:
Herbert Xu <herbert.xu@redhat.com> Approved-by:
Coiby Xu <coxu@redhat.com> Approved-by:
Clemens Lang <cllang@redhat.com> Approved-by:
-
Augusto Caringi authored
MR: https://gitlab.com/redhat/centos-stream/src/kernel/centos-stream-9/-/merge_requests/6413 JIRA: https://issues.redhat.com/browse/RHEL-77838 Patches: `a1afb959add1f ("dpll: add clock quality level attribute and op") ` Signed-off-by:
Petr Oros <poros@redhat.com> Approved-by:
Ivan Vecera <ivecera@redhat.com> Approved-by:
Michal Schmidt <mschmidt@redhat.com> Approved-by:
-
Augusto Caringi authored
MR: https://gitlab.com/redhat/centos-stream/src/kernel/centos-stream-9/-/merge_requests/6475 JIRA: https://issues.redhat.com/browse/RHEL-81489 CVE: CVE-2024-58005 ``` commit a3a860bc0fd6c07332e4911cf9a238d20de90173 Author: Jarkko Sakkinen <jarkko@kernel.org> Date: Fri Dec 27 17:39:09 2024 +0200 tpm: Change to kvalloc() in eventlog/acpi.c The following failure was reported on HPE ProLiant D320: [ 10.693310][ T1] tpm_tis STM0925:00: 2.0 TPM (device-id 0x3, rev-id 0) [ 10.848132][ T1] ------------[ cut here ]------------ [ 10.853559][ T1] WARNING: CPU: 59 PID: 1 at mm/page_alloc.c:4727 __alloc_pages_noprof+0x2ca/0x330 [ 10.862827][ T1] Modules linked in: [ 10.866671][ T1] CPU: 59 UID: 0 PID: 1 Comm: swapper/0 Not tainted 6.12.0-lp155.2.g52785e2-default #1 openSUSE Tumbleweed (unreleased) 588cd98293a7c9eba9013378d807364c088c9375 [ 10.882741][ T1] Hardware name: HPE ProLiant DL320 Gen12/ProLiant DL320 Gen12, BIOS 1.20 10/28/2024 [ 10.892170][ T1] RIP: 0010:__alloc_pages_noprof+0x2ca/0x330 [ 10.898103][ T1] Code: 24 08 e9 4a fe ff ff e8 34 36 fa ff e9 88 fe ff ff 83 fe 0a 0f 86 b3 fd ff ff 80 3d 01 e7 ce 01 00 75 09 c6 05 f8 e6 ce 01 01 <0f> 0b 45 31 ff e9 e5 fe ff ff f7 c2 00 00 08 00 75 42 89 d9 80 e1 [ 10.917750][ T1] RSP: 0000:ffffb7cf40077980 EFLAGS: 00010246 [ 10.923777][ T1] RAX: 0000000000000000 RBX: 0000000000040cc0 RCX: 0000000000000000 [ 10.931727][ T1] RDX: 0000000000000000 RSI: 000000000000000c RDI: 0000000000040cc0 The above transcript shows that ACPI pointed a 16 MiB buffer for the log events because RSI maps to the 'order' parameter of __alloc_pages_noprof(). Address the bug by moving from devm_kmalloc() to devm_add_action() and kvmalloc() and devm_add_action(). Suggested-by:
Ard Biesheuvel <ardb@kernel.org> Cc: stable@vger.kernel.org # v2.6.16+ Fixes: 55a82ab3 ("[PATCH] tpm: add bios measurement log") Reported-by:
Andy Liang <andy.liang@hpe.com> Closes: https://bugzilla.kernel.org/show_bug.cgi?id=219495 Reviewed-by:
Stefan Berger <stefanb@linux.ibm.com> Reviewed-by:
Takashi Iwai <tiwai@suse.de> Tested-by:
Jarkko Sakkinen <jarkko@kernel.org>```> Signed-off-by:
Štěpán Horáček <shoracek@redhat.com> Approved-by:
Jerry Snitselaar <jsnitsel@redhat.com> Approved-by:
-
Augusto Caringi authored
MR: https://gitlab.com/redhat/centos-stream/src/kernel/centos-stream-9/-/merge_requests/6599 JIRA: https://issues.redhat.com/browse/RHEL-74363 This patch is a backport of the following upstream commit: commit 67a2f86846f244d81601cf2e1552c4656b8556d6 Author: Rafael Aquini <raquini@redhat.com> Date: Tue Feb 18 14:22:51 2025 -0500 selftests/mm: run_vmtests.sh: fix half_ufd_size_MB calculation We noticed that uffd-stress test was always failing to run when invoked for the hugetlb profiles on x86_64 systems with a processor count of 64 or bigger: ... ... not ok 3 uffd-stress hugetlb 128 32 # exit=1 ... The problem boils down to how run_vmtests.sh (mis)calculates the size of the region it feeds to uffd-stress. The latter expects to see an amount of MiB while the former is just giving out the number of free hugepages halved down. This measurement discrepancy ends up violating uffd-stress' assertion on number of hugetlb pages allocated per CPU, causing it to bail out with the error above. This commit fixes that issue by adjusting run_vmtests.sh's half_ufd_size_MB calculation so it properly renders the region size in MiB, as expected, while maintaining all of its original constraints in place. Link: https://lkml.kernel.org/r/20250218192251.53243-1-aquini@redhat.com Fixes: 2e47a445d7b3 ("selftests/mm: run_vmtests.sh: fix hugetlb mem size calculation") Signed-off-by:
Peter Xu <peterx@redhat.com> Cc: Shuah Khan <shuah@kernel.org> Cc: <stable@vger.kernel.org> Signed-off-by:
Andrew Morton <akpm@linux-foundation.org> Signed-off-by:
Nico Pache <npache@redhat.com> Approved-by:
-
Augusto Caringi authored
MR: https://gitlab.com/redhat/centos-stream/src/kernel/centos-stream-9/-/merge_requests/6566 JIRA: https://issues.redhat.com/browse/RHEL-81542 Upstream Status: linux.git CVE: CVE-2025-21791 Signed-off-by:
Guillaume Nault <gnault@redhat.com> Approved-by:
Florian Westphal <fwestpha@redhat.com> Approved-by:
-
Augusto Caringi authored
MR: https://gitlab.com/redhat/centos-stream/src/kernel/centos-stream-9/-/merge_requests/6593 JIRA: https://issues.redhat.com/browse/RHEL-83858 Signed-off-by:
Paulo Alcantara <paalcant@redhat.com> Approved-by:
Jay Shin <jaeshin@redhat.com> Approved-by:
Benjamin Coddington <bcodding@redhat.com> Approved-by:
Scott Mayhew <smayhew@redhat.com> Approved-by:
-
- Mar 21, 2025
-
-
Nigel Croxon authored
JIRA: https://issues.redhat.com/browse/RHEL-83988 commit 5fbcf76e0dfe68578ffa2a8a691cc44cf586ae35 Author: Zheng Qixing <zhengqixing@huawei.com> Date: Sat Feb 15 10:01:37 2025 +0800 md/raid1: fix memory leak in raid1_run() if no active rdev When `raid1_set_limits()` fails or when the array has no active `rdev`, the allocated memory for `conf` is not properly freed. Add raid1_free() call to properly free the conf in error path. Fixes: 799af947ed13 ("md/raid1: don't free conf on raid0_run failure") Signed-off-by:
Zheng Qixing <zhengqixing@huawei.com> Link: https://lore.kernel.org/linux-raid/20250215020137.3703757-1-zhengqixing@huaweicloud.com Singed-off-by:
Yu Kuai <yukuai3@huawei.com> Signed-off-by:
-
Nigel Croxon authored
JIRA: https://issues.redhat.com/browse/RHEL-83988 commit 799af947ed132956d6de6d77a5bc053817ccb06b Author: Christoph Hellwig <hch@lst.de> Date: Thu Jun 13 10:48:13 2024 +0200 md/raid1: don't free conf on raid0_run failure The core md code calls the ->free method which already frees conf. Fixes: 07f1a685 ("md/raid1: fail run raid1 array when active disk less than one") Signed-off-by:
Christoph Hellwig <hch@lst.de> Reviewed-by:
Martin K. Petersen <martin.petersen@oracle.com> Link: https://lore.kernel.org/r/20240613084839.1044015-4-hch@lst.de Signed-off-by:
Jens Axboe <axboe@kernel.dk> Signed-off-by:
-
Nigel Croxon authored
JIRA: https://issues.redhat.com/browse/RHEL-83988 commit d11854ed05635e4a73fa61a988ffdd0978c9e202 Author: Christoph Hellwig <hch@lst.de> Date: Thu Jun 13 10:48:12 2024 +0200 md/raid0: don't free conf on raid0_run failure The core md code calls the ->free method which already frees conf. Fixes: 0c031fd37f69 ("md: Move alloc/free acct bioset in to personality") Signed-off-by:
-
Nigel Croxon authored
JIRA: https://issues.redhat.com/browse/RHEL-83988 Upstream status: RHEL-Only Remove the global list 'pers_list', and switch to use md_submodule_head, which is managed by xarry. Prepare to unify registration and unregistration for all sub modules. Signed-off-by:
-
Nigel Croxon authored
JIRA: https://issues.redhat.com/browse/RHEL-83988 commit 20238d49448cdb406da2b9bd3e50f892b26da318 Author: Dr. David Alan Gilbert <linux@treblig.org> Date: Sun Sep 29 14:21:48 2024 +0100 async_xor: Remove unused 'async_xor_val' async_xor_val has been unused since commit a7c224a8 ("md/raid5: convert to new xor compution interface") Remove it. Signed-off-by:
Dr. David Alan Gilbert <linux@treblig.org> Signed-off-by:
-
Nigel Croxon authored
JIRA: https://issues.redhat.com/browse/RHEL-83988 commit 3db4404435397a345431b45f57876a3df133f3b4 Author: Xiao Ni <xni@redhat.com> Date: Thu Mar 6 17:49:38 2025 +0800 md/raid10: wait barrier before returning discard request with REQ_NOWAIT raid10_handle_discard should wait barrier before returning a discard bio which has REQ_NOWAIT. And there is no need to print warning calltrace if a discard bio has REQ_NOWAIT flag. Quality engineer usually checks dmesg and reports error if dmesg has warning/error calltrace. Fixes: c9aa889b035f ("md: raid10 add nowait support") Signed-off-by:
Coly Li <colyli@kernel.org> Link: https://lore.kernel.org/linux-raid/20250306094938.48952-1-xni@redhat.com Signed-off-by:
-
Nigel Croxon authored
JIRA: https://issues.redhat.com/browse/RHEL-83988 commit 6130825f34d41718c98a9b1504a79a23e379701e Author: Su Yue <glass.su@suse.com> Date: Mon Mar 3 11:39:18 2025 +0800 md/md-bitmap: fix wrong bitmap_limit for clustermd when write sb In clustermd, separate write-intent-bitmaps are used for each cluster node: 0 4k 8k 12k ------------------------------------------------------------------- | idle | md super | bm super [0] + bits | | bm bits[0, contd] | bm super[1] + bits | bm bits[1, contd] | | bm super[2] + bits | bm bits [2, contd] | bm super[3] + bits | | bm bits [3, contd] | | | So in node 1, pg_index in __write_sb_page() could equal to bitmap->storage.file_pages. Then bitmap_limit will be calculated to 0. md_super_write() will be called with 0 size. That means the first 4k sb area of node 1 will never be updated through filemap_write_page(). This bug causes hang of mdadm/clustermd_tests/01r1_Grow_resize. Here use (pg_index % bitmap->storage.file_pages) to make calculation of bitmap_limit correct. Fixes: ab99a87542f1 ("md/md-bitmap: fix writing non bitmap pages") Signed-off-by:
Su Yue <glass.su@suse.com> Reviewed-by:
Heming Zhao <heming.zhao@suse.com> Link: https://lore.kernel.org/linux-raid/20250303033918.32136-1-glass.su@suse.com Signed-off-by:
-
Nigel Croxon authored
JIRA: https://issues.redhat.com/browse/RHEL-83988 commit e879a0d9cb086c8e52ce6c04e5bfa63825a6213c Author: Yu Kuai <yukuai3@huawei.com> Date: Thu Feb 27 20:16:57 2025 +0800 md/raid1,raid10: don't ignore IO flags If blk-wbt is enabled by default, it's found that raid write performance is quite bad because all IO are throttled by wbt of underlying disks, due to flag REQ_IDLE is ignored. And turns out this behaviour exist since blk-wbt is introduced. Other than REQ_IDLE, other flags should not be ignored as well, for example REQ_META can be set for filesystems, clearing it can cause priority reverse problems; And REQ_NOWAIT should not be cleared as well, because io will wait instead of failing directly in underlying disks. Fix those problems by keep IO flags from master bio. Fises: f51d46d0e7cb ("md: add support for REQ_NOWAIT") Fixes: e34cbd30 ("blk-wbt: add general throttling mechanism") Fixes: 5404bc7a ("[PATCH] Allow file systems to differentiate between data and meta reads") Link: https://lore.kernel.org/linux-raid/20250227121657.832356-1-yukuai1@huaweicloud.com Signed-off-by:
-
Nigel Croxon authored
JIRA: https://issues.redhat.com/browse/RHEL-83988 commit 1320fe874175fac395fa693195db68b2001c4d8f Author: Yu Kuai <yukuai3@huawei.com> Date: Thu Feb 27 20:04:52 2025 +0800 md/raid5: merge reshape_progress checking inside get_reshape_loc() During code review, it's found that other than raid5_bitmap_sector(), reshape_progress is always checked before get_reshape_loc(), while raid5_bitmap_sector() should check as well to prevent holding the lock 'conf->device_lock'. Hence merge that checking inside get_reshape_loc(). Link: https://lore.kernel.org/linux-raid/20250227120452.808503-1-yukuai1@huaweicloud.com Signed-off-by:
-
Nigel Croxon authored
JIRA: https://issues.redhat.com/browse/RHEL-83988 commit 8542870237c3a48ff049b6c5df5f50c8728284fa Author: Yu Kuai <yukuai3@huawei.com> Date: Thu Feb 20 20:43:48 2025 +0800 md: fix mddev uaf while iterating all_mddevs list While iterating all_mddevs list from md_notify_reboot() and md_exit(), list_for_each_entry_safe is used, and this can race with deletint the next mddev, causing UAF: t1: spin_lock //list_for_each_entry_safe(mddev, n, ...) mddev_get(mddev1) // assume mddev2 is the next entry spin_unlock t2: //remove mddev2 ... mddev_free spin_lock list_del spin_unlock kfree(mddev2) mddev_put(mddev1) spin_lock //continue dereference mddev2->all_mddevs The old helper for_each_mddev() actually grab the reference of mddev2 while holding the lock, to prevent from being freed. This problem can be fixed the same way, however, the code will be complex. Hence switch to use list_for_each_entry, in this case mddev_put() can free the mddev1 and it's not safe as well. Refer to md_seq_show(), also factor out a helper mddev_put_locked() to fix this problem. Cc: Christoph Hellwig <hch@lst.de> Link: https://lore.kernel.org/linux-raid/20250220124348.845222-1-yukuai1@huaweicloud.com Fixes: f26514342255 ("md: stop using for_each_mddev in md_notify_reboot") Fixes: 16648bac862f ("md: stop using for_each_mddev in md_exit") Reported-and-tested-by:
Guillaume Morin <guillaume@morinfr.org> Closes: https://lore.kernel.org/all/Z7Y0SURoA8xwg7vn@bender.morinfr.org/ Signed-off-by:
-
Nigel Croxon authored
JIRA: https://issues.redhat.com/browse/RHEL-83988 commit 87a86277c9f54953e184318bf71630388aeaf000 Author: Yu Kuai <yukuai3@huawei.com> Date: Sat Feb 15 17:22:25 2025 +0800 md: switch md-cluster to use md_submodle_head To make code cleaner, and prepare to add kconfig for bitmap. Also remove the unsed global variables pers_lock, md_cluster_ops and md_cluster_mod, and exported symbols register_md_cluster_operations(), unregister_md_cluster_operations() and md_cluster_ops. Link: https://lore.kernel.org/linux-raid/20250215092225.2427977-8-yukuai1@huaweicloud.com Signed-off-by:
-
Nigel Croxon authored
JIRA: https://issues.redhat.com/browse/RHEL-83988 commit 3d44e1d1575a877cf75a7776802506ce7ab8ecc4 Author: Yu Kuai <yukuai3@huawei.com> Date: Sat Feb 15 17:22:22 2025 +0800 md: switch personalities to use md_submodule_head Remove the global list 'pers_list', and switch to use md_submodule_head, which is managed by xarry. Prepare to unify registration and unregistration for all sub modules. Link: https://lore.kernel.org/linux-raid/20250215092225.2427977-5-yukuai1@huaweicloud.com Signed-off-by:
-
Nigel Croxon authored
JIRA: https://issues.redhat.com/browse/RHEL-83988 commit c594de0455b3d65525bad2020f7f7e41af233045 Author: Yu Kuai <yukuai3@huawei.com> Date: Sat Feb 15 17:22:24 2025 +0800 md: don't export md_cluster_ops Add a new field 'cluster_ops' and initialize it md_setup_cluster(), so that the gloable variable 'md_cluter_ops' doesn't need to be exported. Also prepare to switch md-cluster to use md_submod_head. Link: https://lore.kernel.org/linux-raid/20250215092225.2427977-7-yukuai1@huaweicloud.com Signed-off-by:
-
Nigel Croxon authored
JIRA: https://issues.redhat.com/browse/RHEL-83988 commit ff84e1b1d215d08651d3adee61d8b834c74ff223 Author: Yu Kuai <yukuai3@huawei.com> Date: Sat Feb 15 17:22:23 2025 +0800 md/md-cluster: cleanup md_cluster_ops reference md_cluster_ops->slot_number() is implemented inside md-cluster.c, just call it directly. Link: https://lore.kernel.org/linux-raid/20250215092225.2427977-6-yukuai1@huaweicloud.com Signed-off-by:
-
Nigel Croxon authored
JIRA: https://issues.redhat.com/browse/RHEL-83988 commit d3beb7c9c61d239e73cb93481b27c7b94130dd03 Author: Yu Kuai <yukuai3@huawei.com> Date: Sat Feb 15 17:22:21 2025 +0800 md: introduce struct md_submodule_head and APIs Prepare to unify registration and unregistration of md personalities and md-cluster, also prepare for add kconfig for md-bitmap. Link: https://lore.kernel.org/linux-raid/20250215092225.2427977-4-yukuai1@huaweicloud.com Signed-off-by:
-
Nigel Croxon authored
JIRA: https://issues.redhat.com/browse/RHEL-83988 commit bf0a73264fa4a66612338da3fbc46262daa97881 Author: Yu Kuai <yukuai3@huawei.com> Date: Sat Feb 15 17:22:20 2025 +0800 md: only include md-cluster.h if necessary md-cluster is only supportted by raid1 and raid10, there is no need to include md-cluster.h for other personalities. Also move APIs that is only used in md-cluster.c from md.h to md-cluster.h. Link: https://lore.kernel.org/linux-raid/20250215092225.2427977-3-yukuai1@huaweicloud.com Signed-off-by:
-
Nigel Croxon authored
JIRA: https://issues.redhat.com/browse/RHEL-83988 commit 9faab548974e3eb858250fea1ab7e823a689b44b Author: Yu Kuai <yukuai3@huawei.com> Date: Sat Feb 15 17:22:19 2025 +0800 md: merge common code into find_pers() - pers_lock() are held and released from caller - try_module_get() is called from caller - error message from caller Merge above code into find_pers(), and rename it to get_pers(), also add a wrapper to module_put() as put_pers(). Link: https://lore.kernel.org/linux-raid/20250215092225.2427977-2-yukuai1@huaweicloud.com Signed-off-by:
-
Nigel Croxon authored
JIRA: https://issues.redhat.com/browse/RHEL-83988 commit 4b10a3bc67c1232f76aa1e04778ca26d6c0ddf7f Author: Li Nan <linan122@huawei.com> Date: Thu Feb 13 21:15:30 2025 +0800 md: ensure resync is prioritized over recovery If a new disk is added during resync, the resync process is interrupted, and recovery is triggered, causing the previous resync to be lost. In reality, disk addition should not terminate resync, fix it. Steps to reproduce the issue: mdadm -CR /dev/md0 -l1 -n3 -x1 /dev/sd[abcd] mdadm --fail /dev/md0 /dev/sdc Fixes: 24dd469d ("[PATCH] md: allow a manual resync with md") Signed-off-by:
Li Nan <linan122@huawei.com> Reviewed-by:
-
Nigel Croxon authored
JIRA: https://issues.redhat.com/browse/RHEL-83988 commit a572593ac80e51eb69ecede7e614289fcccdbf8d Author: Bart Van Assche <bvanassche@acm.org> Date: Wed Jan 29 14:56:35 2025 -0800 md: Fix linear_set_limits() queue_limits_cancel_update() must only be called if queue_limits_start_update() is called first. Remove the queue_limits_cancel_update() call from linear_set_limits() because there is no corresponding queue_limits_start_update() call. This bug was discovered by annotating all mutex operations with clang thread-safety attributes and by building the kernel with clang and -Wthread-safety. Cc: Yu Kuai <yukuai3@huawei.com> Cc: Coly Li <colyli@kernel.org> Cc: Mike Snitzer <snitzer@kernel.org> Cc: Christoph Hellwig <hch@lst.de> Fixes: 127186cfb184 ("md: reintroduce md-linear") Signed-off-by:
Bart Van Assche <bvanassche@acm.org> Reviewed-by:
Song Liu <song@kernel.org> (cherry picked from commit a572593ac80e51eb69ecede7e614289fcccdbf8d) Signed-off-by:
-
