From 2292a7e109d28ffd70ad060b241f9bd2a687dfa0 Mon Sep 17 00:00:00 2001 From: Ed Cashin <ecashin@coraid.com> Date: Mon, 17 Dec 2012 16:03:45 -0800 Subject: [PATCH] aoe: err device: include MAC addresses for unexpected responses The /dev/etherd/err character device provides low-level information about normal but sometimes interesting AoE command retransmits and "unexpected responses", i.e., responses for packets that have already been retransmitted. This change adds MAC addresses to the messages about unexpected responses, so that when they occur, it's more easy to determine the network paths to which they belong. Signed-off-by: Ed Cashin <ecashin@coraid.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> --- drivers/block/aoe/aoecmd.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/block/aoe/aoecmd.c b/drivers/block/aoe/aoecmd.c index f849fa2471caf..6ea27fd8954df 100644 --- a/drivers/block/aoe/aoecmd.c +++ b/drivers/block/aoe/aoecmd.c @@ -1204,12 +1204,14 @@ aoecmd_ata_rsp(struct sk_buff *skb) spin_unlock_irqrestore(&d->lock, flags); aoedev_put(d); snprintf(ebuf, sizeof(ebuf), - "%15s e%d.%d tag=%08x@%08lx\n", + "%15s e%d.%d tag=%08x@%08lx s=%pm d=%pm\n", "unexpected rsp", get_unaligned_be16(&h->major), h->minor, get_unaligned_be32(&h->tag), - jiffies); + jiffies, + h->src, + h->dst); aoechr_error(ebuf); return skb; } -- GitLab