Skip to content
Snippets Groups Projects
  1. Oct 10, 2024
    • Luca Boccassi's avatar
      Revert "logind-dbus: check auth. for all inhibitor operations" · 400261fd
      Luca Boccassi authored
      This has been reported to cause a regression.
      Fixes https://github.com/systemd/systemd-stable/issues/447
      
      This reverts commit 75aefdd9.
      v253.26
      400261fd
    • Luca Boccassi's avatar
      test: mask rc.local generator, broken on Jammy · 85cc6a46
      Luca Boccassi authored
      On jammy it started to fail, it's not really needed and we install
      an empty stub anyway, so just mask the generator
      
      (cherry picked from commit 565916c2)
      (cherry picked from commit dfb007ff)
      85cc6a46
    • Frantisek Sumsal's avatar
      test: drop removed SCSI passthrough feature · 1a20768c
      Frantisek Sumsal authored
      This feature has been deprecated since QEMU 5.0 and finally removed in
      QEMU 9.1 [0] which now causes issues when running the storage tests on
      latest Arch:
      
      ------ testcase_long_sysfs_path: BEGIN ------
      ...
      qemu-system-x86_64: -device virtio-blk-pci,drive=drive0,scsi=off,bus=pci_bridge25: Property 'virtio-blk-pci.scsi' not found
      E: qemu failed with exit code 1
      
      [0] https://github.com/qemu/qemu/commit/a271b8d7b2f39275a05e49deb7c8edc20b7a8279
      
      (cherry picked from commit cd57920fbf6a8f7769a82cfc9bebc12965de0199)
      (cherry picked from commit c5baa5d9d9d778aee25b751387c60f43a0a6fb74)
      (cherry picked from commit 192a6e99)
      (cherry picked from commit 1d245105)
      1a20768c
    • Luca Boccassi's avatar
      semaphore: do not build docs · 7efc3959
      Luca Boccassi authored
      There are other CI runs that build manpages, speed up build which is close to 1hr limit
      
      (cherry picked from commit d58a904d35d3abcb7265b28b14aac596631e27d6)
      (cherry picked from commit 966d8a90ca44659123c15e3a7e7d498aa2b50510)
      (cherry picked from commit 0c6e525a)
      (cherry picked from commit ece14d98)
      7efc3959
    • Luca Boccassi's avatar
      semaphore: stop building and running extra unit tests · e8ced000
      Luca Boccassi authored
      This slows down the build, which is often near the 1hr limit. There are
      other jobs running the extra unit tests.
      
      (cherry picked from commit 3bc5480bac474263881e4c5919d5cce0debf3c40)
      (cherry picked from commit 52afaa8034f59dda44ec181e79604a9a222e60ad)
      (cherry picked from commit 3891c50c)
      (cherry picked from commit 0c82cc26)
      e8ced000
    • Luca Boccassi's avatar
      Semaphore: switch from /tmp to /var/tmp to avoid disk space issues · 57572e26
      Luca Boccassi authored
      Builds have been failing as we run out of space in /tmp/, move to
      /var/tmp
      
      (cherry picked from commit 0c7b5dad33ee01b7ff6b7a8c583a7e2c27ac0673)
      (cherry picked from commit bc0102b0caacb97041ada0b0dbca40da09eab453)
      (cherry picked from commit 82baa27f)
      (cherry picked from commit f19a717e)
      57572e26
    • Luca Boccassi's avatar
      semaphore: remove workaround for adduser · 2bfe1e1b
      Luca Boccassi authored
      Offending commit has been reverted, so it's no longer necessary:
      
      https://salsa.debian.org/ci-team/autopkgtest/-/commit/90167696914889efa782aac3f1f44ab68498c529
      
      Follow-up for 8b7485c5
      
      (cherry picked from commit 2bbe5ca1)
      (cherry picked from commit 030f72f3)
      (cherry picked from commit 55ee831d)
      2bfe1e1b
    • Luca Boccassi's avatar
      semaphore: move back to autopkgtest master branch · 9642f72e
      Luca Boccassi authored
      Instead of fixing the commit, we can workaround the adduser issue by
      simply creating a user manually beforehand, which means the broken
      codepath in autopkgtest is not taken. We can remove it once it's
      fixed upstream, which is in progress:
      
      https://salsa.debian.org/ci-team/autopkgtest/-/merge_requests/297
      (cherry picked from commit 8b7485c5)
      (cherry picked from commit 4f4cd7c9)
      (cherry picked from commit 9b470399)
      9642f72e
    • Luca Boccassi's avatar
      semaphore: speed up build · d737ef1c
      Luca Boccassi authored
      - avoid stripping debug symbols and creating dbgsym packages
      - avoid LTO, slows down build a lot
      - avoid compressing packages, they are thrown out immediately after use
      - avoid building udeb packages, not needed
      
      (cherry picked from commit 7eedcb4e)
      (cherry picked from commit 81930bc0)
      (cherry picked from commit b070eb95)
      d737ef1c
    • Mike Yuan's avatar
      various: correct laccess() error check · 6c142117
      Mike Yuan authored
      laccess is our own macro that uses RET_NERRNO.
      
      (cherry picked from commit 7c1dd9e288047a69d4a6a6dd6585725410cfdadd)
      (cherry picked from commit 4296a567d48ee43917b4f338fa1e927ffd53b36b)
      (cherry picked from commit 9cf6035d)
      (cherry picked from commit 8770e090)
      6c142117
    • Lukáš Nykrýn's avatar
      core: warn if a generator is world-writable · d3683fff
      Lukáš Nykrýn authored
      ... because that is obviously a security risk.
      
      (cherry picked from commit da32cac8a014ddf048fc7bad84dafdbc204d4dc8)
      (cherry picked from commit 7ac58949a37db3ddb662908d3aadaf5934fec222)
      (cherry picked from commit 3b0731b9)
      (cherry picked from commit 7c72562c)
      d3683fff
    • Yu Watanabe's avatar
      test: add test case for issue #34637 · 916fb2dc
      Yu Watanabe authored
      (cherry picked from commit 88d186e4829bc7ef4a4253fe2bf4857903bca830)
      (cherry picked from commit 7b9e412d8aba8f415f35d02da5e5fa5bd92632cc)
      (cherry picked from commit d0569c44)
      (cherry picked from commit 42f7d15e)
      916fb2dc
    • Yu Watanabe's avatar
      udev-node: skip stack directory creation for diskseq · cc2523a5
      Yu Watanabe authored
      The disk/by-diskseq symlink should not be shared with multiple block
      devices. Hence, it is not necessary to create stack directory for the
      symlink that manages which device owns the symlink.
      
      This is not just a optimization.
      If a service unit tries to mount a disk image but the service fails, then
      the diskseq of the loop device for the image may be continuously increased
      during restart, and inodes in /run may increase rapidly, as the stack
      directories are cleaned up only when udev queue is empty.
      
      Fixes #34637.
      
      (cherry picked from commit 09373c1a50297079e6b0447ea97af4e9a60f77fa)
      (cherry picked from commit 02a5e5a32338869cc0ac352da81cf6d83da5c9e9)
      (cherry picked from commit 54bc0dab)
      (cherry picked from commit 67216d22)
      cc2523a5
    • Daniel Martinez's avatar
      Use case insensitive comparison for the machine's architechture · 2641b10e
      Daniel Martinez authored
      boot loader specification states:
      
      architecture: refers to the architecture this entry is for. The argument
      should be an architecture identifier, using the architecture vocabulary
      defined by the EFI specification (i.e. IA32, x64, IA64, ARM, AA64, …).
      If specified and it does not match the local system architecture this
      entry should be hidden. The comparison should be done case-insensitively.
      
      Example: architecture aa64
      
      https://uapi-group.org/specifications/specs/boot_loader_specification/#type-1-boot-loader-entry-keys
      (cherry picked from commit f819a516dbbddb16724f33dcef5badcb6fe8b80b)
      (cherry picked from commit d65b7426e93e50c470173614c2eaca094f318ab5)
      (cherry picked from commit 129c30be)
      (cherry picked from commit a4577e36)
      2641b10e
    • Michal Koutný's avatar
      test: Add test for per-device cgroup properties · 48b38de4
      Michal Koutný authored
      Reported in #34126
      
      (cherry picked from commit 321637743313f896e275fd038996b8cfb5a070b3)
      (cherry picked from commit 84cd501ae4d2689ac39e510d1d33b7e3234f5199)
      (cherry picked from commit 5184f867)
      (cherry picked from commit 43202f55)
      48b38de4
    • Jörg Behrmann's avatar
      man: Use proper conjunction and remove superfluous or · d3ec5867
      Jörg Behrmann authored
      (cherry picked from commit 56f32d9e782f8ba43f17cb04687c915a7e41d10e)
      (cherry picked from commit 5b5f5666b2fd32950325387a3e0bc0b60f0b1808)
      (cherry picked from commit 7cc52eb6)
      (cherry picked from commit c3bcc2f8)
      d3ec5867
    • Luca Boccassi's avatar
      man: consolidate list of active unit states into a shared table · 35263682
      Luca Boccassi authored
      Avoids the need to maintain the same list over and over again, and
      link it to the defition table in the implementation as a reminder
      too
      
      (cherry picked from commit 3509fe124d3a4fe2934028f83ae156ade050c8fe)
      (cherry picked from commit 1075727f7fe9436d2e468147cf663aaa1be867fd)
      (cherry picked from commit 42521e2d)
      (cherry picked from commit e644a619)
      35263682
    • Lukáš Nykrýn's avatar
      man: using WantedBy=default.target is not a good idea · f2fb29f8
      Lukáš Nykrýn authored
      We had several users, that wrote their unit files with
      WantedBy=default.target because it should be started "every time".
      But for example in Fedora/CentOS/RHEL, this often breaks for
      example selinux relabels (where we just want to do a relabel and reboot).
      
      (cherry picked from commit 67b6404b80cf8078f3d9ec6d4c2f34ac25b15077)
      (cherry picked from commit adc57cd81c02e5afc8efcbc64eb3a6305a97c62c)
      (cherry picked from commit 02447d28)
      (cherry picked from commit 3f7bf5ac)
      f2fb29f8
    • Daan De Meyer's avatar
      tree-wide: Fix Wformat warnings · e9c2bd22
      Daan De Meyer authored
      The latest clang has started catching more integer promotions which
      cause us to pass the wrong type to printf() format specifiers so let's
      fix those.
      
      (cherry picked from commit c73d14c43e7998ca54011875ad25afc634d57498)
      (cherry picked from commit e129e3a8618b1b56f70978cb1db1d66a0fdcd573)
      (cherry picked from commit 44e3f1cc)
      (cherry picked from commit 7b9f8e99)
      e9c2bd22
    • Lennart Poettering's avatar
      tree-wide: always do dlopen() with RTLD_NOW + RTLD_NODELETE · 5469d511
      Lennart Poettering authored
      Let's systematically use RTL_NOW|RLTD_NODELETE as flags passed to
      dlopen(), across our codebase.
      
      Various distros build with "-z now" anyway, hence it's weird to specify
      RTLD_LAZY trying to override that (which it doesn't). Hence, let's
      follow suit, and just do what everybody else does.
      
      Also set RTLD_NODELETE, which is apparently what distros will probably
      end up implying sooner or later anyway. Given that for pretty much all
      our dlopen() calls we never call dlclose() anyway, let's just set this
      everywhere too, to make things systematic.
      
      This way, the flags we use by default match what distros such as fedora
      do, there are no surprises, and read-only relocations can be a thing.
      
      Fixes: #34537
      (cherry picked from commit bd4beaa2ebfbbec0a1263a7091a91e528ce8cf13)
      (cherry picked from commit e012eedd727a38bd18c9a540b92b95aa880d2b42)
      (cherry picked from commit 82019cc6)
      (cherry picked from commit 4d4e8b37)
      5469d511
    • Marcel Hellwig's avatar
      Update sd_bus_message_append_array.xml · a921cd8d
      Marcel Hellwig authored
      fix pointer constness in documentation
      
      (cherry picked from commit fec09ff094670a6903b12b1c599b00b39a2b0c88)
      (cherry picked from commit 072ea04e26c84ac25419316c659f4d89d8002f34)
      (cherry picked from commit a422935f)
      (cherry picked from commit add0dca8)
      a921cd8d
    • Zbigniew Jędrzejewski-Szmek's avatar
      systemctl: fix printing of RootImageOptions · f4a7ec30
      Zbigniew Jędrzejewski-Szmek authored
      The type is a(ss), so a custom printer is required.
      
      Fixes https://github.com/systemd/systemd/issues/33967.
      
      (cherry picked from commit 69c751c61cb2b386afe51f03b58f8f7ceeeb643e)
      (cherry picked from commit 28ced52894cf6921d1fe9831f2def29de164e189)
      (cherry picked from commit 64d833df)
      (cherry picked from commit a28e7e93)
      f4a7ec30
    • Daan De Meyer's avatar
      repart: Determine verity sig size based on partition designator · 97871542
      Daan De Meyer authored
      Verity= is an image build concept, not a first boot concept, whereas
      a partition designator is always available, so let's do the size stuff
      based on that.
      
      (cherry picked from commit e11745d000d7e9b3112bb336735c1bdfa77e9add)
      (cherry picked from commit 4143bc70ed7d131cda9f0aa2f86d4aedd38e0fce)
      (cherry picked from commit d371cb47)
      (cherry picked from commit d29a4b9e)
      97871542
    • Michal Koutný's avatar
      core/cgroup: Apply IODevice*= directives in configured order · 52ccb2d5
      Michal Koutný authored
      Different device paths may resolve to same device node
      (lookup_block_device()), e.g.
              IOReadBandwidthMax=/dev/sda1 18879
              IOReadBandwidthMax=/dev/sda2 18878
      where both partitions resolve to /dev/sda and when these values are
      applied (they are associated with original paths, i.e. as if applied for
      different device) in the order from io_device_limits.
      
      The parsing code prepends, so they end up in reverse order wrt config
      file. Switch the direction so that the order of application matches the
      order of configuration -- i.e. semantics in all other unit file
      directives.
      
      Apply same change to all directives that use per-device lists. (The
      question whether partitions should be resolved to base device is
      independent.)
      
      And apply the changes equally to DBus properties write handlers.
      
      Fixes #34126
      
      (cherry picked from commit 0fa0dfa04465651a18107d503f9967f84bd761d1)
      (cherry picked from commit 00dfa7964b5e48a37596207ad8b2862b157cffaf)
      (cherry picked from commit f45acd05)
      (cherry picked from commit 8846e214)
      52ccb2d5
    • Daan De Meyer's avatar
      Add an extra debug log to dissect_image() · 4eb2cafe
      Daan De Meyer authored
      (cherry picked from commit 0121b84e41cd187e44c275a23db1a656656ec37f)
      (cherry picked from commit efd5e357d7ed6b7def0d12631835efd6a5bf5f5a)
      (cherry picked from commit cef973c1)
      (cherry picked from commit 8453f775)
      4eb2cafe
    • Yu Watanabe's avatar
      sd-ipv4acd: fix assertion triggered when an ARP received in STARTED state · 6449cd64
      Yu Watanabe authored
      When a network is busy, an ARP may be received before the timer event
      source triggered first time.
      
      Fixes #34489.
      
      (cherry picked from commit 146b44d0a0001712ced2f22ca76d242eedac26ad)
      (cherry picked from commit 06eb9b14829f3a5819f6daefb09fdb855cd868f4)
      (cherry picked from commit b054898f)
      (cherry picked from commit 8ed0c0bc)
      6449cd64
    • Yu Watanabe's avatar
      test: add tests for seccomp_suppress_sync() · 232eeb16
      Yu Watanabe authored
      (cherry picked from commit c07e10628b6add9ee9664956a28d3f727c9848f8)
      (cherry picked from commit 308c93c51f85f1b6a5e6a3def951fa8e5643048d)
      (cherry picked from commit 299c64d8)
      (cherry picked from commit 0dd69495)
      232eeb16
    • Yu Watanabe's avatar
      seccomp-util: pass negative fds as is to fsync() and friends · a83ca1a2
      Yu Watanabe authored
      
      Closes #34478.
      
      Co-authored-by: default avatarMike Yuan <me@yhndnzj.com>
      (cherry picked from commit 144fbbac235b6b89d5d31795be1cc0dca9852ccc)
      (cherry picked from commit 4bbd6f589ad97a0df6ab59e03c8c535d298d05eb)
      (cherry picked from commit 04a54264)
      (cherry picked from commit c70e6577)
      a83ca1a2
    • Luca Boccassi's avatar
      portable: ensure PORTABLE_FORCE_ATTACH works even when there is a leftover unit · 7778e248
      Luca Boccassi authored
      Force means force, we skip checks with PID1 for existing units, but
      then bail out with EEXIST if the files are actually there. Overwrite
      everything instead.
      
      (cherry picked from commit 1e2d1a7202400e08a00782f32804fdc503259806)
      (cherry picked from commit 2552348da2c961ac9732614eb129228bba4d51da)
      (cherry picked from commit 5ce348ab)
      (cherry picked from commit 7bdcb237)
      7778e248
  2. Sep 11, 2024
    • Luca Boccassi's avatar
      hwdb: update to main@{2024-09-10} · e31a80da
      Luca Boccassi authored
      git restore -s origin/main hwdb.d/ test/hwdb.d
      
      (cherry picked from commit f13e3a93d7c2c549ff9a83cdbb04c30ab9e46bea)
      (cherry picked from commit 799ecea3)
      (cherry picked from commit ea9af9d7)
      v253.25
      e31a80da
    • Yu Watanabe's avatar
      tree-wide: check if non-empty password is acquired · bf4bc357
      Yu Watanabe authored
      (cherry picked from commit 204529d0fcde9a95119b489225620f36649c2f5b)
      (cherry picked from commit e80e9dce63787d1d4494ed65d7c27018344387d5)
      (cherry picked from commit a505f10b)
      (cherry picked from commit 1a628174)
      bf4bc357
    • Yu Watanabe's avatar
      ask-password: refuse empty password strv · 339e0b4c
      Yu Watanabe authored
      Fixes #34270.
      
      (cherry picked from commit 623a8b1922bdbd2fb06bc5f2c67d3d6930efc58e)
      (cherry picked from commit 34881c9d5afdd05e9e6f1824cbea9d1954ea80c0)
      (cherry picked from commit 553d5b03)
      (cherry picked from commit abaef1ab)
      339e0b4c
    • Yu Watanabe's avatar
      test: add test case for systemd-repart --seed=random · 2fa6459c
      Yu Watanabe authored
      For issue #34257.
      
      (cherry picked from commit 56d6ebd40468e2a743b39ad7d87b0675bdf9a042)
      (cherry picked from commit 69282da9aab90c2dc1e440b04af5b2163779515a)
      (cherry picked from commit fbfe769c)
      (cherry picked from commit 1211e6c7)
      2fa6459c
    • Yu Watanabe's avatar
      repart: initialize seed earlier · b859991a
      Yu Watanabe authored
      As the seed is used by context_load_partition_table() -> derive_uuid().
      
      Fixes #34257.
      
      (cherry picked from commit b8a8000aba4620a1d93ac1d04dbb86050d9c5fe8)
      (cherry picked from commit f85a4fba330822c44f9b2deb527acecc03bcfed9)
      (cherry picked from commit 175dafa2)
      (cherry picked from commit ed474d3e)
      b859991a
    • Yu Watanabe's avatar
      nspawn: refuse to bind mount device node from host when --private-users= is specified · 675c5775
      Yu Watanabe authored
      Also do not chown if a device node is bind-mounted.
      
      Fixes #34243.
      
      (cherry picked from commit efedb6b0f3cff37950112fd37cb750c16d599bc7)
      (cherry picked from commit a23591891b9e85107f39d103eabbb5bc9a6ced6f)
      (cherry picked from commit bc72d955)
      (cherry picked from commit b431088c)
      675c5775
    • Mike Yuan's avatar
      audit-util: check correct errno · 6dadc4e1
      Mike Yuan authored
      (cherry picked from commit 190a0953808608b099f9465f9e786e4efe276c26)
      (cherry picked from commit c90ae08b0a5f2844504a109f71dcd773c16d8260)
      (cherry picked from commit a3872e60)
      (cherry picked from commit 4503a6d9)
      6dadc4e1
    • Daan De Meyer's avatar
      repart: Keep existing directory timestamps intact when copying · 3adfd9f4
      Daan De Meyer authored
      Otherwise, when merging multiple directory trees, the output becomes
      unreproducible as the directory timestamps will be changed to the current
      time when copying identical directories from the second tree.
      
      We introduce a new copy flag to achieve this behavior.
      
      (cherry picked from commit d850a544bc1f895decb452160c97a884a20b12b7)
      (cherry picked from commit d5640c4f8583de2752a7f4e03006a1fa74942da1)
      (cherry picked from commit 7a3b3ad5)
      (cherry picked from commit 87cc4d90)
      3adfd9f4
    • Ronan Pigott's avatar
      resolved: clear the AD bit for bypass packets · f37f685b
      Ronan Pigott authored
      When the bypass logic is invoked, such as for queries to the stub with
      the DO bit set, be certain to clear the AD bit in the reply before
      forwarding it if the answer is not known to be authentic.
      
      (cherry picked from commit 13e15dae9f0b4566d3ea2ed058a5dd44751216da)
      (cherry picked from commit 3a2be652282db2d55d5e28546e6c9a594fb8c43e)
      (cherry picked from commit 6c243bbb)
      (cherry picked from commit edec5cc5)
      f37f685b
    • Alyssa Ross's avatar
      bootctl: don't load etc/machine-info from cwd · 30fdceaf
      Alyssa Ross authored
      arg_root defaults to null, so if --root isn't given, this would try reading
      etc/machine-info from the current working directory, which is likely to fail.
      
      Fixes: 77db9ef2 ("boot: Make sure we take --root into account everywhere.")
      (cherry picked from commit 0452779b0054f5c2724b745b1db33bba1ac8e677)
      (cherry picked from commit 8d7eef9ee5ead7c7b47b2ad4418529ac5cf17bb3)
      (cherry picked from commit a573fd18)
      (cherry picked from commit 0b6faf92)
      30fdceaf
    • Raphaël Mélotte's avatar
      src/basic/missing_loop.h: fix missing LOOP_SET_BLOCK_SIZE · 4e088c3a
      Raphaël Mélotte authored
      Builds with kernels headers < 4.14 fail with:
      
      ../src/shared/loop-util.c: In function ‘loop_configure_fallback’:
      ../src/shared/loop-util.c:237:31: error: ‘LOOP_SET_BLOCK_SIZE’ undeclared (first use in this function); did you mean ‘LOOP_SET_DIRECT_IO’?
                       if (ioctl(fd, LOOP_SET_BLOCK_SIZE, (unsigned long) c->block_size) < 0)
                                     ^~~~~~~~~~~~~~~~~~~
                                     LOOP_SET_DIRECT_IO
      
      Fixes: https://github.com/systemd/systemd/issues/33341
      
      
      
      Signed-off-by: default avatarRaphaël Mélotte <raphael.melotte@mind.be>
      (cherry picked from commit 56ab1c54497d9fac74380ff9e11aaf931a917d2b)
      (cherry picked from commit 0730ec4f3ecbbb550864ff0dbadeeeb5e271eb50)
      (cherry picked from commit ed087e86)
      (cherry picked from commit e9e2923b)
      4e088c3a