From 42ed12656016a96b966b7b5e52f0b684ad65c227 Mon Sep 17 00:00:00 2001
From: Laszlo Agocs <laszlo.p.agocs@nokia.com>
Date: Sat, 28 Jan 2012 20:56:28 +0200
Subject: [PATCH] Do not attach null buffer.
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Apparently Weston does not like this and causes instant crashes when
hiding a top-level widget.  The QtCompositor-side behavior is dubious
too although at least that does not crash. Nevertheless attaching a
null buffer seems unnecessary.

Change-Id: I1d7fe3e0b05e5d77773b661a71bc37311968eded
Sanity-Review: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Jørgen Lind <jorgen.lind@nokia.com>
---
 src/plugins/platforms/wayland/qwaylandwindow.cpp | 2 --
 1 file changed, 2 deletions(-)

diff --git a/src/plugins/platforms/wayland/qwaylandwindow.cpp b/src/plugins/platforms/wayland/qwaylandwindow.cpp
index 97aed6d7..bbb805a5 100644
--- a/src/plugins/platforms/wayland/qwaylandwindow.cpp
+++ b/src/plugins/platforms/wayland/qwaylandwindow.cpp
@@ -125,8 +125,6 @@ void QWaylandWindow::setVisible(bool visible)
             wl_surface_attach(mSurface, mBuffer->buffer(),0,0);
             QWindowSystemInterface::handleSynchronousExposeEvent(window(), QRect(QPoint(), geometry().size()));
         }
-    } else {
-        wl_surface_attach(mSurface, 0,0,0);
     }
 }
 
-- 
GitLab